Wireshark-commits, January 2015
- [Wireshark-commits] master a53b67c: Don't include header files that we don't appear to need.,
Wireshark code review
- [Wireshark-commits] master 114e773: Call setlocale() before getting version information.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master 889c566: Eliminate proto_tree_add_text from WiMax plugin.,
Wireshark code review
- [Wireshark-commits] master 21697af: Added DNP3 support for g13 and g43, output command events,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master a4019a3: Rename a variable to avoid a compiler warning.,
Wireshark code review
- [Wireshark-commits] master 8bf7078: Move ui/qt/main.cpp to wireshark-qt.cpp, and get rid of the dummy.cpp hack.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 0a64b55: Remove wireshark_cxx.,
Wireshark code review
- [Wireshark-commits] master 219d37e: Let routines from the Kerberos dissector be called from C++.,
Wireshark code review
- [Wireshark-commits] master 6ef4cbd: Include "file.h" to get read_keytab_file() declared.,
Wireshark code review
- [Wireshark-commits] master e8e38b4: wireshark-qt.cpp is only a Qt Wireshark source file.,
Wireshark code review
- [Wireshark-commits] master 1663c2a: Welcome in 2015,
Wireshark code review
- [Wireshark-commits] master-1.12 e6bd678: Welcome in 2015,
Wireshark code review
- [Wireshark-commits] master-1.10 d1559a1: Welcome in 2015,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] master 72f035d: Qt: fix crash when opening Preferences window on Windows,
Wireshark code review
- [Wireshark-commits] master 7ed0cd7: wireshark-qt.cpp belongs in, err, umm, the Qt Wireshark - not the GTK+ one.,
Wireshark code review
- [Wireshark-commits] master 6d6ba64: .gitignore: Add '*.nativecodeanalysis.xml',
Wireshark code review
- [Wireshark-commits] master-1.12 789c41b: Lua: getting fieldinfo.value for FT_NONE causes assert,
Wireshark code review
- [Wireshark-commits] master-1.10 d4f7bbb: Lua: getting fieldinfo.value for FT_NONE causes assert,
Wireshark code review
- [Wireshark-commits] master 445ddc8: Lua: FieldInfo '==' check isn't really equality,
Wireshark code review
- [Wireshark-commits] master 5981dab: Declare read_keytab_file() in epan/dissectors/packet-kerberos.h.,
Wireshark code review
- [Wireshark-commits] master 43f09e6: Remove unneeded includes from ui folder,
Wireshark code review
- [Wireshark-commits] master 6c24c7e: Clean up indentation.,
Wireshark code review
- [Wireshark-commits] master 2ce7dfe: More indentation cleanups.,
Wireshark code review
- [Wireshark-commits] master f384fa0: Fix tpyo.,
Wireshark code review
- [Wireshark-commits] master 07c9492: Remove pkt_comment member from packet_info structure.,
Wireshark code review
- [Wireshark-commits] master 860cb39: tshark: Add endpoints statistics,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC,
buildbot-no-reply
- [Wireshark-commits] master 1c14f5b: Restore inclusion of gui_utils.h to pixmap_save.c,
Wireshark code review
- [Wireshark-commits] master 887cce4: Restore another include to try to fix solaris build,
Wireshark code review
- [Wireshark-commits] master 454fd6e: Add "Editor modelines"; Adjust whitespace as needed.,
Wireshark code review
- [Wireshark-commits] master 06a1f46: Have hf variables outputted in the order they were found in the file.,
Wireshark code review
- [Wireshark-commits] master 5c529c9: Add '*.nativecodeanalysis.xml' to 'clean' targets,
Wireshark code review
- [Wireshark-commits] master 8541578: When deccoding base-64, the result is the length of the *decoded* result.,
Wireshark code review
- [Wireshark-commits] master-1.12 627b248: Clean up indentation.,
Wireshark code review
- [Wireshark-commits] master-1.12 268f890: More indentation cleanups.,
Wireshark code review
- [Wireshark-commits] master-1.12 db22c94: Fix tpyo.,
Wireshark code review
- [Wireshark-commits] master-1.12 e3c0c98: When deccoding base-64, the result is the length of the *decoded* result.,
Wireshark code review
- [Wireshark-commits] master-1.10 2596de1: Clean up indentation.,
Wireshark code review
- [Wireshark-commits] master-1.10 9c8897d: More indentation cleanups.,
Wireshark code review
- [Wireshark-commits] master-1.10 38b911d: Fix tpyo.,
Wireshark code review
- [Wireshark-commits] master-1.10 2d23bcd: When deccoding base-64, the result is the length of the *decoded* result.,
Wireshark code review
- [Wireshark-commits] master a621bb7: Revert "Bring pkg.m4 in from pkgconfig version 0.28 so we can use the PKG_PROG_PKG_CONFIG macro to try searching for pkg-config even when it isn't installed. Without this (and without pkg-config installed) the configure script is broken. With it, it gives a mes",
Wireshark code review
- [Wireshark-commits] master 611cfd0: Always set decrypt_len when setting decrypt.,
Wireshark code review
- [Wireshark-commits] master 55c385e: tvb: implement endianness-paramterized getters,
Wireshark code review
- [Wireshark-commits] master-1.12 de70b34: Always set decrypt_len when setting decrypt.,
Wireshark code review
- [Wireshark-commits] master-1.10 da8282d: Always set decrypt_len when setting decrypt.,
Wireshark code review
- [Wireshark-commits] master 3cc6aee: Lua: regex test suite fails with UTF-8 locale,
Wireshark code review
- [Wireshark-commits] master 7935ba9: Eliminate proto_tree_add_text from packet-ositp.c,
Wireshark code review
- [Wireshark-commits] master 27fa202: Make it easier to run tests out of tree.,
Wireshark code review
- [Wireshark-commits] master 1c7ffed: ositp: fix some BASE_ errors from g7935ba9f5be,
Wireshark code review
- [Wireshark-commits] master 5cb96a0: test: default WS_QT_BIN_PATH to WS_BIN_PATH,
Wireshark code review
- [Wireshark-commits] master 887d198: test: improve check for out-of-tree tests,
Wireshark code review
- [Wireshark-commits] master a3c705a: mux27010: Add a link to info about the mux27010 packet structure.,
Wireshark code review
- [Wireshark-commits] master e7d0cdc: Fix lua tests on Windows,
Wireshark code review
- [Wireshark-commits] master-1.12 b8bf07e: Test suite: Make sure we have a usable locale before we run iconv.,
Wireshark code review
- [Wireshark-commits] master-1.10 9a8d334: Test suite: Make sure we have a usable locale before we run iconv.,
Wireshark code review
- [Wireshark-commits] master b90f784: Add sanity check to ensure integer types don't get set to BASE_NONE.,
Wireshark code review
- [Wireshark-commits] master 7d943e1: Add back "version.h" inclusion,
Wireshark code review
- [Wireshark-commits] master-1.12 a1ce28d: Update the release notes for 1.12.3.,
Wireshark code review
- [Wireshark-commits] master-1.10 00a234a: Update the release notes for 1.10.12.,
Wireshark code review
- [Wireshark-commits] master 42baa9d: USB HID: fix report descriptor main items dissection,
Wireshark code review
- [Wireshark-commits] master-1.12 c726188: USB HID: fix report descriptor main items dissection,
Wireshark code review
- [Wireshark-commits] master-1.10 b24463e: USB HID: fix report descriptor main items dissection,
Wireshark code review
- [Wireshark-commits] master 970e7c1: Try to clarify the PowerShell requirements.,
Wireshark code review
- [Wireshark-commits] master 5eecf81: Don't define a stub read_keytab_file() on Windows if we don't have Kerberos.,
Wireshark code review
- [Wireshark-commits] master d1d5bf1: Replace proto_tree_add_text in dissector header files where it was used in a macro that should be expert info.,
Wireshark code review
- [Wireshark-commits] master 33ba8d3: Support -K iff HAVE_KERBEROS is defined.,
Wireshark code review
- [Wireshark-commits] master 16fe32f: Temporarily #if 0 out the call to read_keytab_file().,
Wireshark code review
- [Wireshark-commits] master 544ed8a: Stick some #define probes in on Windows.,
Wireshark code review
- [Wireshark-commits] master 61c6fb8: Remove the probes from packet-kerberos.c.,
Wireshark code review
- [Wireshark-commits] master d7c3edd: Lua: replace deprecated functions,
Wireshark code review
- [Wireshark-commits] master e7c4241: Fix Windows x64 CMake build,
Wireshark code review
- [Wireshark-commits] master 0452f76: [PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits,
Wireshark code review
- [Wireshark-commits] master e133ba9: tshark: dump port number when generating SCTP endpoints statistics,
Wireshark code review
- [Wireshark-commits] master-1.12 43822b3: [PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits,
Wireshark code review
- [Wireshark-commits] master-1.10 25a7dd1: [PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits,
Wireshark code review
- [Wireshark-commits] master 2f34ae9: Remove the testing stuff.,
Wireshark code review
- [Wireshark-commits] master 17dcd95: IPv6: do not allocate tap data on stack,
Wireshark code review
- [Wireshark-commits] master-1.12 c3f22d9: IPv6: do not allocate tap data on stack,
Wireshark code review
- [Wireshark-commits] master 4d3acd9: tshark: dump port number when generating SCTP, TCP or UDP conversations,
Wireshark code review
- [Wireshark-commits] master-1.10 adb08fa: IPv6: do not allocate tap data on stack,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master 1f3849c: CMake: Clobber the top-level config.h before we build.,
Wireshark code review
- [Wireshark-commits] master a190c93: Remove unnecessary includes from wiretap folder,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master-1.10 17268c4: IPv6: fix compilation when building with GeoIP support,
Wireshark code review
- [Wireshark-commits] master dfa50e6: Use get_ws_vcs_version() to generate the version string.,
Wireshark code review
- [Wireshark-commits] master 760aa14: Use g_strdup_printf(), rather than a fixed-length buffer, for the app name.,
Wireshark code review
- [Wireshark-commits] master 9ab44b3: Info.plist : fix indent (use tabs),
Wireshark code review
- [Wireshark-commits] master 9df7386: It is also 2015 for Mac OS X :-),
Wireshark code review
- [Wireshark-commits] master 9384854: Use g_strdup_printf(), rather than a fixed-length buffer, for the app name.,
Wireshark code review
- [Wireshark-commits] master aad1a81: Fix out-of-tree build includes of config.h,
Wireshark code review
- [Wireshark-commits] master-1.12 b359ca1: Lua: FieldInfo '==' check isn't really equality,
Wireshark code review
- [Wireshark-commits] master-1.10 31f3669: Lua: FieldInfo '==' check isn't really equality,
Wireshark code review
- [Wireshark-commits] master-1.12 4540faf: Lua: regex test suite fails with UTF-8 locale,
Wireshark code review
- [Wireshark-commits] master 2ef85f5: WiFi Display: fix no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 7c9d6ff: Lua: replace proto_tree_add_text calls,
Wireshark code review
- [Wireshark-commits] master a16ac8f: gmr1_rach: Use FT_INT24 instead of FT_UINT24 for latitude/longitude,
Wireshark code review
- [Wireshark-commits] master a22ea3d: gmr1_rach: Update NULL GPS position decoding with reality,
Wireshark code review
- [Wireshark-commits] master 98ba630: gmr1_rach: Fixup the MOC Dialled Number decoding,
Wireshark code review
- [Wireshark-commits] master 83ac5b7: GTPv2: fix Logically dead code (CID 1255924),
Wireshark code review
- [Wireshark-commits] master fa0ebfc: BACAPP: fix empty paragraph passed to '@param' command [-Wdocumentation],
Wireshark code review
- [Wireshark-commits] master b0b51dd: GTPv2: fix Logically dead code (CID 1250813),
Wireshark code review
- [Wireshark-commits] master dbcb0b5: stats tree plugin: fix no previous prototype for 'plugin_register_tap_listener' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master 1cd9d02: [Automatic manuf, services and enterprise-numbers update for 2015-01-04],
Wireshark code review
- [Wireshark-commits] master-1.12 17f8d39: [Automatic manuf, services and enterprise-numbers update for 2015-01-04],
Wireshark code review
- [Wireshark-commits] master-1.10 ba644ad: [Automatic manuf, services and enterprise-numbers update for 2015-01-04],
Wireshark code review
- [Wireshark-commits] master 84e43d9: gmr1_rach: Add support for GmPRS/GMR-1 3G Channel Request Type 1 & 2,
Wireshark code review
- [Wireshark-commits] master 2085bbe: gmr1_rach: Update dual-values fields to use true_false_string,
Wireshark code review
- [Wireshark-commits] master 553da37: Create BASE_DOT, BASE_DASH, and BASE_SEMICOLON types for the FT_BYTES field type.,
Wireshark code review
- [Wireshark-commits] master ff01bc6: gtk: fix crash when moving columns,
Wireshark code review
- [Wireshark-commits] master 4a94374: Fix linkage on Windows machine,
Wireshark code review
- [Wireshark-commits] master f648247: Get rid of warning: comma at end of enumerator list [-Wpedantic],
Wireshark code review
- [Wireshark-commits] master c2f6ce7: TCP: Update Multipath TCP (MPTCP) to final RFC (RFC 6824),
Wireshark code review
- [Wireshark-commits] master ac52f0e: SCTP (Graph Dialog Qt): fix Copy-paster error (CID 1158585),
Wireshark code review
- [Wireshark-commits] master d3581ae: Make sure we don't underrun a buffer when decrypting SSL.,
Wireshark code review
- [Wireshark-commits] master d16f114: Convert "FC Member Identifier" fields from all strings to their "native" formats.,
Wireshark code review
- [Wireshark-commits] master d9b480d: PKIX1Explicit: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master-1.12 d58037a: PKIX1Explicit: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master-1.10 d9de68d: PKIX1Explicit: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master 9aeb249: ACSE: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master-1.12 c6adf15: ACSE: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master-1.10 d09456c: ACSE: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master 5653fce: No *pcap should have pcap_open() without the other remote extensions.,
Wireshark code review
- [Wireshark-commits] master fac8356: Make all Lua code use wmem not emem,
Wireshark code review
- [Wireshark-commits] master 553cdfd: No need to #define HAVE_PYTHON.,
Wireshark code review
- [Wireshark-commits] master 2f1ac87: Clean up handling of INET6.,
Wireshark code review
- [Wireshark-commits] master 05fd11e: Add a check for NL80211_PROTOCOL_FEATURE_SPLIT_WIPHY_DUMP.,
Wireshark code review
- [Wireshark-commits] master 8fe6b04: Note why we only default to enabling libnl on Linux.,
Wireshark code review
- [Wireshark-commits] master 533f857: Don't check for nl80211 stuff if we don't have libnl.,
Wireshark code review
- [Wireshark-commits] master fc39b9b: In CMake, check for thousands-grouping support in the GLib printf routines.,
Wireshark code review
- [Wireshark-commits] master 087723a: Suppress the check for ' as a formatting character on Windows.,
Wireshark code review
- [Wireshark-commits] master 696fcdb: Added DNS statistics support,
Wireshark code review
- [Wireshark-commits] master c411029: Update to QCustomPlot 1.3.0,
Wireshark code review
- [Wireshark-commits] master b03a21a: SMTP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 4270673: OSITP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 9a7318a: Wimax: fix no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 22b4ec9: Replace ep_display_to_address with wmem equivalent display_to_address.,
Wireshark code review
- [Wireshark-commits] master cbc5faa: Get rid of some GNU make extensions so users can build with the make that comes with *BSD and other systems now.,
Wireshark code review
- [Wireshark-commits] master-1.12 f5e435a: Make sure we don't underrun a buffer when decrypting SSL.,
Wireshark code review
- [Wireshark-commits] master-1.10 7fc3a06: Make sure we don't underrun a buffer when decrypting SSL.,
Wireshark code review
- [Wireshark-commits] master 13dbf52: Attempt to fix "make distcheck" on Ubuntu buildbot,
Wireshark code review
- [Wireshark-commits] master 15a238a: Override optimization and other flags for make based generators. Before this patch it was not possible to override e.g. the optimization or debug flags in case the build type was set.,
Wireshark code review
- [Wireshark-commits] master 318b8f8: Beginnings of dissection of the dji drones control protocol.,
Wireshark code review
- [Wireshark-commits] master 1176db2: Squelch harmless compiler warnings.,
Wireshark code review
- [Wireshark-commits] master a7a1704: Minor CMake updates to better group build artefacts,
Wireshark code review
- [Wireshark-commits] master eb98b04: Revert "[PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits",
Wireshark code review
- [Wireshark-commits] master 124272e: [PROFINET] v2: Fix swapped MaintenanceRequired & MaintenanceDemanded bits,
Wireshark code review
- [Wireshark-commits] master 55de46f: Replace ep_address_to_str with address_to_str.,
Wireshark code review
- [Wireshark-commits] master-1.12 29e1f73: Revert "[PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits",
Wireshark code review
- [Wireshark-commits] master-1.10 a3362be: Revert "[PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits",
Wireshark code review
- [Wireshark-commits] master e8568c8: s5066sis: Consume transport layer data in S5066sis,
Wireshark code review
- [Wireshark-commits] master 0910b55: s5066ses: Fixed some missing sapid mappings.,
Wireshark code review
- [Wireshark-commits] master cbca7ee: p_mul: Indicate if fletcher algorithm is used.,
Wireshark code review
- [Wireshark-commits] master 5fb2f27: Qt: Add a context menu to the packet list header.,
Wireshark code review
- [Wireshark-commits] master 1d7da82: DNS: fix no previous prototype for 'qname_labels_count' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master dd65274: Revert e65f581ffa86f6bfd566a9b66ca2c882f465727f, which reverts commit 89291ad4f3293893387b385a0800cad42215ddd4 Protect the new macro with "m4_ifdef" instead. Add comments to keep the old and the new flags in sync.,
Wireshark code review
- [Wireshark-commits] master 087fea3: DJI UAV: Add dissector to autotools and add modelines info,
Wireshark code review
- [Wireshark-commits] master a70929c: CMake: Add an ENABLE_CODE_ANALYSIS option.,
Wireshark code review
- [Wireshark-commits] master ea46a44: NSIS: Move definitions to their own file.,
Wireshark code review
- [Wireshark-commits] master 29207bf: $(MSVCR_DLL) might contain spaces, so we need to quote that sed expression.,
Wireshark code review
- [Wireshark-commits] master f39366b: NetFlow: Add Ixia 'IxFlow' fields and make some general usability improvements,
Wireshark code review
- [Wireshark-commits] master a6e6dee: NSIS: Quote all paths in config.nsh.,
Wireshark code review
- [Wireshark-commits] master 119f564: MBIM: call dissector_(add|delete)_uint only when necessary,
Wireshark code review
- [Wireshark-commits] master 6e03daf: Try to suppress clang warnings in exntest.,
Wireshark code review
- [Wireshark-commits] master e3eab83: checkAPIs: C++ comments are allowed in Windows resource files.,
Wireshark code review
- [Wireshark-commits] master 85e69d4: Fix GCC pragma.,
Wireshark code review
- [Wireshark-commits] master 0f426d6: Improved handling of ARDP fragmented packets.,
Wireshark code review
- [Wireshark-commits] master 47d670d: Add tvb_address_to_str.,
Wireshark code review
- [Wireshark-commits] master 3bb887f: Fix compiler error because I didn't completely amend last patch.,
Wireshark code review
- [Wireshark-commits] master a76559e: Cast away an insignificant warning.,
Wireshark code review
- [Wireshark-commits] master 9696eb6: SMB: the "encryption key" in the negotiate response is not really a key but the data for the Challenge/Response authentication,
Wireshark code review
- [Wireshark-commits] master 50a9863: Don't run checkapi on .rc files.,
Wireshark code review
- [Wireshark-commits] master 6252074: DJIUAV: small cleanups,
Wireshark code review
- [Wireshark-commits] master-1.12 9b54fc9: [PROFINET] v2: Fix swapped MaintenanceRequired & MaintenanceDemanded bits,
Wireshark code review
- [Wireshark-commits] master 4088a82: SET_ADDRESS -> TVB_SET_ADDRESS to "hide" some of the tvb_get_ptr use.,
Wireshark code review
- [Wireshark-commits] master ed9a9be: Use tvb_address_to_str as an optimization,
Wireshark code review
- [Wireshark-commits] master 734e408: MSVC: Fix opting out of libraries,
Wireshark code review
- [Wireshark-commits] master a479d9a: simplify tvb_address_to_str,
Wireshark code review
- [Wireshark-commits] master 667897c: [MIP6] Update to handling of Mobility Header Link-Layer Address (MH-LLA) Option to RFC 5268 e.g no special handling of length. Bug:10043,
Wireshark code review
- [Wireshark-commits] master 2139110: Updates in it translation.,
Wireshark code review
- [Wireshark-commits] master 493f03b: Remove bytestring_to_ep_str,
Wireshark code review
- [Wireshark-commits] master 9cfe67f: tvb_bytes_to_ep_str_punct -> tvb_bytes_to_str_punct,
Wireshark code review
- [Wireshark-commits] master 98d3b14: Replace bytes_to_ep_str_punct with wmem equivalent.,
Wireshark code review
- [Wireshark-commits] master 64a7bac: tvb_bytes_to_ep_str -> tvb_bytes_to_str,
Wireshark code review
- [Wireshark-commits] master a6ba632: BTLE: Nesting level does not match indendation (CID 1261651),
Wireshark code review
- [Wireshark-commits] master d3f67c1: S5066DTS: Nesting level does not match indendation (CID 1159211 & 1159212),
Wireshark code review
- [Wireshark-commits] master ccce7ab: capture file dlg (GTK): Nesting level does not match indendation (CID 1159217),
Wireshark code review
- [Wireshark-commits] master 5e8c053: Squelch a compiler warning.,
Wireshark code review
- [Wireshark-commits] master-1.12 bb3e9a0: Build 1.12.3.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.3 created (now 8605635),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.12.3 created (now fb55d38),
Wireshark code review
- [Wireshark-commits] master-1.10 7b5d5e9: Build 1.10.12.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.10.12 created (now 15f20a6),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.10.12 created (now 5455d6d),
Wireshark code review
- [Wireshark-commits] master-1.12 12b31d2: 1.12.3 → 1.12.4.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.4rc0 created (now 5826748),
Wireshark code review
- [Wireshark-commits] master-1.10 247208d: 1.10.12 → 1.10.13.,
Wireshark code review
- [Wireshark-commits] master-1.10 3ce09db: 1.10.12 → 1.10.13.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.10.13rc0 created (now 71015a2),
Wireshark code review
- [Wireshark-commits] master 8f1b82b: Set the (GT) address even if the message is routed by SSN.,
Wireshark code review
- [Wireshark-commits] master 6edb27b: FT_DOUBLEs are 8 bytes; use FT_FLOAT for 4-byte floating-point values.,
Wireshark code review
- [Wireshark-commits] master-1.12 add9472: FT_DOUBLEs are 8 bytes; use FT_FLOAT for 4-byte floating-point values.,
Wireshark code review
- [Wireshark-commits] master d245f38: packet-irda.c: Add editor modelines,
Wireshark code review
- [Wireshark-commits] master 907d145: Various minor updates to the LBM dissectors.,
Wireshark code review
- [Wireshark-commits] master 2209678: ep_<protocol>_port_to_display -> <protocol>_port_to_display,
Wireshark code review
- [Wireshark-commits] master 4a5ca5c: bytes_to_ep_str -> bytes_to_str,
Wireshark code review
- [Wireshark-commits] master 5d610b5: Remove decode_numeric_bitfield.,
Wireshark code review
- [Wireshark-commits] master cff098e: guid_to_ep_str -> guid_to_str,
Wireshark code review
- [Wireshark-commits] master 20414eb: Replace some ep_alloc and ep_alloc0 with its wmem equivalent.,
Wireshark code review
- [Wireshark-commits] master 866d2f8: PPCAP: Nesting level does not match indendation (CID 1259218),
Wireshark code review
- [Wireshark-commits] master dcc4936: use the http server port as index for the ws.port dissector table,
Wireshark code review
- [Wireshark-commits] master 37e64d8: Unistim: Nesting level does not match indendation (CID 1159216),
Wireshark code review
- [Wireshark-commits] master a323f0c: packet-mq: Add New Def, Reformat Lines, re-order val_str def,
Wireshark code review
- [Wireshark-commits] master 513ed24: ieee80211: initialize bssid for data frames,
Wireshark code review
- [Wireshark-commits] master b6cf61b: Small parenthesis fix,
Wireshark code review
- [Wireshark-commits] master bd1cd01: GTK/RTP Player: Fix crash when touch RTP Stream,
Wireshark code review
- [Wireshark-commits] master a3e934f: BATADV: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master ec8ca91: BTSDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 0078211: Add quotation marks in Conversations/Endpoints when address is string,
Wireshark code review
- [Wireshark-commits] master 2021845: autotools: Add possibility to build without optional codec SBC,
Wireshark code review
- [Wireshark-commits] master 2d448f0: Eliminate proto_tree_add_text from some dissectors.,
Wireshark code review
- [Wireshark-commits] master e63e771: Bluetooth: AVDTP: Present bitfields for codec ad true/false,
Wireshark code review
- [Wireshark-commits] master e123878: zbee-zcl-misc: Minor changes,
Wireshark code review
- [Wireshark-commits] master 90453a4: mka: Minor cleanup,
Wireshark code review
- [Wireshark-commits] master 8bfd306: Bluetooth: Update to latest Assigned Numbers (up to 4.2),
Wireshark code review
- [Wireshark-commits] master c94192d: Netflow: add (hidden) root filters for each vendor with supported 'pie' entries,
Wireshark code review
- [Wireshark-commits] master d8773b1: MQ: fix crash at startup,
Wireshark code review
- [Wireshark-commits] master 4b8c668: To register an SCTP port, register in "sctp.port", not "udp.port".,
Wireshark code review
- [Wireshark-commits] master-1.12 05cd2fc: To register an SCTP port, register in "sctp.port", not "udp.port".,
Wireshark code review
- [Wireshark-commits] master-1.10 0b25666: To register an SCTP port, register in "sctp.port", not "udp.port".,
Wireshark code review
- [Wireshark-commits] master cd7408e: CMake: Enable DocBook on Windows.,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 6812cfb: wccp: use pinfo-scope memory for addresses,
Wireshark code review
- [Wireshark-commits] master 1baf9bb: Use G_GINT64_CONSTANT() for 64-bit constants.,
Wireshark code review
- [Wireshark-commits] master 315cc72: CMake: Revert the release notes xsltproc command.,
Wireshark code review
- [Wireshark-commits] master 03f273a: HTML Help: Fix titles.,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 f4f1199: Make sure we don't underrun a buffer when decrypting SSL.,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 b98bcd4: Make sure we don't underrun a buffer when decrypting SSL.,
Wireshark code review
- [Wireshark-commits] master ab717f2: Use the FindHTMLHelp.cmake provided by cmake to find the hhc. Lower case some function/macro calls.,
Wireshark code review
- [Wireshark-commits] master a2abf8b: Fix CMake Warning "Argument not separated from preceding token by whitespace.",
Wireshark code review
- [Wireshark-commits] master ecaa1f8: convert variables that were static just because of SET_ADDRESS macro to use the proper pinfo->pool instead.,
Wireshark code review
- [Wireshark-commits] master 67b1593: Remove proto_tree_add_ax25,
Wireshark code review
- [Wireshark-commits] master 4bc8d0f: CMake: Try to fix the xsltproc path.,
Wireshark code review
- [Wireshark-commits] master fb40fd3: Add a possible replacement for the cmd hack to work around hhc.exe returning non-null on success. To be invoked via "cmake -P hhc.cmake <single-arg>".,
Wireshark code review
- [Wireshark-commits] master 45cbdbc: Add missing #include ( "ui/gtk/old-gtk-compat.h" ),
Wireshark code review
- [Wireshark-commits] master d296c75: Some more random removal of ep_ memory.,
Wireshark code review
- [Wireshark-commits] master 456095c: disperse atalk-utils.[ch],
Wireshark code review
- [Wireshark-commits] master 6a6e2ef: Have ipxnet addresses use wmem scoped memory.,
Wireshark code review
- [Wireshark-commits] master 879a221: Bluetooth: BTLE RF: Remove tree and reduce indentation level,
Wireshark code review
- [Wireshark-commits] master 5be440f: Bluetooth: AVDTP/VDP: Add link to first and last packet in the stream,
Wireshark code review
- [Wireshark-commits] master 17f1a44: Bluetooth: AVDTP: Fix other-side Reconfigure,
Wireshark code review
- [Wireshark-commits] master 284229c: Convert EUI64 address APIs to use wmem.,
Wireshark code review
- [Wireshark-commits] master 872a239: Add missing #include ( "ui/gtk/old-gtk-compat.h" ),
Wireshark code review
- [Wireshark-commits] master 1b4f965: Some typos fixed.,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 1c14dd9: LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value,
Wireshark code review
- [Wireshark-commits] master ffb6f10: CMake: Cygwin-ify the xmllint path as well.,
Wireshark code review
- [Wireshark-commits] master 4f65899: CMake: Migrate to hhc.cmake.,
Wireshark code review
- [Wireshark-commits] master f5de0c4: Netflow: Fix some duplicate label names,
Wireshark code review
- [Wireshark-commits] master 2bb26ea: CMake: Copy CHM graphics from the correct source.,
Wireshark code review
- [Wireshark-commits] master a81f0d1: Fix airpdcap debugging code.,
Wireshark code review
- [Wireshark-commits] master 8bd80e0: CMake: Set WIRESHARK_TARGET_PLATFORM.,
Wireshark code review
- [Wireshark-commits] master e54b5f0: CMake: Copy admonition graphics to the correct directory.,
Wireshark code review
- [Wireshark-commits] master 3a9869d: Remove/replace ep_strsplit(),
Wireshark code review
- [Wireshark-commits] master 5fe1f66: Finish off emem_strbuf_t usage.,
Wireshark code review
- [Wireshark-commits] master c93d0ab: IS-IS: Incorrect decoding of IPv4 Interface/Neighbor Address sub-TLVs in Extended IS Reachability TLV,
Wireshark code review
- [Wireshark-commits] master-1.12 1d19433: IS-IS: Incorrect decoding of IPv4 Interface/Neighbor Address sub-TLVs in Extended IS Reachability TLV,
Wireshark code review
- [Wireshark-commits] master 7177ced: USB: Fix Conversation/Endpoint filters,
Wireshark code review
- [Wireshark-commits] master c69b2ab: Bluetooth: ATT: Dissect opcode with more precision,
Wireshark code review
- [Wireshark-commits] master d6e0409: Bluetooth: Add HCI Vendor Broadcom dissector,
Wireshark code review
- [Wireshark-commits] master 55df238: Bluetooth: SMP: Add missing opcode for "Identity Address Information",
Wireshark code review
- [Wireshark-commits] master f343710: Bluetooth: HCI: Detect Vendor by "Read Local Version Information",
Wireshark code review
- [Wireshark-commits] master 1a30c97: Bluetooth: A2DP: APT-X: Unhardcode stream configuration,
Wireshark code review
- [Wireshark-commits] master 0f6b09d: to_str (epan): fix parameter 'scope' not found in the function declaration [-Wdocumentation],
Wireshark code review
- [Wireshark-commits] master 6780519: NLM: fix Copy-paste error (CID 11158588),
Wireshark code review
- [Wireshark-commits] master e2fa5a5: CTDB: fix Copy-paste error (CID 11158596),
Wireshark code review
- [Wireshark-commits] master 15ac6eb: ISMACRYP: fix Copy-paste error (CID 11158602),
Wireshark code review
- [Wireshark-commits] master 7600ddb: UTS: fix Copy-paste error (CID 11158603),
Wireshark code review
- [Wireshark-commits] master b760da9: MQ: ensure that at least 4 bytes were captured before doing heuristic checks,
Wireshark code review
- [Wireshark-commits] master 51acf16: packet-mq: sort some value_string_ext in dissector,
Wireshark code review
- [Wireshark-commits] master 531a9f0: Squelch a compiler warning.,
Wireshark code review
- [Wireshark-commits] master 02fb290: Sort the value_string_exts at dissector registration time.,
Wireshark code review
- [Wireshark-commits] master effc826: Add preference to display spaces between bytes for FT_BYTES fields.,
Wireshark code review
- [Wireshark-commits] master 59c1e32: Add BASE_SPACE for FT_BYTES,
Wireshark code review
- [Wireshark-commits] master 14cad60: Remove ep_ allocated memory from get_conversation_filter and just return a g_alloced string.,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 7f8e46c: WCCP: initialize address table to 0,
Wireshark code review
- [Wireshark-commits] master 2219f78: Netflow: do transport resolution on ports (if know they are UDP or TCP),
Wireshark code review
- [Wireshark-commits] master b2f03cb: make-version.pl updates.,
Wireshark code review
- [Wireshark-commits] master b4f5b6e: Update CMake "Project names" and Folders,
Wireshark code review
- [Wireshark-commits] master fdd6554: Rename the FT_BYTES separator types to SEP_ from BASE_.,
Wireshark code review
- [Wireshark-commits] master f5c4d06: Replace some "low hanging fruit" uses of emem.,
Wireshark code review
- [Wireshark-commits] master d07364d: Restore #undef HAVE_STDLIB_H and #undef HAVE_STRING_H in kerberos dissector.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master aa9376e: LTE RRC: upgrade dissector to v12.4.0,
Wireshark code review
- [Wireshark-commits] master f2bedeb: FDDI: fix a memory corruption introduced in gecaa1f8,
Wireshark code review
- [Wireshark-commits] master 9d55a0b: [Automatic manuf, services and enterprise-numbers update for 2015-01-11],
Wireshark code review
- [Wireshark-commits] master-1.12 c46e305: [Automatic manuf, services and enterprise-numbers update for 2015-01-11],
Wireshark code review
- [Wireshark-commits] master-1.10 5e57b07: [Automatic manuf, services and enterprise-numbers update for 2015-01-11],
Wireshark code review
- [Wireshark-commits] master 9b9a06c: packet-mq: Avoid using sort in dissector,
Wireshark code review
- [Wireshark-commits] master ae2888a: CMake: Try to fix Cygwin a2x discovery.,
Wireshark code review
- [Wireshark-commits] master 74b20dc: gtk: fix crash on Broadway GDK backend,
Wireshark code review
- [Wireshark-commits] master 5855dd8: Lemon: Update lemon tools,
Wireshark code review
- [Wireshark-commits] master-1.12 1ffee38: ieee80211: initialize bssid for data frames,
Wireshark code review
- [Wireshark-commits] master c8c9917: Fix some more regressions introduced in gecaa1f8,
Wireshark code review
- [Wireshark-commits] master-1.12 1d9f3db: gtk: fix crash on Broadway GDK backend,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 43c3fe6: gtk: fix crash on Broadway GDK backend,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.6 x86,
buildbot-no-reply
- [Wireshark-commits] master 7d004dc: Revert "Lemon: Update lemon tools",
Wireshark code review
- [Wireshark-commits] master 528a857: Fix CMake generation and use of Windows .rc files,
Wireshark code review
- [Wireshark-commits] master 4a0ec75: Use the GTK+ 2 name for VoidSymbol.,
Wireshark code review
- [Wireshark-commits] master-1.12 8963e36: Use the GTK+ 2 name for VoidSymbol.,
Wireshark code review
- [Wireshark-commits] master ca17499: Add DJI UAV Drone Control Protocol to the list of new protocols.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test,
buildbot-no-reply
- [Wireshark-commits] master 706c625: ISIS: Add code and length for SubTLV Extended IS Reachability,
Wireshark code review
- [Wireshark-commits] master e974a6f: msg_rng_rsp (Wimax): fix Copy-paste error (CID 11158604),
Wireshark code review
- [Wireshark-commits] master 2619edd: [E212] Make it possible to use different filters for MCC and MNC in LAI RAI and SAI.,
Wireshark code review
- [Wireshark-commits] master a49e1d5: Make running the tests a little easier on Windows,
Wireshark code review
- [Wireshark-commits] master 0385d15: Fix Cygwin path in runa2x.sh,
Wireshark code review
- [Wireshark-commits] master d7bce33: Fix Cygwin path,
Wireshark code review
- [Wireshark-commits] master 554a397: [GPRS CDR] Add expert info for unknown record types.,
Wireshark code review
- [Wireshark-commits] master 7967ef9: Remove emem APIs from UAT functionality.,
Wireshark code review
- [Wireshark-commits] master f699f61: Error out if the user requests the SBC library but it's not found.,
Wireshark code review
- [Wireshark-commits] master 0b271aa: Remove ep_strbuf code,
Wireshark code review
- [Wireshark-commits] master de5e7b8: Fix casting compiler warning,
Wireshark code review
- [Wireshark-commits] master 63d8e44: Fix ASCIIDOC detection broken by commit ae2888aeb2b418c9f62,
Wireshark code review
- [Wireshark-commits] master b204ff4: Do bounds checking when decompressing WCP packets.,
Wireshark code review
- [Wireshark-commits] master-1.12 c59e0a8: Do bounds checking when decompressing WCP packets.,
Wireshark code review
- [Wireshark-commits] master-1.10 abebbb9: Do bounds checking when decompressing WCP packets.,
Wireshark code review
- [Wireshark-commits] master f90eeb1: When allocating address structures, use wmem_new0().,
Wireshark code review
- [Wireshark-commits] master-1.10 08b94f2: pntoh16() was still called pntohs() in 1.10.,
Wireshark code review
- [Wireshark-commits] master db7f25f: [GPRS CDR] Handle Rel 7 CDRs,
Wireshark code review
- [Wireshark-commits] master 42e4040: [GPRS CDR]Fix faulty ASN1 modification Should be: egsnPDPRecord [70] EGSNPDPRecordV750,
Wireshark code review
- [Wireshark-commits] master a988253: CMake: Copy libwireshark dependent DLLs to the target directory.,
Wireshark code review
- [Wireshark-commits] master bc23f79: UAT error string pointers should not be const pointers.,
Wireshark code review
- [Wireshark-commits] master 25f010b: MAC LTE: upgrade dissector to v12.4.0,
Wireshark code review
- [Wireshark-commits] master 9f5e4fb: uat_load() and uat_save() return a success indication; use it.,
Wireshark code review
- [Wireshark-commits] master 63a3d04: Consistently use the "g_string_free returns a C string pointer" idiom.,
Wireshark code review
- [Wireshark-commits] master 0ee179c: HTTP: allocate header_name in packet scope instead of file scope,
Wireshark code review
- [Wireshark-commits] master 36aca29: Minor Development Guide updates,
Wireshark code review
- [Wireshark-commits] master 20e2c05: [E212]Modify dissect_e212_mcc_mnc() to take E212 number type as an argument. While at it remove deprecated APIs,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 acd589f: dec-dnart: use pinfo-scoped memory for addresses,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 1bc3b8a: dec-dnart: use pinfo-scoped memory for addresses,
Wireshark code review
- [Wireshark-commits] master 86fde78: CMake: Copy wireshark-gtk dependent DLLs to the target directory.,
Wireshark code review
- [Wireshark-commits] master 5b8fa72: CMake: Copy Qt DLLs to the target directory.,
Wireshark code review
- [Wireshark-commits] master 242f711: CMake: Update windeployqt discovery.,
Wireshark code review
- [Wireshark-commits] master 9a19d6d: CMake: Look for FOP and HHC only when needed.,
Wireshark code review
- [Wireshark-commits] master d443db0: Fix indentation.,
Wireshark code review
- [Wireshark-commits] master b63a942: Fix a crash in the GTK+ RTP Streams dialog.,
Wireshark code review
- [Wireshark-commits] master 6f630c1: Fix the compile: Use the new (double) variable.,
Wireshark code review
- [Wireshark-commits] master d9ec8ab: mate_util: fix parameter ... not found in the function declaration [-Wdocumentation],
Wireshark code review
- [Wireshark-commits] master f6021e8: CAPWAP: Add a new Message Element Type (RFC5415),
Wireshark code review
- [Wireshark-commits] master cb1f8a3: CAPWAP: Add some IEE802.11 Message Element Type (RFC5416),
Wireshark code review
- [Wireshark-commits] master fcd2d4f: Fix cmake-cflags,
Wireshark code review
- [Wireshark-commits] master 06ddb7e: CAPWAP: Add a IEE802.11 Message Element Type (RFC5416),
Wireshark code review
- [Wireshark-commits] master 5b92ab9: RSVP: Add support of GMPLS Support for Metro Ethernet Forum and G.8011 (RFC 6004),
Wireshark code review
- [Wireshark-commits] master adaa661: Update to libnghttp2 0.7.1,
Wireshark code review
- [Wireshark-commits] master 0d9248e: Netflow: Fix spelling of 'latitude',
Wireshark code review
- [Wireshark-commits] master c2350a5: rsvp: fix typo,
Wireshark code review
- [Wireshark-commits] master ef0435b: ZigBee: don't use packet_scope outside of dissection,
Wireshark code review
- [Wireshark-commits] master 1e1d96f: Modify the errorcode defenition to suit ANSI MAP, this is (probably) OK as ANSI MAP is currently the only user of ANSI TCAP. Bug: 6112,
Wireshark code review
- [Wireshark-commits] master ba7aa19: start a dissector for ZVT Kassenschnittstelle,
Wireshark code review
- [Wireshark-commits] master a1fce22: remove the executable bits from packet-zvt.c,
Wireshark code review
- [Wireshark-commits] master 58bb07b: Fix-copy-qt-dll,
Wireshark code review
- [Wireshark-commits] master e0539ed: CMake: Rename the windeployqt variable.,
Wireshark code review
- [Wireshark-commits] master 69d32a9: HTTP Dissector: Add CitrixAGBasic authentication,
Wireshark code review
- [Wireshark-commits] master 9c044e2: ZigBee: packet scope memory cannot be used for BASE_CUSTOM callbacks,
Wireshark code review
- [Wireshark-commits] master adf0881: HTTP: fix implicit conversion shortens 64-bit value into a 32-bit value,
Wireshark code review
- [Wireshark-commits] master 3385984: Address to str: Missing break in switch (CID 1262416 & 1262417),
Wireshark code review
- [Wireshark-commits] master 1562827: Packet List (Qt): Missing break in switch (CID 1262418),
Wireshark code review
- [Wireshark-commits] master e75dd98: NetFlow: Assign instead of compare (CID 1262419 & 1262420),
Wireshark code review
- [Wireshark-commits] master c610c38: Conversation Table : Copy-paste error (CID 1262415),
Wireshark code review
- [Wireshark-commits] master d5ee022: Replace C++ style comment with C style.,
Wireshark code review
- [Wireshark-commits] master 7d43836: QT: stats_tree plug-ins not added to statistics menu,
Wireshark code review
- [Wireshark-commits] master e530c89: Replace se alloced memory in compare stat tap.,
Wireshark code review
- [Wireshark-commits] master 3f8fbb7: Remove the last two true calls to se_alloc.,
Wireshark code review
- [Wireshark-commits] master d009b55: Quakeworld: Nesting level does not match indendation (CID 1159218),
Wireshark code review
- [Wireshark-commits] master a4d1709: (Trivial) Move a comment next to the code related to it.,
Wireshark code review
- [Wireshark-commits] master b2c4586: bug 10833 undecoded bitmaps were being displayed raw which is hard to interpret, changed to an more friendly format,
Wireshark code review
- [Wireshark-commits] master 260b19e: Remove seasonal memory from everything except address resolutions,
Wireshark code review
- [Wireshark-commits] master ada1eec: SE_COPY_ADDRESS -> WMEM_COPY_ADDRESS,
Wireshark code review
- [Wireshark-commits] master 0235775: GSM SIM: enhance dissection of APDU Class byte,
Wireshark code review
- [Wireshark-commits] master 531df02: Remove se_ alloced memory from packet_list_store,
Wireshark code review
- [Wireshark-commits] master 16d367f: ZBee ZCL: use tvb_get_guint8() (avoid tvb_get_ptr... !),
Wireshark code review
- [Wireshark-commits] master 4fa7396: CMakeList.txt/Makefile.am (root) : fix indent (use tabs),
Wireshark code review
- [Wireshark-commits] master 3f57512: Kill more unused emem functions,
Wireshark code review
- [Wireshark-commits] master 22543d3: IS-IS: wrong length for SubTLV 18 (TE default Metric),
Wireshark code review
- [Wireshark-commits] master b6ec25f: IS-IS: Add missing i variable for subclv loop (IS Reachability),
Wireshark code review
- [Wireshark-commits] master 23666ba: Spaces separate bytes; they don't have to surround them.,
Wireshark code review
- [Wireshark-commits] master fa54781: Update comment to reflect the current reality.,
Wireshark code review
- [Wireshark-commits] master 1e8c6ee: Update a comment,
Wireshark code review
- [Wireshark-commits] master 3f284fb: USB: do not put usb_address_t structure on stack and initialize it completely (including implicit padding for alignment),
Wireshark code review
- [Wireshark-commits] master 62ea319: PacketLogger files can be big-endian or little-endian.,
Wireshark code review
- [Wireshark-commits] master-1.12 a980bcc: PacketLogger files can be big-endian or little-endian.,
Wireshark code review
- [Wireshark-commits] master-1.10 2adb9b5: PacketLogger files can be big-endian or little-endian.,
Wireshark code review
- [Wireshark-commits] master aa1057d: EAPOL-MKA: Included fixes for the distributed sak handling.,
Wireshark code review
- [Wireshark-commits] master a38b714: RSYNC: Malformed Packet on rsync-version with length 2,
Wireshark code review
- [Wireshark-commits] master-1.12 0812523: RSYNC: Malformed Packet on rsync-version with length 2,
Wireshark code review
- [Wireshark-commits] master 21e40ea: dissect the serial characters and the CRC,
Wireshark code review
- [Wireshark-commits] master 8ec6ac6: dissect CCRC, APRC and the APDU body's data,
Wireshark code review
- [Wireshark-commits] master-1.12 f80b3b0: IS-IS: wrong length for SubTLV 18 (TE default Metric),
Wireshark code review
- [Wireshark-commits] master ffa8bdd: Correct PF field offset when looking for DA,
Wireshark code review
- [Wireshark-commits] master-1.12 b10f4da: Correct PF field offset when looking for DA,
Wireshark code review
- [Wireshark-commits] master 6010d99: Added Card Application Toolkit Transport Protocol (CATTP) dissector,
Wireshark code review
- [Wireshark-commits] master 5c5b3f7: Convert proto_construct_match_selected_string to use wmem.,
Wireshark code review
- [Wireshark-commits] master 77dac91: A few more emem replacements with wmem.,
Wireshark code review
- [Wireshark-commits] master 506409d: X509AF: dissect Certificate Serial Number as INT64 instead of INT32,
Wireshark code review
- [Wireshark-commits] master-1.12 478581a: X509AF: dissect Certificate Serial Number as INT64 instead of INT32,
Wireshark code review
- [Wireshark-commits] master-1.10 092ccf4: X509AF: dissect Certificate Serial Number as INT64 instead of INT32,
Wireshark code review
- [Wireshark-commits] master be113e8: DHCP/BOOTP: Option 125 Suboption: (1) option-len always expects 1 but specification allows for more,
Wireshark code review
- [Wireshark-commits] master b5eb971: Replace all remaining instances of ep_new with wmem_new and wmem_packet_scope.,
Wireshark code review
- [Wireshark-commits] master 0ad15f8: Replace the last of ep_alloc and ep_alloc0 with wmem equivalent.,
Wireshark code review
- [Wireshark-commits] master 86726f4: Trim down the use of ep_ memory in the display filter code.,
Wireshark code review
- [Wireshark-commits] master 403be72: Remove emem from GeoIP,
Wireshark code review
- [Wireshark-commits] master ef7e8aa: Remove ep_strndup,
Wireshark code review
- [Wireshark-commits] master a1f2342: Miscellaneous ep_strdup_printf replacement.,
Wireshark code review
- [Wireshark-commits] master-1.12 b3abc55: DHCP/BOOTP: Option 125 Suboption: (1) option-len always expects 1 but specification allows for more,
Wireshark code review
- [Wireshark-commits] master-1.10 878c4b7: DHCP/BOOTP: Option 125 Suboption: (1) option-len always expects 1 but specification allows for more,
Wireshark code review
- [Wireshark-commits] master c60fb30: Try to make Mac OS X Buildbots happy,
Wireshark code review
- [Wireshark-commits] master cfcbb28: Clean up ftype-conversion and dfilter error message string handling.,
Wireshark code review
- [Wireshark-commits] master c7500dd: Fix another dfilter_compile() call.,
Wireshark code review
- [Wireshark-commits] master ebea11a: We need epan/wmem/wmem.h regardless of whether we have GeoIP.,
Wireshark code review
- [Wireshark-commits] master 13b1e90: ASN.1: regenerate dissectors after g506409d,
Wireshark code review
- [Wireshark-commits] master c326fca: LDAP: g8c608e6 did not include the changes in template file, that got lost afterwards,
Wireshark code review
- [Wireshark-commits] master-1.12 f68f892: LDAP: g8c608e6 did not include the changes in template file, that got lost afterwards,
Wireshark code review
- [Wireshark-commits] master-1.12 3426a1e: ASN.1: regenerate dissectors after g478581a,
Wireshark code review
- [Wireshark-commits] master-1.10 1e94413: ASN.1: regenerate dissectors after g092ccf4,
Wireshark code review
- [Wireshark-commits] master 12d17d2: Update libwireshark0.symbols,
Wireshark code review
- [Wireshark-commits] master e7593ea: asn2wrs: autodetect if 64 bits variant is required for constrained integers,
Wireshark code review
- [Wireshark-commits] master c922801: ftype (integer): fix Uninitialized argument value found by Clang Analyzer,
Wireshark code review
- [Wireshark-commits] master-1.12 438c55d: Fix Lua dll for Visual Studio 2013,
Wireshark code review
- [Wireshark-commits] master-1.12 8c2f2b2: Novell PKIS: handle 64 bits contraint,
Wireshark code review
- [Wireshark-commits] master 2660806: no need for if(tree),
Wireshark code review
- [Wireshark-commits] master b01ef11: HTTP: revert a change done in g0ee179c,
Wireshark code review
- [Wireshark-commits] master 0d92b99: ISUP: add dissection of generic number qualifier indicator,
Wireshark code review
- [Wireshark-commits] master 2441a23: [Automatic manuf, services and enterprise-numbers update for 2015-01-18],
Wireshark code review
- [Wireshark-commits] master-1.12 539b6b4: [Automatic manuf, services and enterprise-numbers update for 2015-01-18],
Wireshark code review
- [Wireshark-commits] master-1.10 78a39b6: [Automatic manuf, services and enterprise-numbers update for 2015-01-18],
Wireshark code review
- [Wireshark-commits] master 9ba910f: remove redundant (and unused) paramter usb_trans_info,
Wireshark code review
- [Wireshark-commits] master 4399319: clean up the functions that dissect the hid requests,
Wireshark code review
- [Wireshark-commits] master 1722d2a: remove trans_info parameter from dissect_usb_hid_report_item(),
Wireshark code review
- [Wireshark-commits] master 90fc37e: make things a bit easier to read...,
Wireshark code review
- [Wireshark-commits] master 71c21a6: Remove seasonal memory from address resolution.,
Wireshark code review
- [Wireshark-commits] master 233dc64: Remove some apparently-unnecessary includes of emem.h.,
Wireshark code review
- [Wireshark-commits] master e601e01: Remove some apparently-unnecessary includes of emem.h.,
Wireshark code review
- [Wireshark-commits] master 24954d6: proto.c: Update some comments to reflect reality,
Wireshark code review
- [Wireshark-commits] master 7abb103: CMake: Copy data files to the run directory.,
Wireshark code review
- [Wireshark-commits] master 44e7ce5: Remove some apparently-unnecessary includes of emem.h.,
Wireshark code review
- [Wireshark-commits] master 212eb17: replace DISSECTOR_ASSERT ep strings with wmem,
Wireshark code review
- [Wireshark-commits] master 929d41c: Replace the last THROW ep_ calls with wmem,
Wireshark code review
- [Wireshark-commits] master 050bc7d: Update some comments to reflect reality.,
Wireshark code review
- [Wireshark-commits] master d2d4cf2: Remove a couple more apparently-no-longer-necessary emem.h includes.,
Wireshark code review
- [Wireshark-commits] master 7940bbc: Nobody uses se_ allocations, so remove the code for them.,
Wireshark code review
- [Wireshark-commits] master 820c795: This file currently does need emem.h.,
Wireshark code review
- [Wireshark-commits] master 5970223: Put back ep_alloc0(), accidentally deleted in the removal of the se_ stuff.,
Wireshark code review
- [Wireshark-commits] master ae92cd4: [Qt] Run windeployqt for Qt versions greater than 5.2,
Wireshark code review
- [Wireshark-commits] master 4cea624: This currently requires emem.h.,
Wireshark code review
- [Wireshark-commits] master b2b640f: Reflect the disappearance of the seasonal allocator.,
Wireshark code review
- [Wireshark-commits] master 5162b7f: smpp: Prevent crash if invalid date/time field.,
Wireshark code review
- [Wireshark-commits] master 59155d1: Eliminate ep_strdup(), as it's no longer used.,
Wireshark code review
- [Wireshark-commits] master-1.12 b48ec0b: smpp: Prevent crash if invalid date/time field.,
Wireshark code review
- [Wireshark-commits] master e333e4c: Convert OID APIs to use wmem.,
Wireshark code review
- [Wireshark-commits] master 199cb06: RTP: Parse problem in dissect_rtp_hext_rfc5215_onebyte,
Wireshark code review
- [Wireshark-commits] master c4297e6: Skinny: packet-skinny.c Changes: Number of small changes to the xml file: - some fields being connected to the wrong message version - some header field naming,
Wireshark code review
- [Wireshark-commits] master 119416e: TCAP: support dialogue confirmation,
Wireshark code review
- [Wireshark-commits] master f53be88: JSON dissector changed into heuristic dissector.,
Wireshark code review
- [Wireshark-commits] master f90a10a: epl: Rework POWERLINK (EPL) dissector,
Wireshark code review
- [Wireshark-commits] master 48e90da: Fix make dist on Ubuntu buildbot,
Wireshark code review
- [Wireshark-commits] master 1b5a965: JSMN : fix typo (it will be fix make distcheck),
Wireshark code review
- [Wireshark-commits] master c8bca4f: Updated company name from Nokia Siemens Networks to Nokia Solutions and Networks.,
Wireshark code review
- [Wireshark-commits] master de4164f: On my system NSIS installs in the path defined in environment variable ProgramFiles(x86)=C:\Program Files (x86) Add that to the locations where we look for it. I couldn't use ProgramFiles(x86) as a constant so put the path verbatim.,
Wireshark code review
- [Wireshark-commits] master c0fd539: ZigBee: fix dissection of epoch time in OTA cluster,
Wireshark code review
- [Wireshark-commits] master-1.12 9cfc359: ZigBee: fix dissection of epoch time in OTA cluster,
Wireshark code review
- [Wireshark-commits] master ab8a13d: Don't mix declarations and code - it's not legal C90.,
Wireshark code review
- [Wireshark-commits] master 9fd5078: BGP: fix field bgp.evpn.nlri.mpls_ls is not of type FT_STRING, FT_STRINGZ, or FT_STRINGZPAD,
Wireshark code review
- [Wireshark-commits] master b41065e: BGP: EVPN - Route Type 4 - "Invalid length of IP Address" - "Expert Info" shows a false error,
Wireshark code review
- [Wireshark-commits] master-1.12 c1312d3: BGP: EVPN - Route Type 4 - "Invalid length of IP Address" - "Expert Info" shows a false error,
Wireshark code review
- [Wireshark-commits] master d1cace9: smb-pipe: prevent possible crash; gmtime() can return NULL.,
Wireshark code review
- [Wireshark-commits] master 7e1d73d: dmp, gmhdr, vssmonitoring: prevent possible crashes;,
Wireshark code review
- [Wireshark-commits] master 7a81add: synphasor: prevent possible crash; gmtime() can return NULL;,
Wireshark code review
- [Wireshark-commits] master 5fa13c6: README.dissector: Minor update re date/time display.,
Wireshark code review
- [Wireshark-commits] master 0dcb91d: synphasor: (trivial) Do dissector_add_uint("rtacser.data", ...) only once,
Wireshark code review
- [Wireshark-commits] master-1.12 fcc7db9: smb-pipe: prevent possible crash; gmtime() can return NULL.,
Wireshark code review
- [Wireshark-commits] master-1.12 79e5284: dmp, gmhdr, vssmonitoring: prevent possible crashes;,
Wireshark code review
- [Wireshark-commits] master 71d83aa: tvb_length() -> tvb_captured_length(),
Wireshark code review
- [Wireshark-commits] master c846af1: continue the dissection of ZVT APDUs,
Wireshark code review
- [Wireshark-commits] master 4fc8286: display the control field text in the info col,
Wireshark code review
- [Wireshark-commits] master 6c02abf: start dissecting the ZVT authentication apdu,
Wireshark code review
- [Wireshark-commits] master 58d9ca8: add some more apdus to the apdu table,
Wireshark code review
- [Wireshark-commits] master-1.12 4946e93: synphasor: prevent possible crash; gmtime() can return NULL;,
Wireshark code review
- [Wireshark-commits] master bea25fa: The times in question are local, not UTC.,
Wireshark code review
- [Wireshark-commits] master 7c69079: CMake: Add a pdb_zip_package target.,
Wireshark code review
- [Wireshark-commits] master c3ad53f: Fix one item.,
Wireshark code review
- [Wireshark-commits] master f16e8fb: pdb_zip_package: Enable multithreaded compression.,
Wireshark code review
- [Wireshark-commits] master 8c15ac4: Possibility -> certainty.,
Wireshark code review
- [Wireshark-commits] master-1.12 597e00b: The times in question are local, not UTC.,
Wireshark code review
- [Wireshark-commits] master 11e557a: ISIS: Making a segregated function for sub-tlv used by multiple tlv,
Wireshark code review
- [Wireshark-commits] master 1af7b97: Bug fix in json dissector that made the heuristic fail.,
Wireshark code review
- [Wireshark-commits] master f3cbee6: NCP2222: fix possible buffer-overflow,
Wireshark code review
- [Wireshark-commits] master b2e172a: DHCP/BOOTP: Option 125 Suboption: (5) fix display Modem Capabilities,
Wireshark code review
- [Wireshark-commits] master af3924a: HTTP2: Add HPACK decode to test suite,
Wireshark code review
- [Wireshark-commits] master 6e6a129: CMake: Set an output directory for plugins.,
Wireshark code review
- [Wireshark-commits] master 5268d7f: cattp: Minor tweaks and whitespace changes,
Wireshark code review
- [Wireshark-commits] master f63628d: CMake: Use wrapper scripts instead of symlinks.,
Wireshark code review
- [Wireshark-commits] master c0a403a: 6lowpan: Fix a few minor bugs; Also: Misc,
Wireshark code review
- [Wireshark-commits] master 2c312b6: acn: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master eefd529: bpdu: Fix minor bug introduced in g188aa9a,
Wireshark code review
- [Wireshark-commits] master 0169cc8: Remove some dead initializers,
Wireshark code review
- [Wireshark-commits] master-1.12 4d01423: acn: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.10 627a0cc: acn: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 74ed8b5: Add DNS stats to release-notes,
Wireshark code review
- [Wireshark-commits] master 160af3c: HTTP2: fix test failure on Solaris SPARC,
Wireshark code review
- [Wireshark-commits] master d2d699a: Move all SigComp functionality to the SigComp dissector.,
Wireshark code review
- [Wireshark-commits] master 5f70fd6: dsi: fix a trivial bug,
Wireshark code review
- [Wireshark-commits] master f215102: Handle CFLAGS disabling SSE 4.2.,
Wireshark code review
- [Wireshark-commits] master bf23953: Only turn -msse4.2 on for ws_mempbrk_sse42.c, and don't always build it.,
Wireshark code review
- [Wireshark-commits] master 64f4287: Get rid of trailing blank.,
Wireshark code review
- [Wireshark-commits] master 8051657: Modernize the description of Wireshark given in the RPM info.,
Wireshark code review
- [Wireshark-commits] master 8a0bd92: Check whether we can use nmmintrin.h.,
Wireshark code review
- [Wireshark-commits] master 41cbbc2: Don't set SSE4_2_FLAG to -msse4.2 unless -msse4.2 works.,
Wireshark code review
- [Wireshark-commits] master db6f733: Always set the COMPILE_FLAGS property, so we can always fetch it.,
Wireshark code review
- [Wireshark-commits] master bc86257: Also support -xarch=sse_42 in the Sun C compiler for x86(-64).,
Wireshark code review
- [Wireshark-commits] master 46fabdc: Make the license tag in the RPM more specific: Wireshark is GPLv2+.,
Wireshark code review
- [Wireshark-commits] master ed413e9: Link only the GUIs with SBC (if we have SBC). The other programs don't (yet) use libcodec.,
Wireshark code review
- [Wireshark-commits] master 2ee0ea0: IEEE 802.15.4: fix display of 64 bits address (broken in gecaa1f8),
Wireshark code review
- [Wireshark-commits] master 6c728d5: Support Sun^WOracle C's -xldscope=hidden for hiding externals.,
Wireshark code review
- [Wireshark-commits] master 17a1748: Updated NSN dictionary with vendor-specific Sy application AVPs.,
Wireshark code review
- [Wireshark-commits] master 163071e: GSM SIM: for a FETCH command, a Le of 0 means 256 bytes,
Wireshark code review
- [Wireshark-commits] master fb1e149: NSIS: Simplify wireshark.nsi.,
Wireshark code review
- [Wireshark-commits] master e1f4f53: HPFEEDS: cleanup in the dissector code.,
Wireshark code review
- [Wireshark-commits] master 3dc1b4e: ieee802154: (trivial) proto_item_set_len() takes a 'proto_item *',
Wireshark code review
- [Wireshark-commits] master 009ca9f: srvloc: fix a very minor bug,
Wireshark code review
- [Wireshark-commits] master 32ab59f: synphasor: General cleanup,
Wireshark code review
- [Wireshark-commits] master 0671965: usb-hid: fix 2 minor bugs and some dead initializers,
Wireshark code review
- [Wireshark-commits] master b0f37ba: vcdu: minor cleanup,
Wireshark code review
- [Wireshark-commits] master bc5c484: Remove some dead initializers,
Wireshark code review
- [Wireshark-commits] master-1.12 5c14a18: usb-hid: fix aminor bug,
Wireshark code review
- [Wireshark-commits] master-1.12 bb582d7: synphasor: col_...() shouldn't be under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master f7d9334: isakmp: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 20e59f8: isakmp: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 16f2147: Pull the install and uninstall sequences into functions.,
Wireshark code review
- [Wireshark-commits] master 33c1858: Pull the installs into a function.,
Wireshark code review
- [Wireshark-commits] master d93a90b: Make the individual install_ and uninstall_ functions idempotent.,
Wireshark code review
- [Wireshark-commits] master 0426236: Get us building with the subdir-objects automake option.,
Wireshark code review
- [Wireshark-commits] master 64108f4: Give PortAudio a versioned -done file.,
Wireshark code review
- [Wireshark-commits] master b7db12e: Do tests in the order the comment before them implies.,
Wireshark code review
- [Wireshark-commits] master 0fbb25f: Rename install_libpixman to install_pixman, to match uninstall_pixman.,
Wireshark code review
- [Wireshark-commits] master 2cc9474: When uninstalling a library, first uninstall what depends on it.,
Wireshark code review
- [Wireshark-commits] master 5a928c2: Remove autotools packages if something they depend on changes.,
Wireshark code review
- [Wireshark-commits] master 2cd0472: Un-install and re-install if the installed and specified versions differ.,
Wireshark code review
- [Wireshark-commits] master dadf2c1: Lua 5.3.0 is now out; install it. (It has better 64-bit integer support.),
Wireshark code review
- [Wireshark-commits] master f8fa70f: Decoding of Asterix categories 063 and 065 extended to item decoding.,
Wireshark code review
- [Wireshark-commits] master 39a984e: GTP: Bad bytes read for extended rnc id value,
Wireshark code review
- [Wireshark-commits] master 87e691f: Remove a mysterious comment that no longer applies.,
Wireshark code review
- [Wireshark-commits] master 749c68c: packet-dcerpc: change transportsalt to guint64,
Wireshark code review
- [Wireshark-commits] master-1.12 d7efcc1: GTP: Bad bytes read for extended rnc id value,
Wireshark code review
- [Wireshark-commits] master 97d0f36: packet-smb2: correctly dissect dcerpc traffic over different named pipe handles,
Wireshark code review
- [Wireshark-commits] master 48c90d1: packet-smb2: fix getting the dataoffset in dissect_smb2_write_request(),
Wireshark code review
- [Wireshark-commits] master f38a63a: packet-smb2: implement SMB2 NegotiateContexts,
Wireshark code review
- [Wireshark-commits] master 96f9746: pppoe: col_...()/expert...() shouldn't be under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 8d74f10: pppoe: col_...()/expert...() shouldn't be under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 5b55288: Add a changelog entry for the license tag change (I82de1bc4ffcb1e962b1a35dc58aaa87aca04ed5e).,
Wireshark code review
- [Wireshark-commits] master 612e286: Fix test script to test Lua Pinfo, and fix problem it found.,
Wireshark code review
- [Wireshark-commits] master 2eaa467: oids: fix memory leak,
Wireshark code review
- [Wireshark-commits] master-1.12 007df12: Fix test script to test Lua Pinfo.,
Wireshark code review
- [Wireshark-commits] master-1.12 4acb150: Get rid of an unused variable.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master 19a8eaf: Use luaL_{check, opt}integer() rather than luaL_{check, opt}int().,
Wireshark code review
- [Wireshark-commits] master 5a23a02: Add .dirstamp - it's apparently some autotools thing.,
Wireshark code review
- [Wireshark-commits] master 8d1a984: Remove incorrect 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 407b703: Fix some WsLua documentation errors,
Wireshark code review
- [Wireshark-commits] master 888229b: Make netlink dissector register the attribute length header field info,
Wireshark code review
- [Wireshark-commits] master e990d1b: Try to fix the jaggy taskbar icon.,
Wireshark code review
- [Wireshark-commits] master bab7447: CAPWAP: Add support of Fortinet Vendor Specific Element,
Wireshark code review
- [Wireshark-commits] master f5c0bd2: 802.11: Fix encoding for VHT NDP STA Info,
Wireshark code review
- [Wireshark-commits] master b32e39e: Test suite: Add verbosity to the HTTP2 test.,
Wireshark code review
- [Wireshark-commits] master cce3ad2: Correctly dissect the AMQP 0-9 heartbeat frames. The heartbeat frames were incorrectly highlighted as erroneous.,
Wireshark code review
- [Wireshark-commits] master d8d2d8e: jpeg: Add handling for comment marker,
Wireshark code review
- [Wireshark-commits] master-1.12 b747dfc: Remove incorrect 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 21dfda6: Qt: Remove windowIcon property from our .ui files.,
Wireshark code review
- [Wireshark-commits] master b714da2: CMake: Make sure DATAFILE_DIR exists.,
Wireshark code review
- [Wireshark-commits] master 7ed097c: Fix an uninitialized variable warning.,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 2fbc60f: When deccoding base-64, the result is the length of the *decoded* result.,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 0abe88b: Always set decrypt_len when setting decrypt.,
Wireshark code review
- [Wireshark-commits] master cf142c6: Get Wireshark to compile with afl-gcc.,
Wireshark code review
- [Wireshark-commits] master b2a5f15: RTPS: Memset entire buffer,
Wireshark code review
- [Wireshark-commits] master 5280188: Added HCrt (Hotline Command-Response Transaction) Dissector.,
Wireshark code review
- [Wireshark-commits] master b91df34: v52: Fix a minor bug introduced in gc71e88e; plus ...,
Wireshark code review
- [Wireshark-commits] master 5003654: Cleanup:,
Wireshark code review
- [Wireshark-commits] master 716f9a3: [Automatic manuf, services and enterprise-numbers update for 2015-01-25],
Wireshark code review
- [Wireshark-commits] master-1.12 40201fd: [Automatic manuf, services and enterprise-numbers update for 2015-01-25],
Wireshark code review
- [Wireshark-commits] master-1.10 d5e8c4d: [Automatic manuf, services and enterprise-numbers update for 2015-01-25],
Wireshark code review
- [Wireshark-commits] master aec1bcf: Lua can free tvbuffs too early,
Wireshark code review
- [Wireshark-commits] master 2f713a6: Update some comments to reflect reality.,
Wireshark code review
- [Wireshark-commits] master bba51b6: Get rid of unused is_release preference.,
Wireshark code review
- [Wireshark-commits] master a3f3d0b: Don't say "Git Rev" if the VCS being used isn't Git.,
Wireshark code review
- [Wireshark-commits] master c107896: Replace "GIT" with "VCS" in make-version.pl and files it manipulates.,
Wireshark code review
- [Wireshark-commits] master 065304c: applemidi: col_...() shouldn't be called under 'if(tree)',
Wireshark code review
- [Wireshark-commits] master be798e1: pana, gsm_abis_oml, rsl, netrom: Remove 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 101c1f2: applemidi: col_...() shouldn't be called under 'if(tree)',
Wireshark code review
- [Wireshark-commits] master 88e22bde: Remove some references to SVN.,
Wireshark code review
- [Wireshark-commits] master fcac03d: Update a comment to reflect reality.,
Wireshark code review
- [Wireshark-commits] master d015eff: Update another comment to reflect reality.,
Wireshark code review
- [Wireshark-commits] master 155fc8f: Move #defines of epan/greproto.h to packet-gre.h,
Wireshark code review
- [Wireshark-commits] master d465682: Roll functionality of h225-persistentdata module into packet-h225.c,
Wireshark code review
- [Wireshark-commits] master abf5703: Register EtherNet/IP dissector for "external" use (like SSL),
Wireshark code review
- [Wireshark-commits] master d50b27f: gsm-rlcmac: use wmem_new0 for a struct,
Wireshark code review
- [Wireshark-commits] master-1.12 635506b: gsm-rlcmac: use wmem_new0 for a struct,
Wireshark code review
- [Wireshark-commits] master d5f0f25: Add Cmakefiles missing from the distribution.,
Wireshark code review
- [Wireshark-commits] master-1.12 f269ffe: Lua can free tvbuffs too early,
Wireshark code review
- [Wireshark-commits] master c9579d0: 3GPP: upgrade 2G/3G NAS dissector to v12.8.0 and NAS EPS dissector to v12.7.0,
Wireshark code review
- [Wireshark-commits] master 717b5a2: rtmpt: Remove 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 5845f29: rtp: Don't call col_...() under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master a835c85: Pcapng: Don't fetch past the end of a GArray.,
Wireshark code review
- [Wireshark-commits] master-1.12 175ede4: Pcapng: Don't fetch past the end of a GArray.,
Wireshark code review
- [Wireshark-commits] master-1.10 de0eeb5: Pcapng: Don't fetch past the end of a GArray.,
Wireshark code review
- [Wireshark-commits] master ee320ef: qt: clear tree and bytes when no packet selected,
Wireshark code review
- [Wireshark-commits] master-1.12 e00fd25: pana, gsm_abis_oml, rsl, netrom: Remove 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 187e028: rtmpt: Remove 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 9c3734d: rtp: Don't call col_...() under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 4fb2ec0: SMC-R: fix incorrect dissection of non-SMCR packet. Failover Validation bit definition is missing,
Wireshark code review
- [Wireshark-commits] master c0c2b45: epl: Add Manufacturer subdissector,
Wireshark code review
- [Wireshark-commits] master 11d25fa: CATTP: fix no previous prototype for 'proto_register_cattp' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master a9aba94: GTK: fix no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master ec7ff4e: GTK: fix no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 5e309d6: CAPWAP: fix double space on AC Software version,
Wireshark code review
- [Wireshark-commits] master 77227d4: GTK: Fix multispace on main title bar,
Wireshark code review
- [Wireshark-commits] master b5a3907: Packet List (Qt): fix extra ‘;’ [-Wpedantic],
Wireshark code review
- [Wireshark-commits] master 32cbf79: Qt: Add checkable for Find Packet icon,
Wireshark code review
- [Wireshark-commits] master c80aa10: HCrt fix no previous prototype for 'proto_register_hcrt' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 9bbc337: Added HPFEEDS stats_tree.,
Wireshark code review
- [Wireshark-commits] master ceb8d95: Lua: Expose tcp_dissect_pdus() to Lua,
Wireshark code review
- [Wireshark-commits] master 7dfda88: WIMAX: fix no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 2e10308: HCrt: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 678cf27: NETROM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 75858d7: rtps: Remove various 'if(tree)',
Wireshark code review
- [Wireshark-commits] master d3261b2: Comment out various 'if(tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 461bb08: Comment out various 'if(tree)',
Wireshark code review
- [Wireshark-commits] master 9976422: Added json heuristic to Dropbox LAN sync Discovery Protocol.,
Wireshark code review
- [Wireshark-commits] master 3aab6fc: Qt: Update packet list freeze/thaw behavior.,
Wireshark code review
- [Wireshark-commits] master f090ebb: Add documentation URLs for the Linux USB and USBPCAP pseudo-headers.,
Wireshark code review
- [Wireshark-commits] master 946856a: Move tests out of try_dissect_linux_usb_pseudo_header_ext().,
Wireshark code review
- [Wireshark-commits] master 53a5e4f: win32: fix detection of Windows 10 Technical Preview,
Wireshark code review
- [Wireshark-commits] master 15c895d: Make the USB header information an enumerated type.,
Wireshark code review
- [Wireshark-commits] master d7538cb: ANSI IS-637-A: prevent an out of bounds access,
Wireshark code review
- [Wireshark-commits] master-1.12 4a680e1: ANSI IS-637-A: prevent an out of bounds access,
Wireshark code review
- [Wireshark-commits] master-1.10 8c3d9aa: ANSI IS-637-A: prevent an out of bounds access,
Wireshark code review
- [Wireshark-commits] master f011af2: Add files missing from the tarball.,
Wireshark code review
- [Wireshark-commits] master 83678a0: Proto dialog (GTK) : fix indent (use 2 spaces) and add modelines,
Wireshark code review
- [Wireshark-commits] master 6940a97: Go back to installing 5.2.3 for now.,
Wireshark code review
- [Wireshark-commits] master 9e647a9: Extended AMQP 0-9 dissector to support AMQP 0-9-1 methods and datatypes. Backward compatibility to AMQP 0-9 is maintained.,
Wireshark code review
- [Wireshark-commits] master 49a7e97: Try dissecting some stuff even if we don't have conversation information.,
Wireshark code review
- [Wireshark-commits] master 25f1df4: "%l[doux]" doesn't mean "64-bit integer".,
Wireshark code review
- [Wireshark-commits] master 0137f92: addr_resolv: correctly scope returned memory,
Wireshark code review
- [Wireshark-commits] master 9a366b0: Disable SSE4.2 _ws_mempbrk_sse42 due to bug 10798,
Wireshark code review
- [Wireshark-commits] master 0ba51cc: IS-IS: Add subTLV Bandwidth Constraints (22) used by IS Reachability,
Wireshark code review
- [Wireshark-commits] master 2edf8bb: SDP: check that media format starts with a digit before trying to identify media type,
Wireshark code review
- [Wireshark-commits] master-1.12 424a383: SDP: check that media format starts with a digit before trying to identify media type,
Wireshark code review
- [Wireshark-commits] master-1.10 b4fb43d: SDP: check that media format starts with a digit before trying to identify media type,
Wireshark code review
- [Wireshark-commits] master 67b069e: Qt: Add address conversion convenience routines,
Wireshark code review
- [Wireshark-commits] master aaa3d23: When issued with -v wireshark-qt prints version and exits.,
Wireshark code review
- [Wireshark-commits] master fd1bc6d: HCRT: udp port preference changed into range.,
Wireshark code review
- [Wireshark-commits] master 6824cee: CAPWAP: Add support of Cisco Vendor Specific Element,
Wireshark code review
- [Wireshark-commits] master 2bf7878: Qt: Add the RTP Streams dialog.,
Wireshark code review
- [Wireshark-commits] master 78755c7: Disable SSE4.2 _ws_mempbrk_sse42 only for older Apple compilers,
Wireshark code review
- [Wireshark-commits] master a614212: SDP: add ability to display port as a string,
Wireshark code review
- [Wireshark-commits] master-1.12 a358997: SDP: add ability to display port as a string,
Wireshark code review
- [Wireshark-commits] master-1.10 df6e479: SDP: add ability to display port as a string,
Wireshark code review
- [Wireshark-commits] master 14a869c: GSM MAP: display TBCD digits, USSD string and Location Number digits in a subtree,
Wireshark code review
- [Wireshark-commits] master 5e3936e: BSSGP: ensure that all Optional / Conditional Information Elements are treated as such,
Wireshark code review
- [Wireshark-commits] master-1.12 c440603: BSSGP: ensure that all Optional / Conditional Information Elements are treated as such,
Wireshark code review
- [Wireshark-commits] master-1.10 06a0cfa: BSSGP: ensure that all Optional / Conditional Information Elements are treated as such,
Wireshark code review
- [Wireshark-commits] master cc66f68: kafka: fill in some expert info,
Wireshark code review
- [Wireshark-commits] master 1ec66f0: rtps: Cleanup,
Wireshark code review
- [Wireshark-commits] master 7b929e2: rtp: cleanup,
Wireshark code review
- [Wireshark-commits] master eda485e: Cleanup:,
Wireshark code review
- [Wireshark-commits] master f61c969: NMake: Add Chocolatey paths.,
Wireshark code review
- [Wireshark-commits] master 9a3676a: Qt: Clear our library path at startup on Windows.,
Wireshark code review
- [Wireshark-commits] master e76e140: Qt: Fix library path reset.,
Wireshark code review
- [Wireshark-commits] master a984dbf: Do the first-pass argument parsing before creating the WiresharkApplication.,
Wireshark code review
- [Wireshark-commits] master ee9d0f9: This being C++, maybe we don't have to initialize ws_app until later.,
Wireshark code review
- [Wireshark-commits] master cca2cde: No main window *to* update in the early argument list parsing.,
Wireshark code review
- [Wireshark-commits] master 90233ff: We need to get the pathname of the executable *before* running dumpcap.,
Wireshark code review
- [Wireshark-commits] master 4424d6a: Fix a comment to reflect reality.,
Wireshark code review
- [Wireshark-commits] master c7717ae: Get rid of a trailing blank.,
Wireshark code review
- [Wireshark-commits] master 6284040: README.dissector: fixed p_add_proto_data params,
Wireshark code review
- [Wireshark-commits] master dc6482b: Convert the value string APIs that only currently have packet-scope use to wmem.,
Wireshark code review
- [Wireshark-commits] master df468f5: jsmn: check superior token node value before using it,
Wireshark code review
Mail converted by MHonArc