Wireshark-commits: [Wireshark-commits] master-1.12 c6adf15: ACSE: get rid of an evil global variabl

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 20:25:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c6adf155c943b7dc9c4c2ed3b6ff7378b1389d3c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c6adf15 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    ACSE: get rid of an evil global variable
    
    Bug: 10787
    Change-Id: I225dab439e195bbd308bcafd4658e77ef9023c0f
    Reviewed-on: https://code.wireshark.org/review/6263
    Tested-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 9aeb24994364c9a3a983b4aa8db4725b1213d64d)
    Conflicts:
    	asn1/acse/packet-acse-template.c
    	epan/dissectors/packet-acse.c
    Reviewed-on: https://code.wireshark.org/review/6309
    

Actions performed:

    from  d58037a   PKIX1Explicit: get rid of an evil global variable
    adds  c6adf15   ACSE: get rid of an evil global variable


Summary of changes:
 asn1/acse/acse.cnf               |   39 +++++++++++++-----
 asn1/acse/packet-acse-template.c |    1 -
 epan/dissectors/packet-acse.c    |   82 ++++++++++++++++++++++++--------------
 3 files changed, 80 insertions(+), 42 deletions(-)