URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=445ddc833669e8cff7e66b268d4b4b77faa504cc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
445ddc8 by Hadriel Kaplan (hadrielk@xxxxxxxxx):
Lua: FieldInfo '==' check isn't really equality
The FieldInfo metamethod for equality (letting you use the '==' operator)
doesn't check for equality, but rather if the left-hand side is within
the right-hand side. It should be equality instead. Also, all of the
FieldInfo operate overloads should push a boolean even if they're false
result.
Bug: 10820
Change-Id: Ibddaab29713f26d22ddb4d5804b9edb15e93fd79
Reviewed-on: https://code.wireshark.org/review/6186
Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from 6d6ba64 .gitignore: Add '*.nativecodeanalysis.xml'
adds 445ddc8 Lua: FieldInfo '==' check isn't really equality
Summary of changes:
epan/wslua/wslua_field.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)