Wireshark-commits: [Wireshark-commits] master 8d1a984: Remove incorrect 'if (tree)'

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Jan 2015 05:31:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d1a9848e3acc266447e1ccc032f377ba559ca50
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8d1a984 by Bill Meier (wmeier@xxxxxxxxxxx):

    Remove incorrect 'if (tree)'
    
    Incorrect because of one or both of the following:
    - col_...()/expert...() called under 'if (tree)'
    - vars set under 'if (tree)' used later (not under 'if (tree)'
       as args to col_...()/expert_...()
    
    Change-Id: I89f7d453f2d6eaa40d51cbd794ed2c9be7e549de
    Reviewed-on: https://code.wireshark.org/review/6754
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  5a23a02   Add .dirstamp - it's apparently some autotools thing.
    adds  8d1a984   Remove incorrect 'if (tree)'


Summary of changes:
 epan/dissectors/packet-extreme.c     |  224 +++++++++++++++--------------
 epan/dissectors/packet-ismacryp.c    |    4 +-
 epan/dissectors/packet-kdp.c         |    2 +-
 epan/dissectors/packet-lacp.c        |  256 +++++++++++++++++-----------------
 epan/dissectors/packet-mgcp.c        |    2 +-
 epan/dissectors/packet-netflow.c     |   14 +-
 epan/dissectors/packet-tivoconnect.c |    2 +-
 epan/dissectors/packet-v52.c         |    3 +-
 8 files changed, 250 insertions(+), 257 deletions(-)