Wireshark-commits: [Wireshark-commits] master 553da37: Create BASE_DOT, BASE_DASH, and BASE_SEMICOL

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 16:32:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=553da374461efb87436dbbed7d319d252d4fe2e6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

553da37 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create BASE_DOT, BASE_DASH, and BASE_SEMICOLON types for the FT_BYTES field type.
    
    These "bases" will put a ".", "-", or ":" respectively between hexidecimal bytes in the field in packet view and display filter.  FT_BYTES with BASE_NONE will have no separator in the packet view, but continue to have the ':' as a separator in the display filter.
    
    Converted the "string" hf_ entries that used tvb_fc_to_str as a string to use proto_tree_add_item with FT_BYTES/BASE_DOT type.
    
    Converted applicable tvb_bytes_to_ep_str_punct() calls to use the new BASE values.
    
    Change-Id: I2442185bb314d04a3ff2ba57883652ecd738b5f9
    Reviewed-on: https://code.wireshark.org/review/6098
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2085bbe   gmr1_rach: Update dual-values fields to use true_false_string
    adds  553da37   Create BASE_DOT, BASE_DASH, and BASE_SEMICOLON types for the FT_BYTES field type.


Summary of changes:
 doc/README.dissector                      |    8 +-
 epan/dfilter/dfilter-macro.c              |    2 +-
 epan/dfilter/dfvm.c                       |    2 +-
 epan/dissectors/packet-fc.c               |   18 ++--
 epan/dissectors/packet-fcdns.c            |  139 ++++++++++++-----------------
 epan/dissectors/packet-fcels.c            |   64 ++++++-------
 epan/dissectors/packet-fcfcs.c            |    7 +-
 epan/dissectors/packet-fcsb3.c            |    2 +-
 epan/dissectors/packet-fcswils.c          |   16 ++--
 epan/dissectors/packet-fip.c              |   17 ++--
 epan/dissectors/packet-isis-hello.c       |    5 +-
 epan/dissectors/packet-mip6.c             |   14 +--
 epan/dissectors/packet-ppp.c              |    7 +-
 epan/dissectors/packet-zbee-zcl-general.c |   12 +--
 epan/dissectors/packet-zbee-zcl-ha.c      |    6 +-
 epan/dissectors/packet-zbee-zcl.c         |   13 ++-
 epan/ftypes/ftype-bytes.c                 |   41 ++++++---
 epan/ftypes/ftype-double.c                |    8 +-
 epan/ftypes/ftype-guid.c                  |    4 +-
 epan/ftypes/ftype-integer.c               |   28 +++---
 epan/ftypes/ftype-ipv4.c                  |    4 +-
 epan/ftypes/ftype-ipv6.c                  |    4 +-
 epan/ftypes/ftype-pcre.c                  |    4 +-
 epan/ftypes/ftype-string.c                |    4 +-
 epan/ftypes/ftype-time.c                  |    8 +-
 epan/ftypes/ftype-tvbuff.c                |    4 +-
 epan/ftypes/ftypes-int.h                  |    4 +-
 epan/ftypes/ftypes.c                      |   10 +--
 epan/ftypes/ftypes.h                      |    7 +-
 epan/print.c                              |    4 +-
 epan/proto.c                              |   73 +++++++++++++--
 epan/proto.h                              |    7 +-
 epan/wslua/wslua_field.c                  |    6 +-
 plugins/mate/mate_util.c                  |    2 +-
 rawshark.c                                |    4 +-
 ui/cli/tap-diameter-avp.c                 |    2 +-
 ui/gtk/packet_panes.c                     |    2 +-
 ui/qt/proto_tree.cpp                      |    2 +-
 38 files changed, 300 insertions(+), 264 deletions(-)