Wireshark-commits: [Wireshark-commits] master 59c1e32: Add BASE_SPACE for FT_BYTES

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2015 19:58:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59c1e32d2c6dbdd353ae996d9538141bb029d6d0
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

59c1e32 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add BASE_SPACE for FT_BYTES
    
    It's just like BASE_DOT, BASE_DASH and BASE_SEMICOLON, only its a space between bytes.  Since this seems pretty specific to FT_BYTES, perhaps there is a better was to represent the functionality (like FT_BOOLEAN uses numeric values for number of bits)?
    
    Change-Id: I1a8f1ab263ece2736a8012b66fdd6a9105db7282
    Reviewed-on: https://code.wireshark.org/review/6451
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  effc826   Add preference to display spaces between bytes for FT_BYTES fields.
    adds  59c1e32   Add BASE_SPACE for FT_BYTES


Summary of changes:
 epan/ftypes/ftype-bytes.c |    1 +
 epan/proto.c              |   75 +++++++++++++++++++--------------------------
 epan/proto.h              |    3 +-
 3 files changed, 34 insertions(+), 45 deletions(-)