Wireshark-commits: [Wireshark-commits] master-1.12 b3abc55: DHCP/BOOTP: Option 125 Suboption: (1) o

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Jan 2015 08:57:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3abc552daf46c3805448838676bd115cacf0125
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b3abc55 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DHCP/BOOTP: Option 125 Suboption: (1) option-len always expects 1 but specification allows for more
    
    We believe this is a bug in Wireshark with Option 125 Suboption: (1)  option-len where Wireshark always expects 1 but specification is more flexible.
    Re: http://www.cablelabs.com/wp-content/uploads/specdocs/CL-SP-CANN-DHCP-Reg-I10-1308081.pdf page 15 part 4.2.2 'The DHCPv4 Option Request Option'
    
    Issue reported by Steve Krebs
    
    Bug:10784
    Change-Id: I8eced7a70877d13d925b81c0f47885609baa7633
    Reviewed-on: https://code.wireshark.org/review/6510
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit be113e8806796faf048d6c95c1141525ab5da29e)
    Reviewed-on: https://code.wireshark.org/review/6599
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  478581a   X509AF: dissect Certificate Serial Number as INT64 instead of INT32
    adds  b3abc55   DHCP/BOOTP: Option 125 Suboption: (1) option-len always expects 1 but specification allows for more


Summary of changes:
 epan/dissectors/packet-bootp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)