Wireshark-commits: [Wireshark-commits] master-1.12 79e5284: dmp, gmhdr, vssmonitoring: prevent poss

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 20:53:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79e5284afa234d0319ec426202cf5e2632fb497e
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

79e5284 by Bill Meier (wmeier@xxxxxxxxxxx):

    dmp, gmhdr, vssmonitoring: prevent possible crashes;
    
    gmtime()/localtime() can return NULL.
    
    Change-Id: If0589261429ee15d0c07972a99d94f9fe83626f6
    Reviewed-on: https://code.wireshark.org/review/6660
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit 7e1d73d0d4d4852f14d5ac3e2dcf699d0467043b)
    Reviewed-on: https://code.wireshark.org/review/6665
    

Actions performed:

    from  fcc7db9   smb-pipe: prevent possible crash; gmtime() can return NULL.
    adds  79e5284   dmp, gmhdr, vssmonitoring: prevent possible crashes;


Summary of changes:
 epan/dissectors/packet-dmp.c           |    4 ++++
 epan/dissectors/packet-gmhdr.c         |    7 ++++++-
 epan/dissectors/packet-vssmonitoring.c |    7 +++++--
 3 files changed, 15 insertions(+), 3 deletions(-)