Wireshark-commits: [Wireshark-commits] lts-1.8.2 acd589f: dec-dnart: use pinfo-scoped memory for ad

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Jan 2015 15:45:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acd589f115d77b9156975d4f1552c3b14e4fcaf0
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

acd589f by Evan Huus (eapache@xxxxxxxxx):

    dec-dnart: use pinfo-scoped memory for addresses
    
    They may be accessed during the print phase, at which point packet-scope memory
    has already been freed.
    
    In the back-ported fix we use capture-lifetime memory.
    
    Bug: 10724
    Change-Id: Ifcf5fc0c0857614edf85349b12dfe605abf6fef7
    Reviewed-on: https://code.wireshark.org/review/5499
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/6432
    

Actions performed:

    from  b98bcd4   Make sure we don't underrun a buffer when decrypting SSL.
    adds  acd589f   dec-dnart: use pinfo-scoped memory for addresses


Summary of changes:
 epan/dissectors/packet-dec-dnart.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)