Wireshark-commits: [Wireshark-commits] master 02fb290: Sort the value_string_exts at dissector regi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2015 19:48:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=02fb2908ff7884c5329db285d15d2efaa691a92e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

02fb290 by Guy Harris (guy@xxxxxxxxxxxx):

    Sort the value_string_exts at dissector registration time.
    
    You *CANNOT* defer it until dissection time, otherwise "tshark -G
    values" will fail.
    
    Change-Id: I4edf9abda271baaf916f020a211b9add5543ecc7
    Reviewed-on: https://code.wireshark.org/review/6481
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  531a9f0   Squelch a compiler warning.
    adds  02fb290   Sort the value_string_exts at dissector registration time.


Summary of changes:
 epan/dissectors/packet-mq.c |   23 +++++------------------
 1 file changed, 5 insertions(+), 18 deletions(-)