Wireshark-commits: [Wireshark-commits] master 0ee179c: HTTP: allocate header_name in packet scope i

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Jan 2015 09:16:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ee179c8c6e2eb240582298e1d67f98b4904cf40
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ee179c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    HTTP: allocate header_name in packet scope instead of file scope
    
    While we are at it, factorize the copy of value string
    
    Change-Id: I2a16155641b8bd8623baf51f787a5f450e7b3803
    Reviewed-on: https://code.wireshark.org/review/6530
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  63a3d04   Consistently use the "g_string_free returns a C string pointer" idiom.
    adds  0ee179c   HTTP: allocate header_name in packet scope instead of file scope


Summary of changes:
 epan/dissectors/packet-http.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)