Wireshark-commits: [Wireshark-commits] master-1.12 8d74f10: pppoe: col_...()/expert...() shouldn't

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Jan 2015 17:09:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d74f1068fa762f80d80437f343c243437af13a4
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

8d74f10 by Bill Meier (wmeier@xxxxxxxxxxx):

    pppoe: col_...()/expert...() shouldn't be under 'if (tree)'
    
    Change-Id: I93726546d86af677153b6b2d46fc072851a33460
    Reviewed-on: https://code.wireshark.org/review/6741
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit 96f974661550681b4bf4be78b838a8dc4ddc129b)
    Reviewed-on: https://code.wireshark.org/review/6742
    

Actions performed:

    from  d7efcc1   GTP: Bad bytes read for extended rnc id value
    adds  8d74f10   pppoe: col_...()/expert...() shouldn't be under 'if (tree)'


Summary of changes:
 epan/dissectors/packet-pppoe.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)