Wireshark-commits: [Wireshark-commits] master ee9d0f9: This being C++, maybe we don't have to initi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 31 Jan 2015 02:14:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee9d0f92307a13e288cfa966007b79ddfdb3e783
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ee9d0f9 by Guy Harris (guy@xxxxxxxxxxxx):

    This being C++, maybe we don't have to initialize ws_app until later.
    
    Try going back to haveing ws_app be an automatic variable, but don't
    declare it until after we've done the first-pass argument parsing.
    
    Change-Id: Ia1f2a4819570bfadcba75d498e01dbe64991843c
    Reviewed-on: https://code.wireshark.org/review/6867
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a984dbf   Do the first-pass argument parsing before creating the WiresharkApplication.
    adds  ee9d0f9   This being C++, maybe we don't have to initialize ws_app until later.


Summary of changes:
 wireshark-qt.cpp |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)