Wireshark-commits: [Wireshark-commits] master a835c85: Pcapng: Don't fetch past the end of a GArray

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Jan 2015 20:40:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a835c85e3d662343d7283f1dcdacb8a11d1d0727
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a835c85 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Pcapng: Don't fetch past the end of a GArray.
    
    Due to an off-by-one error an invalid ISB interface ID could make us
    fetch past the end of a GArray. Found using American Fuzzy Lop.
    
    Bug: 10895
    Change-Id: I7d4049ad7a386ae7e8013b8e741d54a31f353f1f
    Reviewed-on: https://code.wireshark.org/review/6798
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  5845f29   rtp: Don't call col_...() under 'if (tree)'
    adds  a835c85   Pcapng: Don't fetch past the end of a GArray.


Summary of changes:
 wiretap/pcapng.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)