Wireshark-commits: [Wireshark-commits] master-1.10 abebbb9: Do bounds checking when decompressing W

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Jan 2015 04:23:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abebbb99519cbf920ea4c495741ed9c7b5774def
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

abebbb9 by Guy Harris (guy@xxxxxxxxxxxx):

    Do bounds checking when decompressing WCP packets.
    
    Extract the data offset and count only once, and make sure we don't run
    past the end of the data we've copied from the packet; have
    decompressed_entry() just do the decompression, rather than also
    fetching the data offset and count.
    
    Add some comments while we're at it.
    
    Bug: 10844
    Change-Id: I6cd720461603e9ad9ec61d2f615ce892a491617c
    Reviewed-on: https://code.wireshark.org/review/6516
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5e57b07   [Automatic manuf, services and enterprise-numbers update for 2015-01-11]
    adds  abebbb9   Do bounds checking when decompressing WCP packets.


Summary of changes:
 epan/dissectors/packet-wcp.c |  115 +++++++++++++++++++++++++++++-------------
 1 file changed, 81 insertions(+), 34 deletions(-)