Wireshark-commits: [Wireshark-commits] master 2eaa467: oids: fix memory leak

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Jan 2015 01:56:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eaa467b34d78b216a1ba9305bd23a9196209b3b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2eaa467 by Evan Huus (eapache@xxxxxxxxx):

    oids: fix memory leak
    
    In oid_encoded2subid_sub(), the scope we get may be NULL, in which case if we
    don't return our allocated buffer, it is our responsibility to free it. Minor
    regression from ge333e4c90f0aca41b0a56cef22fd80d0b0e73e14.
    
    Bug: 10883
    Change-Id: I324ca770278ab0575511c5e9ab72b70d6ac1a391
    Reviewed-on: https://code.wireshark.org/review/6748
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  612e286   Fix test script to test Lua Pinfo, and fix problem it found.
    adds  2eaa467   oids: fix memory leak


Summary of changes:
 epan/oids.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)