Wireshark-commits: [Wireshark-commits] master d9b480d: PKIX1Explicit: get rid of an evil global var

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 19:34:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9b480dd5809b76f5ed6a06eda9f9663087af6aa
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d9b480d by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    PKIX1Explicit: get rid of an evil global variable
    
    Bug: 10744
    Change-Id: I9fbd7c881ab6b17fa9febb55a4f33dbb229c900b
    Reviewed-on: https://code.wireshark.org/review/6264
    Tested-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  d16f114   Convert "FC Member Identifier" fields from all strings to their "native" formats.
    adds  d9b480d   PKIX1Explicit: get rid of an evil global variable


Summary of changes:
 asn1/pkix1explicit/packet-pkix1explicit-template.c |    3 --
 asn1/pkix1explicit/pkix1explicit.cnf               |   22 ++++++++----
 epan/dissectors/packet-pkix1explicit.c             |   36 ++++++++++++--------
 3 files changed, 38 insertions(+), 23 deletions(-)