Wireshark-commits: [Wireshark-commits] master ffa8bdd: Correct PF field offset when looking for DA

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Jan 2015 20:21:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ffa8bdd3cabba7fe299256ac3b4dec6679f92b60
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ffa8bdd by Russel (russel@xxxxxxxxxxxxxxxxxxxx):

    Correct PF field offset when looking for DA
    
    Previous code was not shifting far enough, was checking PS instead
    of PF.
    
    Change-Id: Ic0bdbb4dfaa7bdd708a49f1fb67706dd949f2607
    Reviewed-on: https://code.wireshark.org/review/6578
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8ec6ac6   dissect CCRC, APRC and the APDU body's data
    adds  ffa8bdd   Correct PF field offset when looking for DA


Summary of changes:
 epan/dissectors/packet-j1939.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)