Wireshark-commits, August 2015
- [Wireshark-commits] master 1afe288: More packet detail context menu items.,
Wireshark code review
- [Wireshark-commits] master f8cac8e: PNRP: add support for message reassembly,
Wireshark code review
- [Wireshark-commits] master 86a8b9c: MS-WSP: fix some Coverity warnings,
Wireshark code review
- [Wireshark-commits] master 711edcf: Set the reported length of chunk data correctly.,
Wireshark code review
- [Wireshark-commits] master b1ce653: [Automatic update for 2015-08-02],
Wireshark code review
- [Wireshark-commits] master-1.12 018bbdf: [Automatic update for 2015-08-02],
Wireshark code review
- [Wireshark-commits] master 37a1bb8: CoAP: add media type number for application/cbor,
Wireshark code review
- [Wireshark-commits] master d12283b: proto.c: exclude hf_text_only from proto_registrar_is_protocol(),
Wireshark code review
- [Wireshark-commits] master 78ca0af: HTTP2: remove weak part of the heuristic,
Wireshark code review
- [Wireshark-commits] master 7c46b25: qt: fix scrollbar crash applying conv. filter,
Wireshark code review
- [Wireshark-commits] master 08e80b1: Skip files larger than 8MB in valgrind fuzzing,
Wireshark code review
- [Wireshark-commits] master 9557c73: Make sure per-packet tap callbacks return gbooleans.,
Wireshark code review
- [Wireshark-commits] master 56ee4b1: TFTP: strengthen heuristic used over STUN/TURN,
Wireshark code review
- [Wireshark-commits] master ae05f77: Give an I-D reference for this.,
Wireshark code review
- [Wireshark-commits] master 2964c28: Update a comment to reflect reality as of 1997.,
Wireshark code review
- [Wireshark-commits] master 6e87802: tvb_new_octet_aligned() should return both the captured and reported length set to datalen in the returned tvb.,
Wireshark code review
- [Wireshark-commits] master 4908c75: [ISUP] Read the country code at offset,
Wireshark code review
- [Wireshark-commits] master 8421af3: Rename nettrace3gpp324423 to 3gpp32423,
Wireshark code review
- [Wireshark-commits] master 992c892: MIB/OID Fix assertion in proto.c tmp_fld_check_assert(). It seems like oid_data->name may get freed so do a g_strdup() as it's done for hf.hfinfo.abbrev.,
Wireshark code review
- [Wireshark-commits] master 3413ddf: EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 632b402: Zero stat table elements instead of freeing them.,
Wireshark code review
- [Wireshark-commits] master 03802cc: Convert H.225 tap stats to new "generic stat API".,
Wireshark code review
- [Wireshark-commits] master d51d83b: Fix the selected packet indicator width.,
Wireshark code review
- [Wireshark-commits] master 4e14a26: Don't zero stat tap elements.,
Wireshark code review
- [Wireshark-commits] master 3e6b527: Remove the CLI H.225 counter.,
Wireshark code review
- [Wireshark-commits] master 4d673b2: Convert Camel tap stats to new "generic stat API".,
Wireshark code review
- [Wireshark-commits] master ad4ab2a: Convert the GSM A stats to new "generic stat API".,
Wireshark code review
- [Wireshark-commits] master 8bf1237: MAC CTRL: fix dissection of PAUSE frame,
Wireshark code review
- [Wireshark-commits] master-1.12 0a3e315: MAC CTRL: fix dissection of PAUSE frame,
Wireshark code review
- [Wireshark-commits] master 5de487a: [MSVC 2015] Compiler and visual studio version are off by 5 not 6 in MSVC 2015.,
Wireshark code review
- [Wireshark-commits] master 2221153: [MSVC 2015] Fix errors seen with the released version by reverting the code to what failed on the RC version *sigh*,
Wireshark code review
- [Wireshark-commits] master 53a8033: Generate XHTML5 documentation.,
Wireshark code review
- [Wireshark-commits] master 3b2e6d9: Revert "[MSVC 2015] Fix errors seen with the released version by reverting the code to what failed on the RC version *sigh*",
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 62e56ad: Make sure we use "*.html" in our chunked output.,
Wireshark code review
- [Wireshark-commits] master f0beaa1: openSAFETY: Better display of packet info,
Wireshark code review
- [Wireshark-commits] master 504f5b3: Clean up some fields.,
Wireshark code review
- [Wireshark-commits] master 6aabad5: epl: Fix Payload sub-dissection,
Wireshark code review
- [Wireshark-commits] master dc09d18: Output xhtml guides everywhere.,
Wireshark code review
- [Wireshark-commits] master ef0bdbc: Cleanup a bunch of 802.11ad stuff.,
Wireshark code review
- [Wireshark-commits] master 05eb9b6: Add proper base prefixes in display filter expressions.,
Wireshark code review
- [Wireshark-commits] master b7f5eaa: Convert the GSM MAP stats to new "generic stat API".,
Wireshark code review
- [Wireshark-commits] master-1.12 76c93e1: Cleanup a bunch of 802.11ad stuff.,
Wireshark code review
- [Wireshark-commits] master f30ac4a: Fix a bunch of typoes in variable and field names.,
Wireshark code review
- [Wireshark-commits] master-1.12 9e41843: Fix a bunch of typoes in variable and field names.,
Wireshark code review
- [Wireshark-commits] master c6889d8: Fix some encoding arguments.,
Wireshark code review
- [Wireshark-commits] master-1.12 4693d90: Fix some encoding arguments.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.6 x86,
buildbot-no-reply
- [Wireshark-commits] master 1420f3d: Add ui_gsm_map_summary_dialog.h so it goes into the source tarball.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] master 910438b: Pcapng: support Name Resolution Block options,
Wireshark code review
- [Wireshark-commits] master b4dea54: Try to fix dist.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] master 8906e93: Bluetooth: Fix some MSVC2015 warnings/errors,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master aa2184f: Fix pcapng.c:3788: warning: implicit conversion shortens 64-bit value into a 32-bit value,
Wireshark code review
- [Wireshark-commits] master 544bca7: include <stdlib.h> to make windows build boot happy.,
Wireshark code review
- [Wireshark-commits] master 5fa57ec: [MSVC 2015]Once agin revert tho original, now as a separate patch.,
Wireshark code review
- [Wireshark-commits] master-1.12 0609f98: epl: Fix Payload sub-dissection,
Wireshark code review
- [Wireshark-commits] master fda29e1: Use int_to_qstring in a few more places.,
Wireshark code review
- [Wireshark-commits] master 9fd3bcc: Add an elide mode preference for the Qt packet list.,
Wireshark code review
- [Wireshark-commits] master ff24ecc: Fixup stat_tap table freeing.,
Wireshark code review
- [Wireshark-commits] master dc33bba: [ieee80211] Change one ENC_LITTLE_ENDIAN MAC address to ENC_NA; byte order doesn't apply to them.,
Wireshark code review
- [Wireshark-commits] master-1.12 5bbfcef: [ieee80211] Change one ENC_LITTLE_ENDIAN MAC address to ENC_NA; byte order doesn't apply to them.,
Wireshark code review
- [Wireshark-commits] master 4557c17: androiddump: Try to make MVS14.0 happy,
Wireshark code review
- [Wireshark-commits] master 0c9998d: Add dissector for MQTT-SN v1.2,
Wireshark code review
- [Wireshark-commits] master fd19aaf: Add ONC RPC program stats.,
Wireshark code review
- [Wireshark-commits] master 99873f7: [GTPv2] Dissect IE MM Context for CS to PS SRVCC, update value strings.,
Wireshark code review
- [Wireshark-commits] master 5bbb6ff: Try to fix packet-rpc.c:3909: warning: implicit conversion shortens 64-bit value into a 32-bit value,
Wireshark code review
- [Wireshark-commits] master f657e6a: [GTPv2] Mark a parameter as unused.,
Wireshark code review
- [Wireshark-commits] master 7171ee5: [ieee80211] Rework QoS Capability and QoS info code.,
Wireshark code review
- [Wireshark-commits] master c8ca0ae: Try to fix casting issues with older versions of GLib.,
Wireshark code review
- [Wireshark-commits] master c90fcba: Lua: Count Lua plugins in splash screen,
Wireshark code review
- [Wireshark-commits] master 147ab19: Switch the floats in stat_tap table items to doubles.,
Wireshark code review
- [Wireshark-commits] master 0a1d1bd: More casting issues with older versions of GLib.,
Wireshark code review
- [Wireshark-commits] master 240105e: Fixup the Qt splash overlay progress calculations.,
Wireshark code review
- [Wireshark-commits] master 817d9bd: Add SHA2 algos to certificate dissection in SSL,
Wireshark code review
- [Wireshark-commits] master a001ed6: Avoid (unlikely) NRB record size overflows.,
Wireshark code review
- [Wireshark-commits] master 7cb2b11: Rework CMake dependendencies in the docbook directory.,
Wireshark code review
- [Wireshark-commits] master 5cf66db: Add a missing dependency.,
Wireshark code review
- [Wireshark-commits] master b703f47: GTPv2: fix indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master 39ad1bf: NCP2222(.inc): fix indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master 9a16a69: NCP2222.py : fix generate indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master 454f08d: If SOCKS server doesnt't require authentication, then client should be ready for commands.,
Wireshark code review
- [Wireshark-commits] master-1.12 aa0da4b: If SOCKS server doesnt't require authentication, then client should be ready for commands.,
Wireshark code review
- [Wireshark-commits] master c60c1b9: IEEE802.11: Fix typo,
Wireshark code review
- [Wireshark-commits] master f6fb630: Fix another typo.,
Wireshark code review
- [Wireshark-commits] master-1.12 fc671b9: IEEE802.11: Fix typo,
Wireshark code review
- [Wireshark-commits] master-1.12 8d7655a: Fix another typo.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 524db99: GSM (a_common): fix comma at end of enumerator list [-Wpedantic],
Wireshark code review
- [Wireshark-commits] master 11e5422: GSM (a_common): fix no previous prototype for 'gsm_a_*_init' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 0626e76: CMake: Try to fix generated docbook dependencies.,
Wireshark code review
- [Wireshark-commits] master de872cb: Generate DocBook conditionally.,
Wireshark code review
- [Wireshark-commits] master 4bba83b: Reset the splash timer after processing events.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test,
buildbot-no-reply
- [Wireshark-commits] master a8af51d: [Automatic update for 2015-08-09],
Wireshark code review
- [Wireshark-commits] master-1.12 a17afa6: [Automatic update for 2015-08-09],
Wireshark code review
- [Wireshark-commits] master 394773c: Switch the guides back to html output.,
Wireshark code review
- [Wireshark-commits] master dbf314a: Trivial: Change editor-modelines tab-width specification from 4 to 8.,
Wireshark code review
- [Wireshark-commits] master c5af152: Trivial: Convert 'tabs' indentation to '4 space' indentation,
Wireshark code review
- [Wireshark-commits] master b3207c0: zigbee: remove a numer of unnecessary if (tree) checks,
Wireshark code review
- [Wireshark-commits] master 2ef3cda: t124: kill evil global variables,
Wireshark code review
- [Wireshark-commits] master a29f513: [skinny] Add missing change to source (.in); Also do minor cleanup.,
Wireshark code review
- [Wireshark-commits] master a051961: [wiretap/nettrace_3gpp_32_423] Add editor modelines,
Wireshark code review
- [Wireshark-commits] master aafc7ff: H225: fix no previous prototype for 'h225_stat_init' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 655b0dc: use the captured length as payload length for zigbee decryption,
Wireshark code review
- [Wireshark-commits] master 6d8b4af: Cleanup variable name in dissect_frag6(),
Wireshark code review
- [Wireshark-commits] master c462f1b: Eliminate proto_tree_add_text from packet-wbxml.c,
Wireshark code review
- [Wireshark-commits] master d108f28: zigbee: fix two memory leaks,
Wireshark code review
- [Wireshark-commits] master 3157114: Use the reported length where appropriate.,
Wireshark code review
- [Wireshark-commits] master 43c2e57: Don't try to decrypt the payload if it was cut short by the snapshot length.,
Wireshark code review
- [Wireshark-commits] master-1.12 84a3493: use the captured length as payload length for zigbee decryption,
Wireshark code review
- [Wireshark-commits] master-1.12 76d50a7: Use the reported length where appropriate.,
Wireshark code review
- [Wireshark-commits] master-1.12 39e6153: Don't try to decrypt the payload if it was cut short by the snapshot length.,
Wireshark code review
- [Wireshark-commits] master 75d46fe: Get rid of trailing white space.,
Wireshark code review
- [Wireshark-commits] master-1.12 809b52a: Get rid of trailing white space.,
Wireshark code review
- [Wireshark-commits] master 76d4b80: g_slist_free_full () does not exist until GLIB 2.28,
Wireshark code review
- [Wireshark-commits] master 7fb514f: GSM (a_common): fix indent (replace tab by 8 spaces),
Wireshark code review
- [Wireshark-commits] master e1003ee: editcap: fix -T <encapsulation type> option when output format is pcapng,
Wireshark code review
- [Wireshark-commits] master 94bb276: Try to fix the build bou by copying tha cast made in glib.,
Wireshark code review
- [Wireshark-commits] master 52a7b79: remove some unnecessary if (tree) checks,
Wireshark code review
- [Wireshark-commits] master-1.12 1b52790: editcap: fix -T <encapsulation type> option when output format is pcapng,
Wireshark code review
- [Wireshark-commits] master b1be6bc: zigbee: remove some more if (tree) checks,
Wireshark code review
- [Wireshark-commits] master 56a9b53: zbee-nwk-gp: fix a memory leak when keys are defined in the preferences,
Wireshark code review
- [Wireshark-commits] master c262bf2: [GIOP] A GIOP message can have size = 0 (CloseConnection),
Wireshark code review
- [Wireshark-commits] master 2579607: [ENEA LINX over TCP] Make the TCP port registration a preference defalted to 0.,
Wireshark code review
- [Wireshark-commits] master f233824: [Diameter] Add expert info to subdissection of 3GPP AVP:s,
Wireshark code review
- [Wireshark-commits] master 70d06de: [SMCR] Minimum 4 bytes is required to perform the heuristic check.,
Wireshark code review
- [Wireshark-commits] master ecc4f75: Added Reload Lua plugins.,
Wireshark code review
- [Wireshark-commits] master d6c6b08: wmem: Mark removed strings with is_removed,
Wireshark code review
- [Wireshark-commits] master de70d2a: H225: fix indent (use 2 spaces) and add modelines info,
Wireshark code review
- [Wireshark-commits] master 4309b96: Sort dump_open_table_base[] in the right order.,
Wireshark code review
- [Wireshark-commits] master 58ec64c: wmem: Fix wmem_tree_remove_string,
Wireshark code review
- [Wireshark-commits] master f1a4db3: Lua: Remove unneeded call in wslua_cleanup,
Wireshark code review
- [Wireshark-commits] master 14c7525: [Qt Expert Info dialogue] remove our tap listener when the dialogue is destroyed,
Wireshark code review
- [Wireshark-commits] master-1.12 423932b: Force shell script line endings.,
Wireshark code review
- [Wireshark-commits] master-1.12 120a180: Prep for 1.12.7.,
Wireshark code review
- [Wireshark-commits] master 7b39eac: It looks as if the origin of the time stamps is the UN*X epoch.,
Wireshark code review
- [Wireshark-commits] master 36c50fe: Document Colasoft Capsa file support.,
Wireshark code review
- [Wireshark-commits] master 1100ba9: Update comments.,
Wireshark code review
- [Wireshark-commits] master 260ae6a: Clean up the file header description.,
Wireshark code review
- [Wireshark-commits] master 50b51a6: Some further questions, asked in comments.,
Wireshark code review
- [Wireshark-commits] master bfdc2cb: Eliminate proto_tree_add_text from some dissectors.,
Wireshark code review
- [Wireshark-commits] master cd16301: [GTP] Direct Tunnel Flags 7.7.81 is currently specified with one data octet.,
Wireshark code review
- [Wireshark-commits] master a3e3d60: Align comments,
Wireshark code review
- [Wireshark-commits] master dc7443f: Added guards for deregistered fields,
Wireshark code review
- [Wireshark-commits] master 5a92694: Initialize is_reloading_lua at startup,
Wireshark code review
- [Wireshark-commits] master bde416a: Lua: Moved deregister out of wslua_cleanup,
Wireshark code review
- [Wireshark-commits] master-1.12 7fc8978: Build 1.12.7.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.7 created (now 3455751),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.7rc0 created (now f022a1a),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.12.7 created (now f8e56aa),
Wireshark code review
- [Wireshark-commits] master-1.12 909e732: 1.12.7 → 1.12.8.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.8rc0 created (now d5a896f),
Wireshark code review
- [Wireshark-commits] master 412f5b3: Expert information dialog performance improvements.,
Wireshark code review
- [Wireshark-commits] master 5c80f08: Add DCE-RPC and ONC-RPC service response time dialogs.,
Wireshark code review
- [Wireshark-commits] master 6ae8df4: [pdc] [msvc-2015] Change a variable type to prevent 32-bit MSVC-2015 "internal error",
Wireshark code review
- [Wireshark-commits] master d20f2b6: [pdc] Fix a few [msvc-2015?] warnings about 'constant compared to constant',
Wireshark code review
- [Wireshark-commits] master 451dd05: [lwres] Fix (32 bit ?) MSVC-2015 warning: "conversion from 'size_t' to 'guint16', possible loss of data",
Wireshark code review
- [Wireshark-commits] master 2449c7a: GTP: fix indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master db2692c: Qt (main_window) fix no previous prototype for '...' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 99e3244: Initialize a couple of variables.,
Wireshark code review
- [Wireshark-commits] master 0b7d161: editcap: add change offset.,
Wireshark code review
- [Wireshark-commits] master 61d1ea4: Initialize another variable.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master beb5c0b: Eliminate proto_tree_add_text from some dissectors.,
Wireshark code review
- [Wireshark-commits] master 6087f2a: fuzz-test.sh: added missing option in help.,
Wireshark code review
- [Wireshark-commits] master 738cf42: Make building with MSVC2015 work TODO:,
Wireshark code review
- [Wireshark-commits] master 2d5f2ae: GVCP: fix dissection of Stream Channel Packet Size register,
Wireshark code review
- [Wireshark-commits] master-1.12 3e69b4f: GVCP: fix dissection of Stream Channel Packet Size register,
Wireshark code review
- [Wireshark-commits] master 7661bb2: Qt: fix copy of newer files when building with qmake,
Wireshark code review
- [Wireshark-commits] master cd76cf6: ieee802.11: changed blurb to stop checkAPI complains.,
Wireshark code review
- [Wireshark-commits] master 66f784a: [config.nmake] Add minor comment about /Zo option for MSVC-2015,
Wireshark code review
- [Wireshark-commits] master-1.12 2edab9f: [config.nmake] Also look for Chocolatey install of Python,
Wireshark code review
- [Wireshark-commits] master 5931da9: ixiatrailer: Change format of the protocol so that is supports future fields.,
Wireshark code review
- [Wireshark-commits] master 814f617: Update to reflect reality.,
Wireshark code review
- [Wireshark-commits] master 3c5fd58: Get rid of trailing whitespace.,
Wireshark code review
- [Wireshark-commits] master 6cc1c8d: Clean up heuristic checks.,
Wireshark code review
- [Wireshark-commits] master 8426225: Qt: Avoid redissect twice when changing fields,
Wireshark code review
- [Wireshark-commits] master 28b5206: Free protocol in proto_free_deregistered_fields,
Wireshark code review
- [Wireshark-commits] master 12ff69d: Qt: Fixed funnel text dialog append and prepend,
Wireshark code review
- [Wireshark-commits] master 7833b93: Free all hfi->strings in free_deregister_field,
Wireshark code review
- [Wireshark-commits] master 46d6e8c: Added some missing breaks,
Wireshark code review
- [Wireshark-commits] master 4c6da64: Ident the merge.c/h files by 4 spaces,
Wireshark code review
- [Wireshark-commits] master-1.12 489b06e: Make some inconsistent configuration options errors.,
Wireshark code review
- [Wireshark-commits] master 0ddae1b: Put it in the Qt category, not the GTK category.,
Wireshark code review
- [Wireshark-commits] master 6137197: Fix for the current wireshark.desktop.,
Wireshark code review
- [Wireshark-commits] master 463caf8: Discuss alternatives to polling all the recent files every 2 seconds.,
Wireshark code review
- [Wireshark-commits] master 8368f3b: Update the previously-added comment.,
Wireshark code review
- [Wireshark-commits] master 8282540: Eliminate proto_tree_add_text from GSM dissectors.,
Wireshark code review
- [Wireshark-commits] master 677d4d6: Add IPv6 Jumbogram support (RFC 2675),
Wireshark code review
- [Wireshark-commits] master 85d2eef: btatt: guard against incomplete reassembly,
Wireshark code review
- [Wireshark-commits] master 85e2018: udp: fix minimum jumbo length,
Wireshark code review
- [Wireshark-commits] master 7f38b65: Don't clear the tcp_analysis if a conversation is not provided to get_tcp_conversation_data().,
Wireshark code review
- [Wireshark-commits] master 2bc6f01: *More* issues.,
Wireshark code review
- [Wireshark-commits] master 0a16350: Add a newline for readability,
Wireshark code review
- [Wireshark-commits] master 5f13933: Lua: Free true_false_string values at reload,
Wireshark code review
- [Wireshark-commits] master 88f334b: Fixed a comment in cleanup_dissection,
Wireshark code review
- [Wireshark-commits] master c222719: Fix creation of menu actions in ws_menubar_create_action_group().,
Wireshark code review
- [Wireshark-commits] master 1b46738: Do the "plugin" menu stuff in one pass.,
Wireshark code review
- [Wireshark-commits] master 8b45727: Un-reference actions after adding them to an action group.,
Wireshark code review
- [Wireshark-commits] master 2e2129a: Conversion of random proto_tree_add_text calls.,
Wireshark code review
- [Wireshark-commits] master 8fa4016: make-taps.pl: Remove duplicate slash in pathname,
Wireshark code review
- [Wireshark-commits] master b1d33db: AMQP 1.0: Refactor to fix parsing of timestamps,
Wireshark code review
- [Wireshark-commits] master 8d1a549: [Automatic update for 2015-08-16],
Wireshark code review
- [Wireshark-commits] master-1.12 56dbe51: [Automatic update for 2015-08-16],
Wireshark code review
- [Wireshark-commits] master c643cbf: Run abicheck commands at compile time.,
Wireshark code review
- [Wireshark-commits] master 3755bc6: Fix IP Destinations stats tree,
Wireshark code review
- [Wireshark-commits] master 6f7811e: A new Early Allocation Request for draft-ietf-pce-lsp-setup-type and draft-ietf-pce-segment-routing has been issued. Reference: https://mailarchive.ietf.org/arch/msg/pce/Zdsc0HHl1SLvpANRWhpLvIzJQyI There are implementations out there that are using 5 as SR-ERO subobject identifier (instead of 36 that will be assigned by IANA) and 27 as the PATH-SETUP-TYPE TLV identifier (instead of 28 that will be assigned by IANA). This patch decodes both 5/36 as SR-ERO subobject and 27/28 as PATH-SETUP-TYPE. It is unlikely that IANA will re-assign code points 5 and 27 in the near future.,
Wireshark code review
- [Wireshark-commits] master 8b8d378: AMQP 1.0: Fix OSX build errors,
Wireshark code review
- [Wireshark-commits] master 2ba0ea3: Fix the conversion of milliseconds to seconds and nanoseconds.,
Wireshark code review
- [Wireshark-commits] master af62264: DNP3: add support for udp multi frame packets.,
Wireshark code review
- [Wireshark-commits] master 9a6e36d: Remove proto_tree_add_text from packet-xml.c,
Wireshark code review
- [Wireshark-commits] master 77193ef: dissect_ip_heur(): Remove TODO (done),
Wireshark code review
- [Wireshark-commits] master-1.12 9eef674: Fix IP Destinations stats tree,
Wireshark code review
- [Wireshark-commits] master 2eec7fe: BPDU: Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang,
Wireshark code review
- [Wireshark-commits] master b660fd4: Pcapng: set interface description's tsprecision when reading file,
Wireshark code review
- [Wireshark-commits] master 821ea20: Add Decryption support for Lwmesh,
Wireshark code review
- [Wireshark-commits] master 0368b82: Improve multicast address checking.,
Wireshark code review
- [Wireshark-commits] master 68c5172: Qt: Always rebuild columns when fields changed,
Wireshark code review
- [Wireshark-commits] master ec1d25d: Qt: Avoid double call to toUtf8(),
Wireshark code review
- [Wireshark-commits] master c78d7c8: h1: don't THROW() an exception from a dissector,
Wireshark code review
- [Wireshark-commits] master 41cb3bd: h1: remove if (tree) checks, indent according to the modelines,
Wireshark code review
- [Wireshark-commits] master c57f585: Fixup tap listener registration.,
Wireshark code review
- [Wireshark-commits] master 300bb98: Install GTK3 too.,
Wireshark code review
- [Wireshark-commits] master 8fd7197: Lua: add FT_PROTOCOL as a ProtoField type,
Wireshark code review
- [Wireshark-commits] master acc0c14: Eliminate proto_tree_add_text from XMPP dissectors.,
Wireshark code review
- [Wireshark-commits] master 4048ca0: rewrite the H1 dissector,
Wireshark code review
- [Wireshark-commits] master e25562b: Pcapng: clean up Section Header Block handling,
Wireshark code review
- [Wireshark-commits] master 0375244: Qt/Minimap: Fix for Qt < 4.8,
Wireshark code review
- [Wireshark-commits] master 318c3a5: Qt: Add another C++ missing header: <algorithm> for std::sort(),
Wireshark code review
- [Wireshark-commits] master 9e72779: Preparation Host Flows: Dissector Packet ICMP and ICMPv6,
Wireshark code review
- [Wireshark-commits] master df17ff3: Qt: Fix use-after-free pattern,
Wireshark code review
- [Wireshark-commits] master a50a49e: Bluetooth: ATT: Add some remaining attributes,
Wireshark code review
- [Wireshark-commits] master db5b786: Bluetooth: Update Assign Numbers,
Wireshark code review
- [Wireshark-commits] master c05df99: Add udp_dissect_pdus.,
Wireshark code review
- [Wireshark-commits] master dd57c6b: File-format: Add PCAP and PCAPNG dissectors,
Wireshark code review
- [Wireshark-commits] master 22364bd: File-format: BTSNOOP: Add option to dissect next layers,
Wireshark code review
- [Wireshark-commits] master da6f48d: Fix typo in makefile,
Wireshark code review
- [Wireshark-commits] master db87e62: pcap: add init value.,
Wireshark code review
- [Wireshark-commits] master a3c175a: Add casts to passify buildboot.,
Wireshark code review
- [Wireshark-commits] master 8fcdcb9: Improve file merging for mergecap and wireshark,
Wireshark code review
- [Wireshark-commits] master 97f3c1b: Qt: Reload widgets using prefs when reloading Lua plugins,
Wireshark code review
- [Wireshark-commits] master f49eb37: Update comment.,
Wireshark code review
- [Wireshark-commits] master 7a096c3: Init values set (found by American Fuzzy Lop).,
Wireshark code review
- [Wireshark-commits] master ea7cf08: Cast away 64 -> 32 narrowing complaints.,
Wireshark code review
- [Wireshark-commits] master 4abec47: Clean up handling of time stamps.,
Wireshark code review
- [Wireshark-commits] master 857b144: Qt: Syntax check display filter when fields changed,
Wireshark code review
- [Wireshark-commits] master 6ed3e080: pcapng(file): fix duplicate break,
Wireshark code review
- [Wireshark-commits] master 2eaaffe: simple_statistics_dialog(.h): fix parameter 'st_table' not found in the function declaration [-Wdocumentation],
Wireshark code review
- [Wireshark-commits] master 9a3d4e6: Move an include guard.,
Wireshark code review
- [Wireshark-commits] master 0e8cc9a: UDP multicast stream dialog.,
Wireshark code review
- [Wireshark-commits] master fc1b48f: DVBCI: fix typo in comment,
Wireshark code review
- [Wireshark-commits] master 8352ff1: Add IPv6 examples to capture/display filters,
Wireshark code review
- [Wireshark-commits] master c32c1f0: IPv6 Jumbogram expert info cleanup,
Wireshark code review
- [Wireshark-commits] master a22bb87: Update .mailmap,
Wireshark code review
- [Wireshark-commits] master d5caba6: [IPv6] Make "ip.version" field pretty(er),
Wireshark code review
- [Wireshark-commits] master 3268023: Added TDMoP protocol dissector,
Wireshark code review
- [Wireshark-commits] master d64ad1d: capinfos: add more info about file and interfaces,
Wireshark code review
- [Wireshark-commits] master dcaa64a: Mergecap: add test suite for various merging scenarios,
Wireshark code review
- [Wireshark-commits] master 9976f52: .mailmap: sort using sort -u,
Wireshark code review
- [Wireshark-commits] master e328fa5: IPv6: Minor variable name fix,
Wireshark code review
- [Wireshark-commits] master b755a66: Use MAC address documentation range in filter examples,
Wireshark code review
- [Wireshark-commits] master fa40025: Recompile dfilter for all tap listeners when fields changed,
Wireshark code review
- [Wireshark-commits] master d470ff1: btsnoop: Missing break in switch (CID 1316606),
Wireshark code review
- [Wireshark-commits] master 03b78a0: Bluetooth: ATT: Fix code will never be executed [-Wunreachable-code],
Wireshark code review
- [Wireshark-commits] master d05b6f9: Bluetooth: ATT: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 89a8ad6: Preparation Host Flows: Tap Sequence Analysis,
Wireshark code review
- [Wireshark-commits] master 9380d06: ixiatrailer: remove execute bit,
Wireshark code review
- [Wireshark-commits] master bb96725: Use system's OpenLayers.js on Debian,
Wireshark code review
- [Wireshark-commits] master 2c260fa: Use system's GeoIP database by default on Debian,
Wireshark code review
- [Wireshark-commits] master 0bdf518: Try to debug merge test suite failure on windows buildbot,
Wireshark code review
- [Wireshark-commits] master d9dd323: file-pcapng: remove useless hf_pcapng_timestamp_data entry,
Wireshark code review
- [Wireshark-commits] master 8a86222: PNRP: capitalize protocol name,
Wireshark code review
- [Wireshark-commits] master fc0a2f5: Add more debug infor for windows buildbot test suite failure,
Wireshark code review
- [Wireshark-commits] master b3daf70: Pcap: wtap does not set interface timestamp precision when reading pcap,
Wireshark code review
- [Wireshark-commits] master ddaa311: Remove unused struct member from wtap,
Wireshark code review
- [Wireshark-commits] master 6fb6ede: Get the windows buildbot working for mergecap test suite,
Wireshark code review
- [Wireshark-commits] master 3b5a1f2: Link setargv.obj for Windows in CMake so mergecap works,
Wireshark code review
- [Wireshark-commits] master 29cd036: Clear display filter when filterPackets with empty filter,
Wireshark code review
- [Wireshark-commits] master 75f4ff7: Make empty filter valid in checkFilter,
Wireshark code review
- [Wireshark-commits] master 950f1dd: IO Graphs: Don't show unchecked graphs in legend,
Wireshark code review
- [Wireshark-commits] master bc777f9: Added a missing break,
Wireshark code review
- [Wireshark-commits] master 2046368: file-pcapng: fix dissection of options in blocks,
Wireshark code review
- [Wireshark-commits] master ff78d0a: file-pcap: differentiate captured length and reported length when calling next dissector and catch bound errors,
Wireshark code review
- [Wireshark-commits] master bc8b94d: file-pcapng: differentiate captured length and reported length when calling next dissector and catch bound errors,
Wireshark code review
- [Wireshark-commits] master 8a71867: UDP jumbogram expert info fix,
Wireshark code review
- [Wireshark-commits] master 7249791: pcapng: Fixed copying if_filter_bpf_bytes,
Wireshark code review
- [Wireshark-commits] master ba69473: Link setargv.obj for Windows in CMake so mergecap works,
Wireshark code review
- [Wireshark-commits] master 829c648: Check for IP version errors in dissect_ip(),
Wireshark code review
- [Wireshark-commits] master 37a737f: Make sure we can apply deprecated display filters.,
Wireshark code review
- [Wireshark-commits] master 36a74cb: Tap parameter and stats dialog fixups.,
Wireshark code review
- [Wireshark-commits] master-1.12 21ec666: pcapng: Fixed copying if_filter_bpf_bytes,
Wireshark code review
- [Wireshark-commits] master e67098c: Squelch recent display filter warnings.,
Wireshark code review
- [Wireshark-commits] master c4b93e9: CMake: Fixup appending to WS_WIN_LIBS,
Wireshark code review
- [Wireshark-commits] master 648fe94: Translations: fix typo,
Wireshark code review
- [Wireshark-commits] master 4dd49c5: Camel: Fix indent (use 2 spaces) and add modelines,
Wireshark code review
- [Wireshark-commits] master b07ae6c: ANSI: Add modelines,
Wireshark code review
- [Wireshark-commits] master 0f9bbbc: BOOTP: fix indent (use tab),
Wireshark code review
- [Wireshark-commits] master 2ed3d91: Add the WLAN statistics dialog.,
Wireshark code review
- [Wireshark-commits] master 56d131c: There is no wlan_statistics_dialog.ui.,
Wireshark code review
- [Wireshark-commits] master d9395b7: Rename 'ip_next_header_dissector_table' to 'ipv6_next_header_dissector_table' in IPv6 dissector,
Wireshark code review
- [Wireshark-commits] master a70f591: proto_dlg: fix no previous prototype for ‘heur_*_all_cb’ [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 71e08dd: lemonflex: fix warning: no previous prototype for 'df_scanner_*' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master dc4e960: Add some Gx AVPs from 3GPP 29.212.,
Wireshark code review
- [Wireshark-commits] master b4762a0: Generate Diameter's expert info's even when there's no tree so that they show up in the Expert Infos dialog.,
Wireshark code review
- [Wireshark-commits] master fab0e59: Fix memory leaks of dumper SHB and IDB infos,
Wireshark code review
- [Wireshark-commits] master 8f0fc4b: GSM/ANSI/CAMEL...: fix no previous prototype for '*_stat_init' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master aec8e93: SPDY: fix no previous prototype for 'dissect_spdy_heur' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 0310e5a: gsm map summary (GTK): fix no previous prototype for ‘gsm_map_stat_gtk_sum_cb’ [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master a5fe54d: Preparation Host Flows: Syntax Line Edit (allow longer filter text),
Wireshark code review
- [Wireshark-commits] master 8055786: Fix bug with MVRP dissection where only one message was dissected.,
Wireshark code review
- [Wireshark-commits] master 5e3388f: GSM_map: Fix indent (use 2 spaces) and add modelines,
Wireshark code review
- [Wireshark-commits] master eeafab5: file-pcapng: always set pinfo->fd->num before calling next layer dissectors/file-pcapng,
Wireshark code review
- [Wireshark-commits] master 8d5ac86: Try to fix: wlan_statistics_dialog.cpp:466:1: error: unused parameter filter [-Werror=unused-parameter],
Wireshark code review
- [Wireshark-commits] master 7d59925: SSL: refine KEX handling and fix _anon KEX dissecting,
Wireshark code review
- [Wireshark-commits] master f73e1c2: Allow redefining all ports for RADIUS,
Wireshark code review
- [Wireshark-commits] master 30ce20d: [Expert] Enhance error output to identify the duplicated field.,
Wireshark code review
- [Wireshark-commits] master d097968: Make IPv6 extension header protocol names uniform and consistent with RFC 2460,
Wireshark code review
- [Wireshark-commits] master b5ca69b: Couchbase: dissect sub-document commands,
Wireshark code review
- [Wireshark-commits] master 856bab6: LWM: fix compilation without libgcrypt,
Wireshark code review
- [Wireshark-commits] master-1.12 65e5539: Generate Diameter's expert info's even when there's no tree so that they show up in the Expert Infos dialog.,
Wireshark code review
- [Wireshark-commits] master f8712ae: [Kerberos] Call to 'fseek()' without a check for a return value < 0, indicating failure.,
Wireshark code review
- [Wireshark-commits] master 69ec4a5: Add "ip.version" field to bogus IP for filter matching,
Wireshark code review
- [Wireshark-commits] master dd2a2d4: Multicast and wireless lan statistics fixups.,
Wireshark code review
- [Wireshark-commits] master d32c3da: Lua: check sscanf return value,
Wireshark code review
- [Wireshark-commits] master 95c8b01: [echld common] Call to fcntl() missing a test for a return value < 0, indicating failure.,
Wireshark code review
- [Wireshark-commits] master a66a95c: Add packet comments to the properties dialog.,
Wireshark code review
- [Wireshark-commits] master 74177d9: Statistics dialog fixups.,
Wireshark code review
- [Wireshark-commits] master 97014f6: OSPF database packets and OSPF hellos in DC mode are unicast. At least Cisco sends out these packets with a TTL of 1.,
Wireshark code review
- [Wireshark-commits] master ee80be6: Add the display filter macros dialog.,
Wireshark code review
- [Wireshark-commits] master c4fe712: Small cleanups and improvements Show the LSA type and length in the summary line Improve a message to make it clear when we are talking about a LLS TLV Add an expert item for LLS bit set but data block missing PI_MALFORMED is an error not a warning.,
Wireshark code review
- [Wireshark-commits] master 953cdd4: Print two reserved elements as reserved instead of skipping them,
Wireshark code review
- [Wireshark-commits] master 532070b: Add support for IPv6 stats tree statistics,
Wireshark code review
- [Wireshark-commits] master b0a8fa5: Initialize extcap for pipes,
Wireshark code review
- [Wireshark-commits] master 5a7f574: Fix two bugs 1) Introduced by me in commit c4fe7129d802752aa4cc89a66d2d5d5f2698e020 where I didn't honor the "print lsa header only" flag properly for data highlighting 2) Introduced in 2001 with commit dd1b7eafafb5748757a0396f4cc6ad6e65f37483 which moved offset increasing into an "if (tree)" statement with code after the if statement continuing to work with offset. Also make display of v2 and v3 LSAs the same again (forgot one case in previous commit.,
Wireshark code review
- [Wireshark-commits] master 0d61321: Correct logic for finding shadow variables.,
Wireshark code review
- [Wireshark-commits] master 9c331f7: [GTK] Fix crash in comparestat.c,
Wireshark code review
- [Wireshark-commits] master 15ed335: [CLI, GTK] comparestat: Fix typos, output format, argument parsing,
Wireshark code review
- [Wireshark-commits] master ebca184: Call the MCS field by its correct name.,
Wireshark code review
- [Wireshark-commits] master 2336743: Remove some svn $Author$ lines that escaped previous cleanups. git does keep of this in a much better way anyway.,
Wireshark code review
- [Wireshark-commits] master f95d459: OSPF: Fix indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master 89ff46e: [Automatic update for 2015-08-23],
Wireshark code review
- [Wireshark-commits] master-1.12 49610c5: [Automatic update for 2015-08-23],
Wireshark code review
- [Wireshark-commits] master cc7afd2: packet-mq: Add new Const/Def for WMQ800 FP3,
Wireshark code review
- [Wireshark-commits] master 3703b4e: Fix ip_try_dissect() boolean return,
Wireshark code review
- [Wireshark-commits] master 3ce60ed: dtls: do not try to add a zero-length fragment,
Wireshark code review
- [Wireshark-commits] master 0b03543: CBOR: add Concise Binary Object Representation (RFC 7049) dissector,
Wireshark code review
- [Wireshark-commits] master a451c60: Rename variable to avoid collisions with math.h's exp().,
Wireshark code review
- [Wireshark-commits] master fd68385: Use G_GINT64_MODIFIER, not l, in format strings for 64-bit integers.,
Wireshark code review
- [Wireshark-commits] master 6b9a628: Lua: remove unneeded todo comments,
Wireshark code review
- [Wireshark-commits] master 4f68c52: See if this makes MSVC happy.,
Wireshark code review
- [Wireshark-commits] master ce38df5: CBOR: get rid of INFINITY and NAN defines,
Wireshark code review
- [Wireshark-commits] master 5ed7a40: Don't assume we have interface information.,
Wireshark code review
- [Wireshark-commits] master 296b9cf: Add some symbols to wtap.h so that we can correctly support 802.11ad. Currently there are a lot of local hacks in the 802.11ad support and better support can be provided.,
Wireshark code review
- [Wireshark-commits] master 984f87a: Eliminate proto_tree_add_text from some dissectors,
Wireshark code review
- [Wireshark-commits] master 216f06b: Lua: Support deregister ProtoField with existing abbrev,
Wireshark code review
- [Wireshark-commits] master c6aeaad: Disable apply button while adding the filter,
Wireshark code review
- [Wireshark-commits] master 47c9aa4: Check if IPv6 payload length exceeds framing byte length,
Wireshark code review
- [Wireshark-commits] master 25ec198: Disable streamNumberSpinBox while reloading capture,
Wireshark code review
- [Wireshark-commits] master 7176958: Close packet dialogs when reload Lua plugins.,
Wireshark code review
- [Wireshark-commits] master bd553f6: Eliminate proto_tree_add_text from packet-q931.c and packet-q2931.c,
Wireshark code review
- [Wireshark-commits] master a2d8514: ip: fix ip.hdr_len filter value when the header length is too small,
Wireshark code review
- [Wireshark-commits] master 079dd03: Fixed typo in hfinfo_remove_from_gpa_name_map,
Wireshark code review
- [Wireshark-commits] master 7c0b8bd: [Q.2931] Don't use BASE_EXT_STRING for a value_string, fixes the test suite,
Wireshark code review
- [Wireshark-commits] master 517f4d4: cigi: don't THROW() an exception from a dissector,
Wireshark code review
- [Wireshark-commits] master a5b5c5a: fc: don't THROW() an exception from a dissector,
Wireshark code review
- [Wireshark-commits] master bc0d8d1: Remove space from field description for consistency,
Wireshark code review
- [Wireshark-commits] master d7e3076: IPv6 RPL: "cmprI" should be "cumprE",
Wireshark code review
- [Wireshark-commits] master-1.12 52dadc7: IPv6 RPL: "cmprI" should be "cumprE",
Wireshark code review
- [Wireshark-commits] master 7f60878: Add FOP 2.0 to the search list.,
Wireshark code review
- [Wireshark-commits] master 75d9167: Multicast Statistics (Qt Dialog): Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang,
Wireshark code review
- [Wireshark-commits] master fbadcdd: Add notes about using CMake + Qt Creator.,
Wireshark code review
- [Wireshark-commits] master 99dab82: Use signal to close packet dialogs,
Wireshark code review
- [Wireshark-commits] master 1874793: Remove unused signal,
Wireshark code review
- [Wireshark-commits] master b16cca4: Some beamforming stuff from 802.11ac.,
Wireshark code review
- [Wireshark-commits] master 662f4b2: Use one variable that was set but not previously used and delete another.,
Wireshark code review
- [Wireshark-commits] master 4ba5225: Point to GitHub for the pcapng specification.,
Wireshark code review
- [Wireshark-commits] master edeaae0: Remove the search back up the proto tree for the capture frequency that was being used to determine if we are dissecting 802.11ad in several places.,
Wireshark code review
- [Wireshark-commits] master e710f24: win32: update the list of NdisMedium and NdisPhysicalMedium defines used by GTK UI,
Wireshark code review
- [Wireshark-commits] master d5049ea: win32: add detection of Npcap to Windows installer,
Wireshark code review
- [Wireshark-commits] master-1.12 ce246a6: [GTK] Fix crash in comparestat.c,
Wireshark code review
- [Wireshark-commits] master 2af5783: Add more validity checks to the IPv6 dissector,
Wireshark code review
- [Wireshark-commits] master 31bf40e: [Camel] The tags used in EstablishTemporaryConnectionArg differs in V2 and V3 versions of Camel. Add ASN1 code for EstablishTemporaryConnectionArgV2,
Wireshark code review
- [Wireshark-commits] master cc15b11: Multicast Stream: Fix Dereference of null pointer found by Clang analyzer,
Wireshark code review
- [Wireshark-commits] master 571f254: Replace "IPv6 header length" with the more correct "payload length",
Wireshark code review
- [Wireshark-commits] master 0c291f9: Eliminate proto_tree_add_text from packet-sigcomp.c,
Wireshark code review
- [Wireshark-commits] master-1.12 d428732: win32: add detection of Npcap to Windows installer,
Wireshark code review
- [Wireshark-commits] master 8e55f68: Remove gitversion.h,
Wireshark code review
- [Wireshark-commits] master 0e952e6: SIGCOMP: fix sigcomp.copying_bytes_literally field,
Wireshark code review
- [Wireshark-commits] master 4fe661d: Get subset TVBs correctly.,
Wireshark code review
- [Wireshark-commits] master 5e45269: Explain why the MSDU length field in an A-MSDU is big-endian.,
Wireshark code review
- [Wireshark-commits] master-1.12 b4160d3: Get subset TVBs correctly.,
Wireshark code review
- [Wireshark-commits] master-1.12 b19b729: Explain why the MSDU length field in an A-MSDU is big-endian.,
Wireshark code review
- [Wireshark-commits] master 6b41d2c: Do not treat all unknown IP protocols as unknown IPv6 extension headers,
Wireshark code review
- [Wireshark-commits] master bd21889: Camel: fix indent (use 2 spaces),
Wireshark code review
- [Wireshark-commits] master c18d2f8: Qt SCTP: Changed prohibited APIs,
Wireshark code review
- [Wireshark-commits] master 57b2b77: cmake: rework version.h handling to treat it like config.h,
Wireshark code review
- [Wireshark-commits] master 8b4ff24: ieee80211: Qos Control bit4 handling: Make the default case as EOSP, to handle TDLS Packets.,
Wireshark code review
- [Wireshark-commits] master f7e9a79: Add per-dialog progress frames.,
Wireshark code review
- [Wireshark-commits] master e234ce8: Rework tapping in Qt dialogs.,
Wireshark code review
- [Wireshark-commits] master e1c807c: Add missing callback support.,
Wireshark code review
- [Wireshark-commits] master bc4487a: bootp/dhcp: tighten check for Alcatel extensions,
Wireshark code review
- [Wireshark-commits] master 7b35992: Reload IO Graph Y fields when reload Lua plugins,
Wireshark code review
- [Wireshark-commits] master 8ad5611: sv: remove some unnecessary checks,
Wireshark code review
- [Wireshark-commits] master 374439d: Don't emit app signals from dialogs.,
Wireshark code review
- [Wireshark-commits] master 0af048b: Remove calls of tvb_ensure_length_remaining.,
Wireshark code review
- [Wireshark-commits] master 2e1fa63: Lemon grammar: fix indent (use tabs),
Wireshark code review
- [Wireshark-commits] master 8384a5b: Qt: Fixed some memory leakages,
Wireshark code review
- [Wireshark-commits] master efba977: Qt: Fixed some memory leakages,
Wireshark code review
- [Wireshark-commits] master 6151946: Qt: Fixed some memory leakages,
Wireshark code review
- [Wireshark-commits] master e3a4188: RADIUS: Validation of response authenticators,
Wireshark code review
- [Wireshark-commits] master-1.12 f1c7cad: Make bit masks unsigned.,
Wireshark code review
- [Wireshark-commits] master 2ed634d: Support BER files bigger than 256kB,
Wireshark code review
- [Wireshark-commits] master 30c2f23: Eliminate proto_tree_add_text from some dissectors.,
Wireshark code review
- [Wireshark-commits] master 01fb470: More retapping fixups.,
Wireshark code review
- [Wireshark-commits] master f19a173: Speed up column sorting.,
Wireshark code review
- [Wireshark-commits] master a7f22aa: ISAKMP: Add new CHACHA20/POLY1305 Transform Types Values (RFC7634),
Wireshark code review
- [Wireshark-commits] master 5179406: Update the release notes.,
Wireshark code review
- [Wireshark-commits] master c04d54f: Preparation Host Flows: make ICMP(v6) code and type retrieval more robust,
Wireshark code review
- [Wireshark-commits] master 42570f9: Clean up scanning to guess the bitrate of an MPEG-2 Transport Stream file.,
Wireshark code review
- [Wireshark-commits] master da266af: Don't check the radio information when testing for an HT Control header.,
Wireshark code review
- [Wireshark-commits] master d767186: Get rid of trailing blanks.,
Wireshark code review
- [Wireshark-commits] master-1.12 f1ca841: Don't check the radio information when testing for an HT Control header.,
Wireshark code review
- [Wireshark-commits] master-1.12 06f4566: Get rid of now-unused variable.,
Wireshark code review
- [Wireshark-commits] master c1c6132: Don't dissect twice from TapParameterDialog.,
Wireshark code review
- [Wireshark-commits] master aa100e0: Don't show a progress frame if our file was closed.,
Wireshark code review
- [Wireshark-commits] master 4d71ae7: Have separate variables for read and write errors.,
Wireshark code review
- [Wireshark-commits] master 579365e: Disable most of the main window while we're tapping.,
Wireshark code review
- [Wireshark-commits] master 15c9923: Qt: Fix use-after-free pattern,
Wireshark code review
- [Wireshark-commits] master-1.12 8d0c841: Have separate variables for read and write errors.,
Wireshark code review
- [Wireshark-commits] master 1663224: Block sizes are unsigned 32-bit quantities; don't stuff them into an int.,
Wireshark code review
- [Wireshark-commits] master-1.12 33bc8d8: Block sizes are unsigned 32-bit quantities; don't stuff them into an int.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.7 x64,
buildbot-no-reply
- [Wireshark-commits] master-1.12 98320bb: Get rid of unused variable.,
Wireshark code review
- [Wireshark-commits] master e18e400: Fix a GHashTable assertion in DecodeAsDialog.,
Wireshark code review
- [Wireshark-commits] master e80bd2e: Added Reload Lua plugins to the release notes.,
Wireshark code review
- [Wireshark-commits] master 4ebf5b8: bootp/dhcp: fix Alcatel suboption detection bug,
Wireshark code review
- [Wireshark-commits] master 51e77b6: CBOR: fix no previous prototype for proto_reg*_cbor [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 0badc8c: Insure Qt Capture preferences dialog displays default capture device (if any),
Wireshark code review
- [Wireshark-commits] master 9158176: pcapng: make SPB cap_len the same as packet_len if IDB snaplen is 0,
Wireshark code review
- [Wireshark-commits] master-1.12 f1dc4dc: pcapng: make SPB cap_len the same as packet_len if IDB snaplen is 0,
Wireshark code review
- [Wireshark-commits] master 8ddd480: pcapng: do not byte-swap NRB IPv4 address,
Wireshark code review
- [Wireshark-commits] master-1.12 d00a628: pcapng: do not byte-swap NRB IPv4 address,
Wireshark code review
- [Wireshark-commits] master eacaa1a: 6LoWPAN: IPv6 Fragment Headers don't have a Length field,
Wireshark code review
- [Wireshark-commits] master 605f33c: pcapng: handle NRB with options,
Wireshark code review
- [Wireshark-commits] wireshark-win32-libs rev 468: / /trunk/packages/: lua-5.2.3_Win32_dll14_lib.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 419: / /trunk/packages/: lua-5.2.3_Win64_dll14_lib.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win32-libs rev 469: /tags/2015-08-29/,
pascal
- [Wireshark-commits] master-1.12 723f119: pcapng: handle NRB with options,
Wireshark code review
- [Wireshark-commits] wireshark-win64-libs rev 420: /trunk/trunk/,
pascal
- [Wireshark-commits] master 7791c6f: pcapng: drop count is unknown for ISB without isb_if_drop option,
Wireshark code review
- [Wireshark-commits] master-1.12 55ccc24: pcapng: drop count is unknown for ISB without isb_if_drop option,
Wireshark code review
- [Wireshark-commits] wireshark-win64-libs rev 421: /trunk/trunk/,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 422: /tags/2015-08-29/,
pascal
- [Wireshark-commits] master 6c06578: CBOR: fix definition of cbor.type.tag64 field,
Wireshark code review
- [Wireshark-commits] master e0a87d8: stanag4607: add check for wtap max size.,
Wireshark code review
- [Wireshark-commits] master faaa6f2: BGP: fixed incorrect NLRI decoding,
Wireshark code review
- [Wireshark-commits] master 99e16ce: [Automatic update for 2015-08-30],
Wireshark code review
- [Wireshark-commits] master-1.12 cef7a05: [Automatic update for 2015-08-30],
Wireshark code review
- [Wireshark-commits] master 00087b4: Add Lua 5.2.3 built with MSVC2015,
Wireshark code review
- [Wireshark-commits] master 78007fa: Add debug printing to tshark,
Wireshark code review
- [Wireshark-commits] master 81c6ecd: dlsw: remove unnecessary if (tree) checks,
Wireshark code review
- [Wireshark-commits] master f0b4e8e: dlsw: don't THROW() an exception from a dissector,
Wireshark code review
- [Wireshark-commits] master 053f53c: Add a hidden item that allows to allow filtering on the station address. This currently only works for data frames. A Fixme is in place for managment frames.,
Wireshark code review
- [Wireshark-commits] master a060183: Eliminate proto_tree_add_text from packet-rtps.c,
Wireshark code review
- [Wireshark-commits] master 3bec655: Redraw the packet list when name resolution changes.,
Wireshark code review
- [Wireshark-commits] wireshark-win32-libs rev 470: / /trunk/packages/: GeoIP-1.5.1-2-win32ws.zip GeoIP-1.6.6-win32ws.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win32-libs rev 471: /tags/2015-08-31/,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 423: / /trunk/packages/: GeoIP-1.5.1-2-win64ws.zip GeoIP-1.6.6-win64ws.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 424: /tags/2015-08-31/,
pascal
- [Wireshark-commits] master 75b8457: Add a Telephony→SCTP submenu.,
Wireshark code review
- [Wireshark-commits] master 026812c: Redraw timestamps when time display settings change.,
Wireshark code review
- [Wireshark-commits] master 7dd8349: NGHTTP2: Update to 1.3.0,
Wireshark code review
- [Wireshark-commits] master 4e236e6: Qt/Lua: Call atclose when TextWindow closes,
Wireshark code review
- [Wireshark-commits] master 1772416: tshark.pod: fix typo,
Wireshark code review
- [Wireshark-commits] master-1.12 ec275e1: tshark.pod: fix typo,
Wireshark code review
- [Wireshark-commits] master e9614ad: Windows: update GeoIP library to 1.6.6,
Wireshark code review
- [Wireshark-commits] master 377d215: Convert the MTP3 stats to new "generic stat API".,
Wireshark code review
Mail converted by MHonArc