URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df17ff3cac653eaf4a499ce5fd4cead59ada81a0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
df17ff3 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):
Qt: Fix use-after-free pattern
QString.toUtf8() returns a QByteArray object and .constData() returns
a pointer inside that object. It is not safe to store this pointer as
it will become invalid after the statement.
Change-Id: I8f54ede75577719008835038934e935cd5feba3f
Reviewed-on: https://code.wireshark.org/review/10067
Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 9e72779 Preparation Host Flows: Dissector Packet ICMP and ICMPv6
adds df17ff3 Qt: Fix use-after-free pattern
Summary of changes:
ui/qt/response_time_delay_dialog.cpp | 3 ++-
ui/qt/service_response_time_dialog.cpp | 3 ++-
ui/qt/simple_statistics_dialog.cpp | 3 ++-
ui/qt/stats_tree_dialog.cpp | 3 ++-
ui/qt/tap_parameter_dialog.cpp | 4 ++--
ui/qt/tap_parameter_dialog.h | 2 +-
6 files changed, 11 insertions(+), 7 deletions(-)