URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=412f5b3716bce91d1b26a82012e5c28a611d91da
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
412f5b3 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Expert information dialog performance improvements.
Inserting QTreeWidgetItems individually is slow. This isn't a problem if
you only have a few items but the Expert Information dialog can have
thousands. Add "packet" tree items in groups, which should be much
faster. Note that we still add "group" tree items individually since
that gives us a nice progress indicator.
While we're here, make sure we show the dialog before tapping packets.
Bug: 11439
Change-Id: I8a182f4158d078cae5f42b8d1355414197f423e1
Reviewed-on: https://code.wireshark.org/review/10000
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from bde416a Lua: Moved deregister out of wslua_cleanup
adds 412f5b3 Expert information dialog performance improvements.
Summary of changes:
ui/qt/expert_info_dialog.cpp | 34 +++++++++++++++++++++++-----------
ui/qt/expert_info_dialog.h | 5 +++--
ui/qt/expert_info_dialog.ui | 3 +++
3 files changed, 29 insertions(+), 13 deletions(-)