Wireshark-commits: [Wireshark-commits] master d20f2b6: [pdc] Fix a few [msvc-2015?] warnings about

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2015 20:52:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d20f2b64222c47abbfd71be0f3e6046b2315aeda
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d20f2b6 by Bill Meier (wmeier@xxxxxxxxxxx):

    [pdc] Fix a few [msvc-2015?] warnings about 'constant compared to constant'
    
    Essentially: Do the version checks at compile time using
                 #if statements (even though the compiler
                 probably optimized out the run time checks).
    
    Change-Id: I4879b39729ba5bd6b1c478ac43c107cb9fb445b3
    Reviewed-on: https://code.wireshark.org/review/10006
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  6ae8df4   [pdc] [msvc-2015] Change a variable type to prevent 32-bit MSVC-2015 "internal error"
    adds  d20f2b6   [pdc] Fix a few [msvc-2015?] warnings about 'constant compared to constant'


Summary of changes:
 epan/dissectors/packet-pdc.c |   81 ++++++++++++++++++++++++------------------
 1 file changed, 47 insertions(+), 34 deletions(-)