Wireshark-commits: [Wireshark-commits] master 517f4d4: cigi: don't THROW() an exception from a diss

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Aug 2015 10:48:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=517f4d4ffdea0047021a2a9593a3e9a6c36dae93
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

517f4d4 by Martin Kaiser (wireshark@xxxxxxxxx):

    cigi: don't THROW() an exception from a dissector
    
    stop the dissection instead and bring up an expert info in the main function
    
    Change-Id: I391bf821422ef8e6ae01849c88096e90e4295920
    Reviewed-on: https://code.wireshark.org/review/10221
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7c0b8bd   [Q.2931] Don't use BASE_EXT_STRING for a value_string, fixes the test suite
    adds  517f4d4   cigi: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-cigi.c |   69 ++++++++++++++++++++++++-----------------
 1 file changed, 41 insertions(+), 28 deletions(-)