Wireshark-commits: [Wireshark-commits] master 7c46b25: qt: fix scrollbar crash applying conv. filte

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 2 Aug 2015 18:57:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c46b25927fd7056532d78c2472e62f6078f7817
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7c46b25 by Evan Huus (eapache@xxxxxxxxx):

    qt: fix scrollbar crash applying conv. filter
    
    When applying a conversation filter via context menu on the packet list,
    something triggers the scrollbar to redraw when it has a maximum value of 0,
    leading to a div-by-0. Guard against that (for now) though there may be a better
    long-term fix.
    
    Change-Id: I5fa0cac3e67f50a6c603a6fa10b117de5540d444
    Reviewed-on: https://code.wireshark.org/review/9850
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  78ca0af   HTTP2: remove weak part of the heuristic
    adds  7c46b25   qt: fix scrollbar crash applying conv. filter


Summary of changes:
 ui/qt/packet_list.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)