Wireshark-commits: [Wireshark-commits] master c4b93e9: CMake: Fixup appending to WS_WIN_LIBS

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Aug 2015 19:56:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4b93e9496ff5ae159db29b8f5fddecb8db913cb
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c4b93e9 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Fixup appending to WS_WIN_LIBS
    
    In the world of CMake calling "set" with multiple values creates a
    semicolon-separated list. For WS_WIN_LIBS we want a single string so we
    need to call "set" with a single, quoted value.
    
    Change-Id: I96c5085af58adfb97ce16195eb27cc8ddb612d6a
    Reviewed-on: https://code.wireshark.org/review/10158
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  e67098c   Squelch recent display filter warnings.
    adds  c4b93e9   CMake: Fixup appending to WS_WIN_LIBS


Summary of changes:
 cmake/modules/UseWinLibs.cmake |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)