Wireshark-commits: [Wireshark-commits] master 8bf1237: MAC CTRL: fix dissection of PAUSE frame

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 5 Aug 2015 03:33:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8bf1237c1f5010674942dc941dca78ced9f224f9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8bf1237 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    MAC CTRL: fix dissection of PAUSE frame
    
    According to 802.3 table 31A-1, only opcodes from 0x0002 to 0x0006 have a timestamp
    While we are at it, rename the opcodes to a name matching the specification
    
    Bug: 11403
    Change-Id: Iaadc2b801e86523e962b4eb319541bc74de22071
    Reviewed-on: https://code.wireshark.org/review/9857
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ad4ab2a   Convert the GSM A stats to new "generic stat API".
    adds  8bf1237   MAC CTRL: fix dissection of PAUSE frame


Summary of changes:
 epan/dissectors/packet-maccontrol.c |   61 ++++++++++++++++++++++-------------
 1 file changed, 38 insertions(+), 23 deletions(-)