Wireshark-commits: [Wireshark-commits] master 2ef3cda: t124: kill evil global variables

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 9 Aug 2015 17:14:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ef3cdaeb0f6500e25cab029ec5eeb2ef7bcfccf
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2ef3cda by Evan Huus (eapache@xxxxxxxxx):

    t124: kill evil global variables
    
    Bug: 11430
    Change-Id: Ia4196ff693806dc1e20eae4075dda7dfe272c5b6
    Reviewed-on: https://code.wireshark.org/review/9941
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  b3207c0   zigbee: remove a numer of unnecessary if (tree) checks
    adds  2ef3cda   t124: kill evil global variables


Summary of changes:
 asn1/t124/packet-t124-template.c |    8 ++------
 asn1/t124/t124.cnf               |   14 +++++++-------
 epan/dissectors/packet-t124.c    |   30 +++++++++++++-----------------
 3 files changed, 22 insertions(+), 30 deletions(-)