Wireshark-commits: [Wireshark-commits] master 43c2e57: Don't try to decrypt the payload if it was c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2015 07:31:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43c2e5769a17f0945fdcdabe35204a13ca9bbc85
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

43c2e57 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't try to decrypt the payload if it was cut short by the snapshot length.
    
    It's not clear that the decryption code can handle an incomplete
    payload.  If it can, please fix this (bear in mind that you won't have
    all the MIC, and may not have *any* of the MIC, so...).
    
    Bug: 11389
    Change-Id: Ie863ddc5c4aa7fbf6cde317823a413d226a41c0d
    Reviewed-on: https://code.wireshark.org/review/9954
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3157114   Use the reported length where appropriate.
    adds  43c2e57   Don't try to decrypt the payload if it was cut short by the snapshot length.


Summary of changes:
 epan/dissectors/packet-zbee-security.c |   46 ++++++++++++++++++++++----------
 1 file changed, 32 insertions(+), 14 deletions(-)