Wireshark-commits: [Wireshark-commits] master acc0c14: Eliminate proto_tree_add_text from XMPP diss

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Aug 2015 04:05:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acc0c14e2f1e404feef3341a0cc76d250618ce24
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

acc0c14 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from XMPP dissectors.
    
    Change-Id: I32fdf085ef484d147d9f0b27c56efba41bb827bf
    Reviewed-on: https://code.wireshark.org/review/10086
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8fd7197   Lua: add FT_PROTOCOL as a ProtoField type
    adds  acc0c14   Eliminate proto_tree_add_text from XMPP dissectors.


Summary of changes:
 epan/dissectors/packet-xmpp-core.c  |    7 ++--
 epan/dissectors/packet-xmpp-gtalk.c |    7 ++--
 epan/dissectors/packet-xmpp-other.c |    5 +--
 epan/dissectors/packet-xmpp-utils.c |   17 ++++++----
 epan/dissectors/packet-xmpp-utils.h |    2 +-
 epan/dissectors/packet-xmpp.c       |   61 ++++++++++++++++++++++++++++++++++-
 epan/dissectors/packet-xmpp.h       |   11 +++++++
 7 files changed, 93 insertions(+), 17 deletions(-)