Wireshark-commits: [Wireshark-commits] master 4f68c52: See if this makes MSVC happy.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Aug 2015 18:38:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f68c52eda1c4b21027bcfbe13685740be2debac
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4f68c52 by Guy Harris (guy@xxxxxxxxxxxx):

    See if this makes MSVC happy.
    
    It's complaining about an "overflow in constant arithmetic".  Neither
    INFINITY nor NAN are specified by C90; C99 specifies that they are both
    floats.  Until recently, Microsoft had no interest in C99; if the
    version we're using supports C99's INFINITY and NAN, it should be OK to
    assign them to a variable (no "arithmetic" involved), so I'm guessing
    that the "arithmetic" in question is the use of conditional operators ?
    and :, so I'm writing it as an if statement instead.
    
    Change-Id: I532b9b5943be32e0897e4f03ac4e625ac41ee63b
    Reviewed-on: https://code.wireshark.org/review/10215
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6b9a628   Lua: remove unneeded todo comments
    adds  4f68c52   See if this makes MSVC happy.


Summary of changes:
 epan/dissectors/packet-cbor.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)