Wireshark-commits, February 2018
- [Wireshark-commits] master 66af843: bacapp: make sure to NUL terminate bf_arr.,
Wireshark code review
- [Wireshark-commits] master b14e32c: New dissector Session Multiplex Protocol SMP,
Wireshark code review
- [Wireshark-commits] master 0c7bbc7: Qt: Avoid a potentially large memdup.,
Wireshark code review
- [Wireshark-commits] master 40f0f68: TDS: ensure to always initialize tds_encoding_char even when protocol is unknown,
Wireshark code review
- [Wireshark-commits] master dd3b82e: oss-fuzzshark: test code to debug some oss-fuzz assert fails.,
Wireshark code review
- [Wireshark-commits] master d3e50fe: buffer: add g_assert to all functions.,
Wireshark code review
- [Wireshark-commits] master c84b0ae: Qt: More byte view and proto tree fixes.,
Wireshark code review
- [Wireshark-commits] master d4b5943: Qt: Always show the Plugins tab in the about box.,
Wireshark code review
- [Wireshark-commits] master 3f93c6e: json: Adjust whitespace,
Wireshark code review
- [Wireshark-commits] master d25e788: base64: Adjust whitespace for readability,
Wireshark code review
- [Wireshark-commits] master d1b1575: oss-fuzzshark: try to fix oss-fuzz assert fails.,
Wireshark code review
- [Wireshark-commits] master 142c035: Qt: Show Lua scripts as links in the about box.,
Wireshark code review
- [Wireshark-commits] master d7be846: Fix endianness of CAN-ETH CAN packet,
Wireshark code review
- [Wireshark-commits] master 5c511d2: RTP: ensure that bta2dp_info and btvdp_info are always initialized,
Wireshark code review
- [Wireshark-commits] master 4a41714: Fix memleak in color_filters_read_globals(),
Wireshark code review
- [Wireshark-commits] master 6adc755: Note that /guard:cf requires CMake 3.9 or newer.,
Wireshark code review
- [Wireshark-commits] master 8bf837e: Qt: Always update splash screen on action change,
Wireshark code review
- [Wireshark-commits] master dc86a28: SoupBinTCP: Remove try_conversation_dissector call,
Wireshark code review
- [Wireshark-commits] master 0fda778: Qt: Fix splash screen "Registering dissectors" message,
Wireshark code review
- [Wireshark-commits] master-2.4 bd9312e: Infiniband: Fix number of bytes exported if ip_cm_sid,
Wireshark code review
- [Wireshark-commits] master bec60fa: packet-mq: Add support for IMS+TM Struct,
Wireshark code review
- [Wireshark-commits] master 6c13f70: Qt: add initializers in PacketDialog() (CID: 1427679).,
Wireshark code review
- [Wireshark-commits] master c55974f: Qt: Add a missing HAVE_LUA guard,
Wireshark code review
- [Wireshark-commits] master 016e407: codex: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 45e7297: randpkt_core: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master d936854: fuzzshark: use SPDX identifier.,
Wireshark code review
- [Wireshark-commits] master e5f4ef0: ui: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master e52172c: Qt: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master d93db54: capchild: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 819b817: cli: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 8604242: Qt: Avoid divide-by-zero if missing AUTHORS file,
Wireshark code review
- [Wireshark-commits] master 5cb7a72: Increase PROTO_PRE_ALLOC_HF_FIELDS_MEM,
Wireshark code review
- [Wireshark-commits] master d8565d8: Qt: Keep auto-scroll when starting a new capture,
Wireshark code review
- [Wireshark-commits] master-2.4 24c648d: Qt: Keep auto-scroll when starting a new capture,
Wireshark code review
- [Wireshark-commits] master f244742: epl: fix map.title memleak.,
Wireshark code review
- [Wireshark-commits] master e3a7676: quic: fix secret memleaks.,
Wireshark code review
- [Wireshark-commits] master a4bb6c2: Make a deep copy of our filename in RecentFileStatus.,
Wireshark code review
- [Wireshark-commits] master 2d8606b: CIP Motion: Support Format Revision 3,
Wireshark code review
- [Wireshark-commits] master 2fecc96: dmp: fix memleaks,
Wireshark code review
- [Wireshark-commits] master d8551c4: Handle separate directories for libwireshark and libwiretap plugins.,
Wireshark code review
- [Wireshark-commits] master d5f52cf: Don't link wiretap plugins with libwireshark.,
Wireshark code review
- [Wireshark-commits] master ebb471f: Clean up addition of FT_IPv{4, 6} fields.,
Wireshark code review
- [Wireshark-commits] master-2.4 824bc65: Clean up addition of FT_IPv{4, 6} fields.,
Wireshark code review
- [Wireshark-commits] master 6fd1531: Add a comment explaining why err is volatile.,
Wireshark code review
- [Wireshark-commits] master 3d574a4: mqtt: Put msgid and topic in Info column,
Wireshark code review
- [Wireshark-commits] master 0c781ee: Disallow registration of some block type values for plugins.,
Wireshark code review
- [Wireshark-commits] master 656c426: Process all subdirectories of $pkgplugin as directories of plugins.,
Wireshark code review
- [Wireshark-commits] master ebef0b0: New symbols.,
Wireshark code review
- [Wireshark-commits] master 121abba: Have individual plugin CMakeLists.txt files add library dependencies.,
Wireshark code review
- [Wireshark-commits] master 2385ec8: Give an IDB and an NRB as examples of the third type of block.,
Wireshark code review
- [Wireshark-commits] master 676d466: Note that we should show ISBs in the "packet" list.,
Wireshark code review
- [Wireshark-commits] master c2debdd: Don't assume address data is aligned.,
Wireshark code review
- [Wireshark-commits] master ffc200a: [Automatic update for 2018-02-04],
Wireshark code review
- [Wireshark-commits] master-2.4 5e6ab46: [Automatic update for 2018-02-04],
Wireshark code review
- [Wireshark-commits] master-2.2 72b83ea: [Automatic update for 2018-02-04],
Wireshark code review
- [Wireshark-commits] master 3aff560: packet-mq: Fix problem in get_mq_pdu_len,
Wireshark code review
- [Wireshark-commits] master ad76b31: Don't install test programs (fuzzshark and dftest),
Wireshark code review
- [Wireshark-commits] master 551f6bd: MQ: keep extended value string array sorted,
Wireshark code review
- [Wireshark-commits] master d447467: MQ: use real string length when calling strip_trailing_blanks(),
Wireshark code review
- [Wireshark-commits] master bb2680d: Don't put knowledge about the "is this pcapng" test in the block-reading code.,
Wireshark code review
- [Wireshark-commits] master df088de: Docs: Make our AsciiDoc markup more compatible with AsciiDoctor.,
Wireshark code review
- [Wireshark-commits] master 7b169cd: Don't treat short reads as errors when checking the file type.,
Wireshark code review
- [Wireshark-commits] master a44eece: Check for read errors by checking for PCAPNG_BLOCK_ERROR.,
Wireshark code review
- [Wireshark-commits] master 444cac4: valid_but_empty_file is a Boolean, so declare it as such.,
Wireshark code review
- [Wireshark-commits] master dabb195: More AsciiDoc → Asciidoctor updates.,
Wireshark code review
- [Wireshark-commits] master f53750a: pcapng_read_section_header_block() should just return a Boolean.,
Wireshark code review
- [Wireshark-commits] master 8556f65: pcapng_read_block() should just return a Boolean.,
Wireshark code review
- [Wireshark-commits] master b812193: Have block read routines indicate whether the block should be returned.,
Wireshark code review
- [Wireshark-commits] master 90b3e72: Delete an out-of-date comment.,
Wireshark code review
- [Wireshark-commits] master 1d999de: Qt: Update recent status via a non-blocking connection.,
Wireshark code review
- [Wireshark-commits] master 80150df: Update couchbase dissector with new HELLO feature values,
Wireshark code review
- [Wireshark-commits] master 4adb67f: AsciiDoc: Convert some comments.,
Wireshark code review
- [Wireshark-commits] master e4a6383: Amend the comment with some background for the workaround.,
Wireshark code review
- [Wireshark-commits] master 0420088: Update couchbase dissector with collections and delete_time DCP,
Wireshark code review
- [Wireshark-commits] master 746511d: packet-mq: Fix a wrong offset+Add value in val_str,
Wireshark code review
- [Wireshark-commits] master 4f9f101: Speak of records, not packets.,
Wireshark code review
- [Wireshark-commits] master d4e9745: Don't assume records all have time stamps and captured lengths.,
Wireshark code review
- [Wireshark-commits] master 1bed075: WSUG: Minor edits.,
Wireshark code review
- [Wireshark-commits] master 5fcf5b9: Don't assume all packets have time stamps.,
Wireshark code review
- [Wireshark-commits] master 8ab3060: Thrift: stop dissection when encountering an unknown/unexpected type,
Wireshark code review
- [Wireshark-commits] master ab202ad: Proto tree: Update left arrow navigation behavior.,
Wireshark code review
- [Wireshark-commits] master dcfc574: IPMI: Add NULL pointer checks.,
Wireshark code review
- [Wireshark-commits] master 3ec8338: BACapp: Fix a loop check.,
Wireshark code review
- [Wireshark-commits] master ea7a5bd: Use separate dissectors for LAPD and LAPD-with-Linux-SLL-header.,
Wireshark code review
- [Wireshark-commits] master 3eb8784: Use the Wayback Machine for a reference.,
Wireshark code review
- [Wireshark-commits] master-2.4 57e218c: Thrift: stop dissection when encountering an unknown/unexpected type,
Wireshark code review
- [Wireshark-commits] master-2.2 c784d55: Thrift: stop dissection when encountering an unknown/unexpected type,
Wireshark code review
- [Wireshark-commits] master 41b571f: [Thrift] Add methods for the 64bit types.,
Wireshark code review
- [Wireshark-commits] master 64c32c6: [Thrift] Handle optional elememts in struct.,
Wireshark code review
- [Wireshark-commits] master e6c0f03: about_dialog (qt): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 3950163: [SBC-AP] Enhance info column information.,
Wireshark code review
- [Wireshark-commits] master 7e76e5f: Make sure we pass valid addresses to find_conversation.,
Wireshark code review
- [Wireshark-commits] master 6db88da: Change the way we infer the type of the physical address.,
Wireshark code review
- [Wireshark-commits] master cb1a652: Get rid of the pkt_encap field in struct packet_info.,
Wireshark code review
- [Wireshark-commits] master 5df9b1d: Build 2.5.0.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v2.5.0 created (now 7afc358),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-2.5.0 created (now c2efaa6),
Wireshark code review
- [Wireshark-commits] master 61cc769: Fix typo in DTN dissector,
Wireshark code review
- [Wireshark-commits] master 59e4311: Temporarily revert "Fix typo in DTN dissector",
Wireshark code review
- [Wireshark-commits] master c061522: 2.5.0 → 2.5.1.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v2.5.1rc0 created (now 4f37587),
Wireshark code review
- [Wireshark-commits] master fa76cd5: Reapply "Fix typo in DTN dissector",
Wireshark code review
- [Wireshark-commits] master f29baff: Don't assume all packets have time stamps.,
Wireshark code review
- [Wireshark-commits] master-2.4 15bb068: Don't assume all packets have time stamps.,
Wireshark code review
- [Wireshark-commits] master-2.4 81ccf4f: Don't assume all packets have time stamps.,
Wireshark code review
- [Wireshark-commits] master f4f44ca: FCP: Add NULL check to prevent crash.,
Wireshark code review
- [Wireshark-commits] master-2.4 af59431: FCP: Add NULL check to prevent crash.,
Wireshark code review
- [Wireshark-commits] master-2.2 b56f598: FCP: Add NULL check to prevent crash.,
Wireshark code review
- [Wireshark-commits] master 32ce1fd: Remove range_foreach_r from debian symbols,
Wireshark code review
- [Wireshark-commits] master b13678f: Added wmem_map_contains and wmem_map_lookup_extended,
Wireshark code review
- [Wireshark-commits] master 9beab2d: ieee1905: Fix the handling of AP Metric Queries.,
Wireshark code review
- [Wireshark-commits] master c4a6016: tools: add licenses to licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master 0fdbc5e: LPPe: use V1_0-20160714-C specification,
Wireshark code review
- [Wireshark-commits] master c1f37d2: tools: add files from wsutil and caputils to checklicense whitelist.,
Wireshark code review
- [Wireshark-commits] master 71844ed: wsutil: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master cd8c73a: Generate HTTP Referer statistics,
Wireshark code review
- [Wireshark-commits] master 782054c: [PFCP] Fixed order of bytes in UP Function Features IE,
Wireshark code review
- [Wireshark-commits] master 908e25d: caputils: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 40a533a: Move summary.[ch] to libui.,
Wireshark code review
- [Wireshark-commits] master 7ee8ead: Include as "ui/summary.h", as is done elsewhere.,
Wireshark code review
- [Wireshark-commits] master 28960d7: netmon: Initialize struct netmonrec_comment on alloc,
Wireshark code review
- [Wireshark-commits] master 2282447: wsutil: Allow NULL as profile name,
Wireshark code review
- [Wireshark-commits] master 80a1dd7: NSRPC: fix heuristic dissector,
Wireshark code review
- [Wireshark-commits] master-2.4 20c3af2: NSRPC: fix heuristic dissector,
Wireshark code review
- [Wireshark-commits] master 8ae0467: tools: Add SPDX MIT to licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master c0a0003: WSDG: Remove references to Windows XP and Vista.,
Wireshark code review
- [Wireshark-commits] master 32923b9: Don't crash if an IDB resolution value is too high.,
Wireshark code review
- [Wireshark-commits] master 62fc862: Squelch an rc warning.,
Wireshark code review
- [Wireshark-commits] master 600b84f: Clean up the null pointer check in profile_exists().,
Wireshark code review
- [Wireshark-commits] master 18bbdb4: Distinguish between "probably not pcapng" and "probably bad pcapng" errors.,
Wireshark code review
- [Wireshark-commits] master e5ac9e4: Get rid of a calculation whose result is not used.,
Wireshark code review
- [Wireshark-commits] master a0e7658: Get rid of unused structure member.,
Wireshark code review
- [Wireshark-commits] master 390e80e: Fix white space.,
Wireshark code review
- [Wireshark-commits] master 0f72198: Get rid of unneeded #includes.,
Wireshark code review
- [Wireshark-commits] master 58d5baf: Cleanup HTTP Referer tracking code and use less memory,
Wireshark code review
- [Wireshark-commits] master a56d9ba: json: Add for decode-as udp.port,
Wireshark code review
- [Wireshark-commits] master a2265f7: packet: Whitespace cleanup,
Wireshark code review
- [Wireshark-commits] master 8eed71f: tools: remake the indentation of licencecheck.pl.,
Wireshark code review
- [Wireshark-commits] master f814c40: tools: add new SPDX GPL format to licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master bfd2dbc: tools: remove garbage from licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master 8cd389e: replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.,
Wireshark code review
- [Wireshark-commits] master ec2d310: debian: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 16b07fa: writecap: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 1d6ce5a: QUIC: QUIC is not longer a ACRONYM,
Wireshark code review
- [Wireshark-commits] master 544f7a2: QUIC: remove draft-07 support,
Wireshark code review
- [Wireshark-commits] master 1a9c364: Get rid of no-longer-used variables.,
Wireshark code review
- [Wireshark-commits] master fc082fa: wmem: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 55c68ee: epan: use SPDX indentifiers.,
Wireshark code review
- [Wireshark-commits] master 41812f2: QUIC: Add initial draft-09 support,
Wireshark code review
- [Wireshark-commits] master 60c5ec6: CIP Safety: Add decode options for I/O Payloads,
Wireshark code review
- [Wireshark-commits] master e4c5efa: CIP: Highlight correct bytes in Req/Rsp processing,
Wireshark code review
- [Wireshark-commits] master 1f5f63f: Generalize wtap_pkthdr into a structure for packet and non-packet records.,
Wireshark code review
- [Wireshark-commits] master 9425d6e: Remove redundant members from wtap_syscall_header.,
Wireshark code review
- [Wireshark-commits] master-2.4 e14250a: Plug an (unlikely) leak.,
Wireshark code review
- [Wireshark-commits] master-2.2 b1cc8f1: Plug an (unlikely) leak.,
Wireshark code review
- [Wireshark-commits] master 228b122: Rename ft_specific_data to reflect what we're actually using it for.,
Wireshark code review
- [Wireshark-commits] master b511312: html2text: Skip some tags and add references.,
Wireshark code review
- [Wireshark-commits] master bd41b8e: RLC graph: fix zooming, both in normal case and when graph direction has been switched,
Wireshark code review
- [Wireshark-commits] master f73ae69: Do the maximum block size check in pcap_read_block().,
Wireshark code review
- [Wireshark-commits] master-2.4 52ac26f: Do the maximum block size check in pcap_read_block().,
Wireshark code review
- [Wireshark-commits] master-2.2 129e41f: Do the maximum block size check in pcap_read_block().,
Wireshark code review
- [Wireshark-commits] master 589aa90: pcap: Update link_type_vals,
Wireshark code review
- [Wireshark-commits] master-2.4 a7046ea: pcap: Update link_type_vals,
Wireshark code review
- [Wireshark-commits] master 12cc2ca: Update symbols lists.,
Wireshark code review
- [Wireshark-commits] master 99e645b: Do changes from Generalize wtap_pkthdr into a structure for packet and non-packet records for file_dlg_win32.c,
Wireshark code review
- [Wireshark-commits] master ff6e2fb: wslua: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master d2d1f79: plugins: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master a9733b5: tools: fix BSD license name in licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master 5a94c7d: epan: more SPDX convertions.,
Wireshark code review
- [Wireshark-commits] master be38102: caputils/tools: more SPDX convertions.,
Wireshark code review
- [Wireshark-commits] master 25d90cb: Put the preview-generation loop into a common routine.,
Wireshark code review
- [Wireshark-commits] master 794596d: Fix indentation.,
Wireshark code review
- [Wireshark-commits] master 9797f34: Move the merge_action_e enum to the Win32 file dialog source file.,
Wireshark code review
- [Wireshark-commits] master 0b649a0: Separately count all records and data records.,
Wireshark code review
- [Wireshark-commits] master 78b7da7: CMake: Don't shadow PROCESSOR_ARCHITECTURE.,
Wireshark code review
- [Wireshark-commits] master bfef57e: androiddump: Fix and simplify tcpdump capture,
Wireshark code review
- [Wireshark-commits] master 02a3056: androiddump: Fix non-blocking connect on Windows,
Wireshark code review
- [Wireshark-commits] master 6176441: radiotap: Add support for the EOF bit in the A-MPDU Status flags.,
Wireshark code review
- [Wireshark-commits] master 9ff64c8: musl: compile with musl libc,
Wireshark code review
- [Wireshark-commits] master d16308c: UDP: Heuristic dissector for conversation taking precedence,
Wireshark code review
- [Wireshark-commits] master aee743f: Write our NSIS installer to the build directory.,
Wireshark code review
- [Wireshark-commits] master 991974d: dct2000: avoid allocating/storing/freeing empty string,
Wireshark code review
- [Wireshark-commits] master fa25852: [Automatic update for 2018-02-11],
Wireshark code review
- [Wireshark-commits] master e438cf2: ieee80211: Fix reserved bit positions 18 & 19 when HE Support not set.,
Wireshark code review
- [Wireshark-commits] master-2.4 52089d5: [Automatic update for 2018-02-11],
Wireshark code review
- [Wireshark-commits] master-2.2 b83beed: [Automatic update for 2018-02-11],
Wireshark code review
- [Wireshark-commits] master 04df349: ModelHelperTreeItem: Rename appendChild -> prependChild,
Wireshark code review
- [Wireshark-commits] master 5a674d0: wslua: Convert more comment markup to Asciidoctor.,
Wireshark code review
- [Wireshark-commits] master 94a0f7c: Switch from AsciiDoc to Asciidoctor.,
Wireshark code review
- [Wireshark-commits] master 86376e8: Fix ASCIIDOCTORJ_OPTS.,
Wireshark code review
- [Wireshark-commits] master 4439219: Fix dist.,
Wireshark code review
- [Wireshark-commits] master 32ab834: SIGCOMP: use correct message length,
Wireshark code review
- [Wireshark-commits] master-2.2 0a2f323: SIGCOMP: use correct message length,
Wireshark code review
- [Wireshark-commits] master-2.4 29d920b: SIGCOMP: use correct message length,
Wireshark code review
- [Wireshark-commits] master 0c425e8: ceph: clear_address() to make sure to use initialized memory in set_address(),
Wireshark code review
- [Wireshark-commits] master 5e8391f: RPKI-Router: Sanity check length field to prevent infinite loop,
Wireshark code review
- [Wireshark-commits] master 620647a: SCCP: Use int datatype for offset to prevent infinite loops,
Wireshark code review
- [Wireshark-commits] master ba3cfb4: WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_element,
Wireshark code review
- [Wireshark-commits] master 0bd863a: packet-ipmi-picmg.c: Add NULL check in rq17.,
Wireshark code review
- [Wireshark-commits] master a958533: fuzzshark: disable protocol in fuzzer if it's used by other fuzzer.,
Wireshark code review
- [Wireshark-commits] master d2016c6: RPC Netlogon: do not leak memory each time a hash is generated,
Wireshark code review
- [Wireshark-commits] master ae91f43: Extract HKDF-Expand from TLS 1.3 dissector,
Wireshark code review
- [Wireshark-commits] master-2.4 2e83207: RPC Netlogon: do not leak memory each time a hash is generated,
Wireshark code review
- [Wireshark-commits] master-2.2 bd05a81: RPC Netlogon: do not leak memory each time a hash is generated,
Wireshark code review
- [Wireshark-commits] master 27b571e: NBAP: copy address in pinfo->pool,
Wireshark code review
- [Wireshark-commits] master-2.4 f82c54a: SCCP: Use int datatype for offset to prevent infinite loops,
Wireshark code review
- [Wireshark-commits] master-2.4 7be234d: RPKI-Router: Sanity check length field to prevent infinite loop,
Wireshark code review
- [Wireshark-commits] master-2.2 9e7695b: SCCP: Use int datatype for offset to prevent infinite loops,
Wireshark code review
- [Wireshark-commits] master-2.4 78af50f: WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_element,
Wireshark code review
- [Wireshark-commits] master-2.2 4f9199e: WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_element,
Wireshark code review
- [Wireshark-commits] master-2.2 72ed222: packet-ipmi-picmg.c: Add NULL check in rq17.,
Wireshark code review
- [Wireshark-commits] master-2.4 81216a1: packet-ipmi-picmg.c: Add NULL check in rq17.,
Wireshark code review
- [Wireshark-commits] master e9376e4: h225: Fix use after free.,
Wireshark code review
- [Wireshark-commits] master fe21963: dissectors: use SPDX identifiers.,
Wireshark code review
- [Wireshark-commits] master 3b940d2: [PFCP] Fixed a typo in Outer Header Creation IE,
Wireshark code review
- [Wireshark-commits] master 8ebbf99: Remove Lynx.,
Wireshark code review
- [Wireshark-commits] master 045c48e: html2text: Prefix lists with a bullet.,
Wireshark code review
- [Wireshark-commits] master 2cf6517: NBAP: Fix and enhance SIB parsing,
Wireshark code review
- [Wireshark-commits] master d1ce1ba: WMEM: Add strjoin routines.,
Wireshark code review
- [Wireshark-commits] master 9cc4a3b: CMake: Install the HTML guides.,
Wireshark code review
- [Wireshark-commits] master 0b1e354: Update couchbase dissector with 'flexible framing extras',
Wireshark code review
- [Wireshark-commits] master d2af016: IPv6: SLAAC ether address is 8 bytes,
Wireshark code review
- [Wireshark-commits] master-2.4 7cfff44: IPv6: SLAAC ether address is 8 bytes,
Wireshark code review
- [Wireshark-commits] master 7fd6abc: tools: remove extra spaces from licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master bc72f7c: data: Add option to uncompress compressed data,
Wireshark code review
- [Wireshark-commits] master 3db1c06: tools: fix zlib check in licensecheck.pl.,
Wireshark code review
- [Wireshark-commits] master 7650151: more SPDX convertions.,
Wireshark code review
- [Wireshark-commits] master bb9e26e: ssl: Add session ticket lifetime units in seconds,
Wireshark code review
- [Wireshark-commits] master d332507: Fix the "pointer to function that generates a label" values.,
Wireshark code review
- [Wireshark-commits] master 048c437: Asciidoctor macro fixups.,
Wireshark code review
- [Wireshark-commits] master feb8f6b: Make the DOCSIS dissector a built-in dissector.,
Wireshark code review
- [Wireshark-commits] master 9eee872: cms: Add support for RFC 4108,
Wireshark code review
- [Wireshark-commits] master 6a91094: Added dissector for Excentis DOCSIS31 XRA header. DLT 273. Builtin version.,
Wireshark code review
- [Wireshark-commits] master b4dc30c: ieee80211: Correct the actual bit positions of the reserved bits.,
Wireshark code review
- [Wireshark-commits] master c82abe4: Update the introductory comment.,
Wireshark code review
- [Wireshark-commits] master 8c81423: Add the Excentis XRA DOCSIS header dissector to CMake.,
Wireshark code review
- [Wireshark-commits] master af64331: Update symbol lists.,
Wireshark code review
- [Wireshark-commits] master 2bff4c1: XRA: protect against potential infinite loops and add protocol to release notes,
Wireshark code review
- [Wireshark-commits] master 621d149: OpenFlow: update openflow_version_values value_string,
Wireshark code review
- [Wireshark-commits] master 4904dd5: packet-mq: Code reformat,
Wireshark code review
- [Wireshark-commits] master 944e661: OpenFlow 1.5: add extra property length checks,
Wireshark code review
- [Wireshark-commits] master 6f2d4c2: Wix: Look for merge modules in %VCToolsRedistDir%.,
Wireshark code review
- [Wireshark-commits] master 3084125: Qt: Fix the filter expression toolbar layout.,
Wireshark code review
- [Wireshark-commits] master-2.4 52287e8: Qt: Fix the filter expression toolbar layout.,
Wireshark code review
- [Wireshark-commits] master-2.2 3c6e8ff: Qt: Fix the filter expression toolbar layout.,
Wireshark code review
- [Wireshark-commits] master a3e14cb: Debian: Update Build-Depends.,
Wireshark code review
- [Wireshark-commits] master f0db412: Convert coloring rules dialog to use model.,
Wireshark code review
- [Wireshark-commits] master 9198448: Qt: fix crash in packet dialog on changing selection,
Wireshark code review
- [Wireshark-commits] master-2.4 563989f: OpenFlow 1.5: add extra property length checks,
Wireshark code review
- [Wireshark-commits] master f7e9053: [nb_rtpmux] Register dissector by name.,
Wireshark code review
- [Wireshark-commits] master 6c00182: travis: add asciidoctor.,
Wireshark code review
- [Wireshark-commits] master 7da66f8: SIGCOMP: check operand offset when accessing UDVM memory,
Wireshark code review
- [Wireshark-commits] master-2.4 5173221: SIGCOMP: check operand offset when accessing UDVM memory,
Wireshark code review
- [Wireshark-commits] master-2.2 015e339: SIGCOMP: check operand offset when accessing UDVM memory,
Wireshark code review
- [Wireshark-commits] master bfedd74: CMake: Try to avoid Strawberry Perl's xsltproc.,
Wireshark code review
- [Wireshark-commits] master-2.4 c6c35d9: CMake: Try to avoid Strawberry Perl's xsltproc.,
Wireshark code review
- [Wireshark-commits] master-2.2 b1f0081: CMake: Try to avoid Strawberry Perl's xsltproc.,
Wireshark code review
- [Wireshark-commits] master-2.2 536650a: packet-ipmi-picmg.c: Fix a declaration.,
Wireshark code review
- [Wireshark-commits] master 2934683: Fix a typo in the I/O tests.,
Wireshark code review
- [Wireshark-commits] master 6325ceb: DCT2000: read new LTE MAC outheader values,
Wireshark code review
- [Wireshark-commits] master 010c73d: Disable warning C4267 in generated files.,
Wireshark code review
- [Wireshark-commits] master a660215: fuzzshark: disable reassembly for few protocols,
Wireshark code review
- [Wireshark-commits] master 7ae954c: steam-ihs: Add dissector for the Steam IHS Discovery Protocol,
Wireshark code review
- [Wireshark-commits] master d45bd7c: Move hkdf_extract to wsgcrypt.h,
Wireshark code review
- [Wireshark-commits] master 364d9a9: Look in %VCToolsRedistDir% for the VC++ redistributable.,
Wireshark code review
- [Wireshark-commits] master 11e0df5: Put some info into the INFO column,
Wireshark code review
- [Wireshark-commits] master a509405: Fix a case of copy - too little modify - paste,
Wireshark code review
- [Wireshark-commits] master 08754c3: Suppress more PortAudio + Win64 compiler warnings.,
Wireshark code review
- [Wireshark-commits] master b6bec7d: Treat most Lex-generated and all Lemon-generated files as clean.,
Wireshark code review
- [Wireshark-commits] master 8bc1c6e: Add DIAG_OFF_FLEX and DIAG_ON_FLEX for use in Flex scanners.,
Wireshark code review
- [Wireshark-commits] master 1b574b9: capchild: remove double free (found by clang).,
Wireshark code review
- [Wireshark-commits] master cfafb91: [Diameter] Gx Supported-Features AVP, List-ID 2,
Wireshark code review
- [Wireshark-commits] master 0967192: mac-lte: fix memory leak of mac_lte_msg3_cr_hash,
Wireshark code review
- [Wireshark-commits] master 72b57ac: Use DIAG_OFF_FLEX/DIAG_ON_FLEX more consistently.,
Wireshark code review
- [Wireshark-commits] master c881ee3: [PFCP] Added dissect function for User Plane Inactivity Timer IE,
Wireshark code review
- [Wireshark-commits] master 4a69d10: Squelch redundant declaration warnings.,
Wireshark code review
- [Wireshark-commits] master f4cd45f: Treat the text2pcap scanner as clean.,
Wireshark code review
- [Wireshark-commits] master 0ee6e43: Compile text2pcap with -Werror.,
Wireshark code review
- [Wireshark-commits] master a931f49: Update the release notes.,
Wireshark code review
- [Wireshark-commits] master eb6eee7: Don't treat radius_dict.l specially.,
Wireshark code review
- [Wireshark-commits] master 0ac5c79: Don't use GENERATED_CFLAGS on generated files, use AM_CFLAGS.,
Wireshark code review
- [Wireshark-commits] master 5f0d506: Use -Werror except for explicitly listed dirty dissectors.,
Wireshark code review
- [Wireshark-commits] master 459bd46: Don't have CLEAN_FILES variables for the "clean" source files.,
Wireshark code review
- [Wireshark-commits] master d0b9db8: Qt: Add separators between filter expression buttons.,
Wireshark code review
- [Wireshark-commits] master a9823dd: Qt: Replace the toolbar extension icon.,
Wireshark code review
- [Wireshark-commits] master 0fa1176: Add `-z http_ref, tree` to the tshark man page.,
Wireshark code review
- [Wireshark-commits] master 49e331c: Thread: use wider variables to prevent overflow and infinite loops,
Wireshark code review
- [Wireshark-commits] master 6be0444: Don't make separate libXXX_generated libraries.,
Wireshark code review
- [Wireshark-commits] master 306c1c8: ldap: Format text used in COL_INFO,
Wireshark code review
- [Wireshark-commits] master-2.4 8ad0c5b: Thread: use wider variables to prevent overflow and infinite loops,
Wireshark code review
- [Wireshark-commits] master-2.4 3dd7801: ldap: Format text used in COL_INFO,
Wireshark code review
- [Wireshark-commits] master f0393a5: wisun: Add EDFE support,
Wireshark code review
- [Wireshark-commits] master 5bf8da8: Fix casts.,
Wireshark code review
- [Wireshark-commits] master dc8bd7c: Fix argument list in comment.,
Wireshark code review
- [Wireshark-commits] master 8b9dfba: The CRC8 routines don't modify the buffer; make the pointers to it const.,
Wireshark code review
- [Wireshark-commits] master cd44312: No need to cast away constness.,
Wireshark code review
- [Wireshark-commits] master 86f2ff6: Yet Another Narrowing Warning to suppress.,
Wireshark code review
- [Wireshark-commits] master 397d32b: dcerpc_decode_as_change() doesn't need to change the old binding.,
Wireshark code review
- [Wireshark-commits] master 4fe4754: Use appropriate pointer types rather than guint8 *.,
Wireshark code review
- [Wireshark-commits] master 9826cde: Constify a bunch of pointers and some casts.,
Wireshark code review
- [Wireshark-commits] master 1c5d688: Qt: Another filter expression toolbar layout attempt.,
Wireshark code review
- [Wireshark-commits] master a14c6a8: Constify a pointer to squelch a warning.,
Wireshark code review
- [Wireshark-commits] master 92f3a0f: Don't gratuitously cast away constness.,
Wireshark code review
- [Wireshark-commits] master ef96c91: Put back casts needed for C++ compatibility.,
Wireshark code review
- [Wireshark-commits] master 23b8d11: Don't gratuitiously cast constness away.,
Wireshark code review
- [Wireshark-commits] master 55042dc: Don't gratuitiously cast constness away.,
Wireshark code review
- [Wireshark-commits] master 2530b75: Don't gratuitously cast away constness.,
Wireshark code review
- [Wireshark-commits] master 137da3f: Don't gratuitously cast away constness.,
Wireshark code review
- [Wireshark-commits] master 04704e2: Don't gratuitously cast away constness.,
Wireshark code review
- [Wireshark-commits] master 16348cb: Clean up missing-prototype warnings.,
Wireshark code review
- [Wireshark-commits] master e612579: Make all versions of add_unix_interface_ifinfo() static.,
Wireshark code review
- [Wireshark-commits] master cae52d2: Don't gratuitously cast away constness.,
Wireshark code review
- [Wireshark-commits] master 5d99feb: S7comm: fix range check to prevent infinite loop when upper bound is 255,
Wireshark code review
- [Wireshark-commits] master 38d784d: 6LoWPAN: break loop in case of unexpected loRHE type,
Wireshark code review
- [Wireshark-commits] master fcea720: Get rid of unnecessary casts.,
Wireshark code review
- [Wireshark-commits] master 632c626: [Automatic update for 2018-02-18],
Wireshark code review
- [Wireshark-commits] master-2.4 a509768: [Automatic update for 2018-02-18],
Wireshark code review
- [Wireshark-commits] master-2.2 0b13a23: [Automatic update for 2018-02-18],
Wireshark code review
- [Wireshark-commits] master aef93db: gitlab-ci: remove not working clang repos.,
Wireshark code review
- [Wireshark-commits] master-2.4 d24db8d: S7comm: fix range check to prevent infinite loop when upper bound is 255,
Wireshark code review
- [Wireshark-commits] master bee0435: DIS: fix Modulation paremter length,
Wireshark code review
- [Wireshark-commits] master-2.2 d8a0cbc: S7comm: fix range check to prevent infinite loop when upper bound is 255,
Wireshark code review
- [Wireshark-commits] master-2.4 c766c63: DIS: fix Modulation paremter length,
Wireshark code review
- [Wireshark-commits] master 95affa1: USB: Sanity check Darwin USB header to prevent infinite loop.,
Wireshark code review
- [Wireshark-commits] master b6328eb: DICOM: Prevent infinite loop (dissect_dcm_tag),
Wireshark code review
- [Wireshark-commits] master 8760999: LLTD: use wider variables to prevent overflow and infinite loops,
Wireshark code review
- [Wireshark-commits] master 47726ea: NBAP: check that DCH ID was initialized before using it,
Wireshark code review
- [Wireshark-commits] master d9d6106: ASN.1: update auto generated dissectors,
Wireshark code review
- [Wireshark-commits] master-2.4 f87bd6f: NBAP: check that DCH ID was initialized before using it,
Wireshark code review
- [Wireshark-commits] master 22dc113: Don't start command-line taps until we've opened a file or started capturing.,
Wireshark code review
- [Wireshark-commits] master da861e4: We don't do taps in rawshark, so there are no taps to start.,
Wireshark code review
- [Wireshark-commits] master 0347538: Don't start command-line taps until we've opened a file.,
Wireshark code review
- [Wireshark-commits] master e090683: TFshark requires a file to be specified.,
Wireshark code review
- [Wireshark-commits] master bd9d79f: marker: fix indentation.,
Wireshark code review
- [Wireshark-commits] master 44a6e2d: marker: return unused offset (found by clang).,
Wireshark code review
- [Wireshark-commits] master-2.2 a742125: LLTD: use wider variables to prevent overflow and infinite loops,
Wireshark code review
- [Wireshark-commits] master-2.4 dae750d: DICOM: Prevent infinite loop (dissect_dcm_tag),
Wireshark code review
- [Wireshark-commits] master-2.2 afc780e: DICOM: Prevent infinite loop (dissect_dcm_tag),
Wireshark code review
- [Wireshark-commits] master-2.4 293b999: LLTD: use wider variables to prevent overflow and infinite loops,
Wireshark code review
- [Wireshark-commits] master-2.4 69d0902: USB: Sanity check Darwin USB header to prevent infinite loop.,
Wireshark code review
- [Wireshark-commits] master ca7ac05: Fix some source headers, reformat SPDX license lines in comment block.,
Wireshark code review
- [Wireshark-commits] master f81f2c4: release-notes: Add 802.15.9, RFC 4108, and Wi-SUN FAN; sort new protocols list,
Wireshark code review
- [Wireshark-commits] master 6a0a56e: Note that -P can override -Q's suppression of packet output.,
Wireshark code review
- [Wireshark-commits] master c61b543: Get rid of more new_ prefixes for statistics functions and types.,
Wireshark code review
- [Wireshark-commits] master 042cfea: Qt: Use QFrames as separators in the filter expression toolbar.,
Wireshark code review
- [Wireshark-commits] master-2.2 bebd3a1: NBAP: check that DCH ID was initialized before using it,
Wireshark code review
- [Wireshark-commits] master dbb5c73: [PFCP] Added missing User Plane Inactivity Timer IE value_string,
Wireshark code review
- [Wireshark-commits] master 8da569b: WSDG: Update docbook info,
Wireshark code review
- [Wireshark-commits] master 70608ef: TWAMP: Handle short TWAMP-Test packets,
Wireshark code review
- [Wireshark-commits] master e2d5c53: Reorganize and expand the description section.,
Wireshark code review
- [Wireshark-commits] master cf2a29f: Check whether to do dissection after starting taps.,
Wireshark code review
- [Wireshark-commits] master e2fbca0: TWAMP: Try to reassemble Server-Greeting message,
Wireshark code review
- [Wireshark-commits] master 3576ca2: Remove eproto2sgml.,
Wireshark code review
- [Wireshark-commits] master a806389: RELOAD: Fix a length check.,
Wireshark code review
- [Wireshark-commits] master 5c0cf42: packet-thread: fix cast-align warning,
Wireshark code review
- [Wireshark-commits] master e4787a9: Don't use floating point to calculate 4^N, for integer N.,
Wireshark code review
- [Wireshark-commits] master dc6b9df: Define macros to calculate (2^N)^M, and use them in more places.,
Wireshark code review
- [Wireshark-commits] master a8ff133: Extract bits by shifting, not using exponentiation.,
Wireshark code review
- [Wireshark-commits] master 8a173c9: Clean up the way we handle the server recv->send duration.,
Wireshark code review
- [Wireshark-commits] master-2.4 72da9df: RELOAD: Fix a length check.,
Wireshark code review
- [Wireshark-commits] master-2.2 1ab0585: RELOAD: Fix a length check.,
Wireshark code review
- [Wireshark-commits] master 9140921: DOCSIS: Remove concatenated PDU dissection.,
Wireshark code review
- [Wireshark-commits] master-2.4 511a8b0: DOCSIS: Remove concatenated PDU dissection.,
Wireshark code review
- [Wireshark-commits] master a82621e: FT_FLOAT and FT_DOUBLE support BASE_UNIT_STRING, too.,
Wireshark code review
- [Wireshark-commits] master 0a8152c: Use ws.css in the release notes.,
Wireshark code review
- [Wireshark-commits] master 647e5b4: Use units for the server recv->send duration.,
Wireshark code review
- [Wireshark-commits] master fa1635f: ieee80211: fix preamble duration calculation,
Wireshark code review
- [Wireshark-commits] master f7c8f0c: snmp: add missing initializers in deep copies.,
Wireshark code review
- [Wireshark-commits] master 1044d56: Qt: Improve sorting of custom columns with multiple fields,
Wireshark code review
- [Wireshark-commits] master 224215c: Qt: Right justify custom columns with multiple fields,
Wireshark code review
- [Wireshark-commits] master fc9ee03: gitlab-ci: speed up the builds a little bit.,
Wireshark code review
- [Wireshark-commits] master-2.4 6d488ad: Qt: Right justify custom columns with multiple fields,
Wireshark code review
- [Wireshark-commits] master-2.4 b98b9be: docsis: Remove unused variable framelen,
Wireshark code review
- [Wireshark-commits] master d209fe6: pcapng: Free option_content on error,
Wireshark code review
- [Wireshark-commits] master 3366317: ieee80211: Remove obsolete assignments,
Wireshark code review
- [Wireshark-commits] master 4e857ad: Type casts without const lose constness.,
Wireshark code review
- [Wireshark-commits] master 209f770: Don't cast away constness.,
Wireshark code review
- [Wireshark-commits] master 442e06d: Don't gratuitously cast away constness.,
Wireshark code review
- [Wireshark-commits] master ba7657c: Cast away constness at the point where it can't be avoided.,
Wireshark code review
- [Wireshark-commits] master b00e7fc: Constify some method arguments, and don't cast away constness.,
Wireshark code review
- [Wireshark-commits] master 95cb454: Constify an argument, remove no-longer-necessary removal of constness.,
Wireshark code review
- [Wireshark-commits] master bc4e15b: Don't cast away constness.,
Wireshark code review
- [Wireshark-commits] master cb31f56: Don't cast away constness.,
Wireshark code review
- [Wireshark-commits] master e788fac: Squelch some casting-away-constness warnings.,
Wireshark code review
- [Wireshark-commits] master bc43d68: fuzzshark: don't fuzz udplite.,
Wireshark code review
- [Wireshark-commits] master c9a081c: Add a CheckPoint specific mac address,
Wireshark code review
- [Wireshark-commits] master 9c5803f: Airpdcap: Add length checks.,
Wireshark code review
- [Wireshark-commits] master-2.4 aef5100: BER: Add a length check.,
Wireshark code review
- [Wireshark-commits] master 2b74b5c: BER: Add a length check.,
Wireshark code review
- [Wireshark-commits] master 65aa59d: RPCoRDMA: Set an upper bound for our chunk size.,
Wireshark code review
- [Wireshark-commits] master dc1ab9f: Remove a casting-away-constness warning.,
Wireshark code review
- [Wireshark-commits] master 1c5e6a1: Eliminate another casting-away-constness warning.,
Wireshark code review
- [Wireshark-commits] master-2.2 157712b: BER: Add a length check.,
Wireshark code review
- [Wireshark-commits] master-2.4 2da2a36: RPCoRDMA: Set an upper bound for our chunk size.,
Wireshark code review
- [Wireshark-commits] master-2.2 bd63131: RPCoRDMA: Set an upper bound for our chunk size.,
Wireshark code review
- [Wireshark-commits] master 238550b: Make some arguments const, and remove casting-away of constness.,
Wireshark code review
- [Wireshark-commits] master d0b0724: tools: add git to optional pkgs in debian-setup script.,
Wireshark code review
- [Wireshark-commits] master 748ea16: Updated Wi-SUN dissector to latest specification.,
Wireshark code review
- [Wireshark-commits] master a888bf7: wisun: Small comment fix,
Wireshark code review
- [Wireshark-commits] master 9efce5c: Don't unnecessarily cast away constness.,
Wireshark code review
- [Wireshark-commits] master b96eba4: Bluetooth: HCI_EVT: implement LE Extended Advertising Report,
Wireshark code review
- [Wireshark-commits] master 62d34fc: Squelch some cating-away-constness warnings.,
Wireshark code review
- [Wireshark-commits] master-2.4 569fb1e: Airpdcap: Add length checks.,
Wireshark code review
- [Wireshark-commits] master-2.4 7bd8b5f: ieee80211: fix preamble duration calculation,
Wireshark code review
- [Wireshark-commits] master acb6781: TLS: allow QUIC dissector to pass HKDF label for ciphers,
Wireshark code review
- [Wireshark-commits] master 0a3c713: QUIC: Use new labels for decryption (draft-09).,
Wireshark code review
- [Wireshark-commits] master 566d20f: dfilter: use g_malloc0 to prevent uninitialized memory to be used.,
Wireshark code review
- [Wireshark-commits] master 9788199: [GSM A RR] RXLEV-SUB-SERVING-CELL displayed with wrong bitmask.,
Wireshark code review
- [Wireshark-commits] master 7055442: Fix detection of file type.,
Wireshark code review
- [Wireshark-commits] master-2.4 bdf3af9: Fix detection of file type.,
Wireshark code review
- [Wireshark-commits] master-2.2 54958be: Fix detection of file type.,
Wireshark code review
- [Wireshark-commits] master 4c9cb52: ftp: calculate bitrate of ft-data session,
Wireshark code review
- [Wireshark-commits] master 7802bbb: TWAMP: Avoid triggering an infinite recursion,
Wireshark code review
- [Wireshark-commits] master 95e33c7: dof: use g_malloc0 to prevent uninitialized memory (found by clang).,
Wireshark code review
- [Wireshark-commits] master 0161a5b: Don't strip debugging symbols from the binaries in the macOS image.,
Wireshark code review
- [Wireshark-commits] master-2.4 ecd2715: Don't strip debugging symbols from the binaries in the macOS image.,
Wireshark code review
- [Wireshark-commits] master-2.2 1689bf7: Don't strip debugging symbols from the binaries in the macOS image.,
Wireshark code review
- [Wireshark-commits] master 5aaf741: And systemd weighs in on how to find out the distribution you're on....,
Wireshark code review
- [Wireshark-commits] master 85bbda5: DMP: Recurse only once.,
Wireshark code review
- [Wireshark-commits] master-2.4 0de02ca: DMP: Recurse only once.,
Wireshark code review
- [Wireshark-commits] master-2.2 e8be5ad: DMP: Recurse only once.,
Wireshark code review
- [Wireshark-commits] master 5d45b69: WCCP: Make sure our offset increases.,
Wireshark code review
- [Wireshark-commits] master 2054242: Qt: Improve our capture filter completions.,
Wireshark code review
- [Wireshark-commits] master c76b378: FP: Fix U-RNTI issue in E-DCH,
Wireshark code review
- [Wireshark-commits] master-2.2 a2901dc: Airpdcap: Add length checks.,
Wireshark code review
- [Wireshark-commits] master b293c97: ieee80211: Start to dissect 80211ax trigger frames and other fields.,
Wireshark code review
- [Wireshark-commits] master b443d46: Qt+Windows: Adjust our DBAR check logic.,
Wireshark code review
- [Wireshark-commits] master-2.4 6210138: Qt+Windows: Adjust our DBAR check logic.,
Wireshark code review
- [Wireshark-commits] master 0f44950: radiotap: Fixes because the meaning of some fields changed.,
Wireshark code review
- [Wireshark-commits] master c95424a: packet-rsl: Add RLL UNITDATA INDICATION,
Wireshark code review
- [Wireshark-commits] master-2.4 31ef857: [GSM A RR] RXLEV-SUB-SERVING-CELL displayed with wrong bitmask.,
Wireshark code review
- [Wireshark-commits] master ba72f73: DIS: move modulation parameters to correct place in tree,
Wireshark code review
- [Wireshark-commits] master 1f95d39: rawshark(.c): fix parameter 'phdr' not found in the function declaration [-Wdocumentation],
Wireshark code review
- [Wireshark-commits] master 818b58d: TDS: Improve dissection of TDS5 responses.,
Wireshark code review
- [Wireshark-commits] master e510cee: Reenable ieee 802.3 encapsulation and small cleanups/updates,
Wireshark code review
- [Wireshark-commits] master e57ecf4: IEEE 802.11: fix build with gcc7,
Wireshark code review
- [Wireshark-commits] master 01e8f50: TWAMP: Fix packets changing type in wireshark GUI,
Wireshark code review
- [Wireshark-commits] master 032cb4b: Catapult DCT2000: Update sscanf patterns, and avoid calling if possible,
Wireshark code review
- [Wireshark-commits] master 2112490: nettrace: remove wrong frees (found by clang).,
Wireshark code review
- [Wireshark-commits] master ba58d62: Fix endianness.,
Wireshark code review
- [Wireshark-commits] master-2.4 caa6318: Fix endianness.,
Wireshark code review
- [Wireshark-commits] master-2.2 d89e7e5: Fix endianness.,
Wireshark code review
- [Wireshark-commits] master-2.4 0315ee1: WCCP: Make sure our offset increases.,
Wireshark code review
- [Wireshark-commits] master 05cd2b6: Update comments to reflect current reality.,
Wireshark code review
- [Wireshark-commits] master-2.2 f993b0e: WCCP: Make sure our offset increases.,
Wireshark code review
- [Wireshark-commits] master 2e139a1: SIGCOMP: Disable UDVM dissection and decompression.,
Wireshark code review
- [Wireshark-commits] master-2.4 44a295d: SIGCOMP: Disable UDVM dissection and decompression.,
Wireshark code review
- [Wireshark-commits] master-2.2 8eacd00: SIGCOMP: Disable UDVM dissection and decompression.,
Wireshark code review
- [Wireshark-commits] master eb2b8dd: Check for dependencies in all subdirectories of $pkglib and $pkgexec.,
Wireshark code review
- [Wireshark-commits] master-2.4 407b238: Check for dependencies in all subdirectories of $pkglib and $pkgexec.,
Wireshark code review
- [Wireshark-commits] master-2.2 6364b3b: Check for dependencies in all subdirectories of $pkglib and $pkgexec.,
Wireshark code review
- [Wireshark-commits] master 4c8c59c: csn1: fix indentation.,
Wireshark code review
- [Wireshark-commits] master 380381c: TWAMP: Reassemble only the Server-Greeting message,
Wireshark code review
- [Wireshark-commits] master f14f76d: dmp: Allow multiple SecurityCategories again,
Wireshark code review
- [Wireshark-commits] master 727c815: IPMI: Disable bus command dissection.,
Wireshark code review
- [Wireshark-commits] master-2.2 ed334fa: IPMI: Disable bus command dissection.,
Wireshark code review
- [Wireshark-commits] master-2.4 cb11168: IPMI: Disable bus command dissection.,
Wireshark code review
- [Wireshark-commits] master-2.4 b13af2a: Update the release notes for 2.4.5.,
Wireshark code review
- [Wireshark-commits] master-2.2 b6048cc: Update the release notes for 2.2.13.,
Wireshark code review
- [Wireshark-commits] master 9dcded6: Code-sign extcap binaries.,
Wireshark code review
- [Wireshark-commits] master-2.4 e30b6d7: Code-sign extcap binaries.,
Wireshark code review
- [Wireshark-commits] master-2.4 deaeaca: More 2.4.5 release note updates.,
Wireshark code review
- [Wireshark-commits] master-2.2 36632a2: More 2.2.13 release note updates.,
Wireshark code review
- [Wireshark-commits] master-2.4 d0373aa: dmp: Allow multiple SecurityCategories again,
Wireshark code review
- [Wireshark-commits] master 529bb04: Don't use find to find files to check for dependencies.,
Wireshark code review
- [Wireshark-commits] master-2.4 0e48d73: Don't use find to find files to check for dependencies.,
Wireshark code review
- [Wireshark-commits] master-2.2 26cec08: Qt: Another filter expression toolbar layout attempt.,
Wireshark code review
- [Wireshark-commits] master-2.4 974bfad: Qt: Another filter expression toolbar layout attempt.,
Wireshark code review
- [Wireshark-commits] master-2.2 504018d: Code-sign extcap binaries.,
Wireshark code review
- [Wireshark-commits] master-2.2 58e6809: Don't use find to find files to check for dependencies.,
Wireshark code review
- [Wireshark-commits] master 434d1c9: Remove a bunch of obsolete code.,
Wireshark code review
- [Wireshark-commits] master 316b858: Fix stripping of binaries.,
Wireshark code review
- [Wireshark-commits] master-2.4 5057322: Fix stripping of binaries.,
Wireshark code review
- [Wireshark-commits] master-2.2 7585207: Fix stripping of binaries.,
Wireshark code review
- [Wireshark-commits] master dfe22ab: Get rid of the -sdkroot option; it doesn't affect anything.,
Wireshark code review
- [Wireshark-commits] master-2.4 268fae4: Get rid of the -sdkroot option; it doesn't affect anything.,
Wireshark code review
- [Wireshark-commits] master-2.2 5e0e2b6: Get rid of the -sdkroot option; it doesn't affect anything.,
Wireshark code review
- [Wireshark-commits] master eb2e910: Remove more cruft.,
Wireshark code review
- [Wireshark-commits] master 4031e19: [PFCP] Improve SDF filter,
Wireshark code review
- [Wireshark-commits] master 06bb945: [PFCP] Improve SDF filter - part2,
Wireshark code review
- [Wireshark-commits] master e3fcac9: [PFCP] fix UL Gate bits in Gates Status,
Wireshark code review
- [Wireshark-commits] master 3a79b6f: [PFCP] Improve Traffic class field,
Wireshark code review
- [Wireshark-commits] master 51cd1db: [PFCP] fixed Unsigned32 in Time Threshold,
Wireshark code review
- [Wireshark-commits] master 1ccfef8: ans: remove unnecessary if (tree) checks,
Wireshark code review
- [Wireshark-commits] master 86f329a: LTE MAC: check direction and lcid before looking up msg3 table,
Wireshark code review
- [Wireshark-commits] master 017167f: Just use tvb_memeql() to check the signature.,
Wireshark code review
- [Wireshark-commits] master-2.4 e0aba0d: Just use tvb_memeql() to check the signature.,
Wireshark code review
- [Wireshark-commits] master 4d3b399: [PFCP] fixed DL Buffering Duration,
Wireshark code review
- [Wireshark-commits] master 9c11de6: wiretap: zero memory on allocation.,
Wireshark code review
- [Wireshark-commits] master 1248c65: mate: change strcmp in g_strcmp0 that supports NULL (found by clang).,
Wireshark code review
- [Wireshark-commits] master-2.2 1a32fc1: dmp: Allow multiple SecurityCategories again,
Wireshark code review
- [Wireshark-commits] master 794b1e7: RTSP: Dissector should create RTP conversation if only server port was negotiated,
Wireshark code review
- [Wireshark-commits] master 38425dd: QUIC (TLS): Remove support of draft < 08,
Wireshark code review
- [Wireshark-commits] master 24ba73c: [PFCP] fixed Timer IE,
Wireshark code review
- [Wireshark-commits] master a8ed879: Work around a duplicate dest mac that appears in *some* frames captured on a FEX,
Wireshark code review
- [Wireshark-commits] master-2.4 fc7cee5: Qt: Improve our capture filter completions.,
Wireshark code review
- [Wireshark-commits] master-2.2 4affe2d: Qt: Improve our capture filter completions.,
Wireshark code review
- [Wireshark-commits] master e3db7c5: I don't think ipmap.html belongs in the same directory as the binaries.,
Wireshark code review
- [Wireshark-commits] master-2.4 153e867: Build 2.4.5.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v2.4.5 created (now f7e5f0f),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-2.4.5 created (now 2a1e20f),
Wireshark code review
- [Wireshark-commits] master-2.2 aca4199: Build 2.2.13.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v2.2.13 created (now c61a610),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-2.2.13 created (now c1cefc7),
Wireshark code review
- [Wireshark-commits] master-2.4 5b1c9b7: 2.4.5 → 2.4.6.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v2.4.6rc0 created (now d7c839a),
Wireshark code review
- [Wireshark-commits] master-2.2 ae3bb73: 2.2.13 → 2.2.14.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v2.2.14rc0 created (now d9f204d),
Wireshark code review
- [Wireshark-commits] master-2.4 37c805c: I don't think ipmap.html belongs in the same directory as the binaries.,
Wireshark code review
- [Wireshark-commits] master-2.2 1a45265: I don't think ipmap.html belongs in the same directory as the binaries.,
Wireshark code review
- [Wireshark-commits] master 656439d: Clean up description of power and attenuation fields.,
Wireshark code review
- [Wireshark-commits] master-2.4 808c2d2: Clean up description of power and attenuation fields.,
Wireshark code review
- [Wireshark-commits] master-2.2 3d90e67: Clean up description of power and attenuation fields.,
Wireshark code review
- [Wireshark-commits] master 53744af: The DOCSIS dissector isn't a plugin any more, either.,
Wireshark code review
- [Wireshark-commits] master c3c053b: Get rid of the ipmap.html that got dropped into Contents/MacOS.,
Wireshark code review
- [Wireshark-commits] master-2.4 87ba413: Get rid of the ipmap.html that got dropped into Contents/MacOS.,
Wireshark code review
- [Wireshark-commits] master-2.2 38f11c1: Get rid of the ipmap.html that got dropped into Contents/MacOS.,
Wireshark code review
- [Wireshark-commits] master 6a2ec55: radiotap: Fix bug 14455.,
Wireshark code review
- [Wireshark-commits] master-2.4 b898117: radiotap: Fix bug 14455.,
Wireshark code review
- [Wireshark-commits] master-2.2 70f65aa: radiotap: Fix bug 14455.,
Wireshark code review
- [Wireshark-commits] master 6c7a5b4: Fix capitalization and white space.,
Wireshark code review
- [Wireshark-commits] master-2.4 e306fbd: Fix capitalization and white space.,
Wireshark code review
- [Wireshark-commits] master-2.2 00dffa8: Fix capitalization and white space.,
Wireshark code review
- [Wireshark-commits] master 3785f53: User Guide: add additional use category,
Wireshark code review
- [Wireshark-commits] master e73e358: Rename airpdcap to dot11decrypt.,
Wireshark code review
- [Wireshark-commits] master f07d295: TLS1.3: Add support of draft-24,
Wireshark code review
- [Wireshark-commits] master c0b2d82: Suppress some warnings caused by a Berkeley YACC bug/misfeature.,
Wireshark code review
- [Wireshark-commits] master c316799: TDS: Minor updates to TDS 5 Response token handling,
Wireshark code review
- [Wireshark-commits] master 852e337: IEEE 802.15.4: Rename ieee802154_payload_* to ieee802154_decrypt_*,
Wireshark code review
- [Wireshark-commits] master ee2bfbf: The parser is at the bottom, so the shadow warning must be turned off there.,
Wireshark code review
- [Wireshark-commits] master b3bc6dc: I don't see a need to treat ipmap.html specially.,
Wireshark code review
- [Wireshark-commits] master ec99b83: Add undefined ZigBee ZCL Basic cluster attribute.,
Wireshark code review
- [Wireshark-commits] master b4368e1: 802.11: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang,
Wireshark code review
- [Wireshark-commits] master ba4ff84: TDS: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 20d7254: Bootp: Adding some DHCP options,
Wireshark code review
- [Wireshark-commits] master d7e1970: [Automatic update for 2018-02-25],
Wireshark code review
- [Wireshark-commits] master-2.4 268e565: [Automatic update for 2018-02-25],
Wireshark code review
- [Wireshark-commits] master-2.2 800cefa: [Automatic update for 2018-02-25],
Wireshark code review
- [Wireshark-commits] master 6580e3f: isup fix duplicate entry,
Wireshark code review
- [Wireshark-commits] master a35592e: proto(.c): remove extra bracket,
Wireshark code review
- [Wireshark-commits] master a29d697: kerberos: fix duplicate entry,
Wireshark code review
- [Wireshark-commits] master 3fb9882: mq: fix duplicate entry,
Wireshark code review
- [Wireshark-commits] master 8b810d2: wisun: wisun remove unused ei_wisun_wsie_short_format,
Wireshark code review
- [Wireshark-commits] master 1585aa9: Docbook: Update our CSS.,
Wireshark code review
- [Wireshark-commits] master c1e5e6c: WSUG: Fixup some quotes and apostrophes.,
Wireshark code review
- [Wireshark-commits] master 331ffaf: WSUG: Fixup an apostrophe.,
Wireshark code review
- [Wireshark-commits] master 03718fe: zbee zcl se: fix duplicate entry,
Wireshark code review
- [Wireshark-commits] master f5cd52c: Docs: Reduce our TOC depth.,
Wireshark code review
- [Wireshark-commits] master 9e487bc: PDCP: trivial changes,
Wireshark code review
- [Wireshark-commits] master e9ffd03: wisun: support EAPOL Relay (1v21 format),
Wireshark code review
- [Wireshark-commits] master f220073: RTSP: Added support for pipelined RTSP responses,
Wireshark code review
- [Wireshark-commits] master be1c933: DNS: add partial DOH (DNS Queries over HTTPS) support,
Wireshark code review
- [Wireshark-commits] master 7fadcdb: [Diameter-3gpp] Add bit 8 in Access-Restriction-Data according to 3GPP TS 29.272 V15.2.0,
Wireshark code review
- [Wireshark-commits] master 73e9605: LACP: Begin adding more info to the INFO column,
Wireshark code review
- [Wireshark-commits] master 4303883: [NAS 5GS] Add dissector for NAS5GS 3GPP TS 24.501.,
Wireshark code review
- [Wireshark-commits] master ef0e841: [GTPv2] Add new IE UP Function Selection Indication Flags,
Wireshark code review
- [Wireshark-commits] master 74641da: adb: fix decoding of local-id argument of Write,
Wireshark code review
- [Wireshark-commits] master 12f8f43: NAS 5GS: Comment out unused variables.,
Wireshark code review
- [Wireshark-commits] master 7b3ce59: Dsymify binary files.,
Wireshark code review
- [Wireshark-commits] master 1c14988: Squelch some warning noise when dsymifying.,
Wireshark code review
- [Wireshark-commits] master 6b66e76: catapult dct2000: don't dump comments one char at a time, and other fussing,
Wireshark code review
- [Wireshark-commits] master 0976570: [PFCP] Fixed order of IPv4 and IPv6 in Remote GTP-U Peer IE,
Wireshark code review
- [Wireshark-commits] master 7dc9392: Add undefined ZigBee ZCL Power cluster attribute.,
Wireshark code review
- [Wireshark-commits] master c4521c2: [PFCP] fixed Graceful Release Period IE,
Wireshark code review
- [Wireshark-commits] master 0a113be: [PFCP] refactor flags and triggers,
Wireshark code review
- [Wireshark-commits] master f31bc46: Add ZigBee ZCL Identify cluster command.,
Wireshark code review
- [Wireshark-commits] master 629e688: rrc: check parameter when creating cipher info (found by clang).,
Wireshark code review
- [Wireshark-commits] master 21b4d6e: multipart: initialize value before function call (found by clang).,
Wireshark code review
- [Wireshark-commits] master 15c261e: ERF: Add support for new extension header and Provenance tags,
Wireshark code review
- [Wireshark-commits] master 5cbc09e: Qt: accept hexadecimal input in Decode As dialog,
Wireshark code review
- [Wireshark-commits] master 30692e2: Allow hexadecimal and octal numbers for tshark Decode As,
Wireshark code review
- [Wireshark-commits] master 61d0336: Qt/USB: Allow USB src/dst addresses to be selected for columns,
Wireshark code review
- [Wireshark-commits] master ba0f4b9: adb: fix Malformed packet while parsing CONNECT command,
Wireshark code review
- [Wireshark-commits] master 1653ea5: adb: fix buffer overflow while processing message payload,
Wireshark code review
- [Wireshark-commits] master 4314ac7: [XML] Add application/rs-metadata+xml,
Wireshark code review
- [Wireshark-commits] master b0328ae: wisun: extend EDFE display; fix Authenticator EUI-64 field name,
Wireshark code review
- [Wireshark-commits] master 9a512f7: lacp: remove unused assignments (found by clang).,
Wireshark code review
- [Wireshark-commits] master c7c0341: [NAS-5GS] Dissect more of the protocol.,
Wireshark code review
- [Wireshark-commits] master 8f4ea95: 6lowpan: Use correct offset for "UDP header compression" header,
Wireshark code review
- [Wireshark-commits] master-2.4 4ed90d4: 6lowpan: Use correct offset for "UDP header compression" header,
Wireshark code review
- [Wireshark-commits] master-2.2 58b0a02: 6lowpan: Use correct offset for "UDP header compression" header,
Wireshark code review
- [Wireshark-commits] master 32e99b3: CMake: Add more .PDBs to pdb_zip_package.,
Wireshark code review
- [Wireshark-commits] master 1055a6a: lacp: Info column and display filter rework,
Wireshark code review
- [Wireshark-commits] master 04c2cbc: [PFCP] more name changes,
Wireshark code review
- [Wireshark-commits] master 2024eb1: [PFCP] updated Measurement Information IE,
Wireshark code review
- [Wireshark-commits] master 7a79a60: [PFCP] updated Report Type IE,
Wireshark code review
- [Wireshark-commits] master bbb6bcb: rtspstat: use integer cast in g_hash_table.,
Wireshark code review
- [Wireshark-commits] master 7176b32: addr: Include trailing '\0' in length from ipv6_to_str(),
Wireshark code review
- [Wireshark-commits] master ac69a67: ieee80211: Fix the handling of PPE Thresholds for 802.11ax.,
Wireshark code review
- [Wireshark-commits] master d4ef22d: Make sure CAPACITY() doesn't shift the 1 out of range.,
Wireshark code review
- [Wireshark-commits] master 48a4ed1: Squelch some Visual Studio Code Analyzer warnings in Flex-generated scanners.,
Wireshark code review
- [Wireshark-commits] master 768488d: ieee80211: Fix handling of compressed block acks.,
Wireshark code review
- [Wireshark-commits] master fe363c5: Make sure GetModuleHandle(_T("kernel32.dll") succeeds.,
Wireshark code review
- [Wireshark-commits] master d023a7b: [PFCP] Name update of IEs,
Wireshark code review
- [Wireshark-commits] master faf6ee9: [PFCP] added Aggregated URRs IE,
Wireshark code review
- [Wireshark-commits] master eb15a1e: BGP: Heuristic for IPv6 NLRI path identifier,
Wireshark code review
- [Wireshark-commits] master d8e7372: GQUIC: Packet Number is now big endian,
Wireshark code review
- [Wireshark-commits] master 4170280: GQUIC: for item with length = 1, use ENC_NA for encoding,
Wireshark code review
- [Wireshark-commits] master 5488c29: GQUIC: Change all integers (and floating) encoding,
Wireshark code review
- [Wireshark-commits] master dfd0e65: GQUIC: Try to fix ACK frame with Q039,
Wireshark code review
- [Wireshark-commits] master 2db0957: tshark(.pod): fix spelling-error-in-manpage found by lintian,
Wireshark code review
- [Wireshark-commits] master-2.4 23c0a41: adb: fix buffer overflow while processing message payload,
Wireshark code review
- [Wireshark-commits] master-2.2 0290a62: adb: fix buffer overflow while processing message payload,
Wireshark code review
- [Wireshark-commits] master b8101ed: rrc: move allocation within if statement.,
Wireshark code review
- [Wireshark-commits] master b405a9f: rrc: remove unused function.,
Wireshark code review
- [Wireshark-commits] master 0fb3887: L16_mono: Add L16 monaural codec plugin as functional example,
Wireshark code review
- [Wireshark-commits] master 389a680: csn1: set pointer before using it (found by clang).,
Wireshark code review
- [Wireshark-commits] master 87dfaa7: 6LoWPAN: Less scary display if UDP checksum is elided,
Wireshark code review
- [Wireshark-commits] master 07bb8fc: dof: don't initialize nonce it is useless.,
Wireshark code review
- [Wireshark-commits] master 7eff18a: t38: allocate memory in pinfo pool scope.,
Wireshark code review
- [Wireshark-commits] master 9f2dff9: Include <config.h> so UNICODE is defined.,
Wireshark code review
- [Wireshark-commits] master-2.4 9a84ec4: Include <config.h> so UNICODE is defined.,
Wireshark code review
- [Wireshark-commits] master-2.2 2f5159a: Include <config.h> so UNICODE is defined.,
Wireshark code review
- [Wireshark-commits] master d11f43a: QUIC: Display GREASE version..,
Wireshark code review
- [Wireshark-commits] master 03474c1: Redo the way we choose N/S/E/W.,
Wireshark code review
- [Wireshark-commits] master-2.4 5f3608e: Redo the way we choose N/S/E/W.,
Wireshark code review
- [Wireshark-commits] master-2.2 3c08522: Redo the way we choose N/S/E/W.,
Wireshark code review
- [Wireshark-commits] master ea0b580: Fix a check.,
Wireshark code review
- [Wireshark-commits] master 16ac61e: Fix StringCchPrintf() calls.,
Wireshark code review
- [Wireshark-commits] master-2.4 7ca4559: Fix StringCchPrintf() calls.,
Wireshark code review
- [Wireshark-commits] master-2.2 261c345: Fix StringCchPrintf() calls.,
Wireshark code review
- [Wireshark-commits] master 9226ea8: flex: add also (-W)unreachable-code to ignore warning (for flex generate file),
Wireshark code review
- [Wireshark-commits] master 7df07eb: Print the right value for signed statistics tap table items.,
Wireshark code review
- [Wireshark-commits] master-2.4 ac925fd: Print the right value for signed statistics tap table items.,
Wireshark code review
- [Wireshark-commits] master 94d3f0a: [PFCP] added two more IEs,
Wireshark code review
- [Wireshark-commits] master 620f69a: mp4: limit the recursion depth for boxes,
Wireshark code review
- [Wireshark-commits] master-2.4 725af9c: BGP: Heuristic for IPv6 NLRI path identifier,
Wireshark code review
Mail converted by MHonArc