Wireshark-commits: [Wireshark-commits] master 8a173c9: Clean up the way we handle the server recv->

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Feb 2018 05:59:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a173c9812dd2396258012ddbd13c37ea9c61a18
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8a173c9 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up the way we handle the server recv->send duration.
    
    There's no guarantee that it'll be integral, and the spec doesn't seem
    to imply that it's necessarily integral, so don't convert it to an
    integer.
    
    Given that it's a floating-point number, we might as well represent it
    as an FT_DOUBLE.  (XXX - we should support units for FT_FLOAT and
    FT_DOUBLE.)
    
    Change-Id: Ica43510ac147231f5530359cc78bb467f8d3be24
    Reviewed-on: https://code.wireshark.org/review/25915
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a8ff133   Extract bits by shifting, not using exponentiation.
    adds  8a173c9   Clean up the way we handle the server recv->send duration.


Summary of changes:
 epan/dissectors/packet-couchbase.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)