URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c84b0aeead7cfaf595b546b99ff8bb73f73c8fc5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c84b0ae by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: More byte view and proto tree fixes.
47e1798762 broke byte view highlighting when selecting a proto tree
item. Switch back to emitting fieldSelected from selectionChanged. Force
a new selection in selectedFieldChanged, which does what we were trying
to do in 47e1798762.
Clear our marked byte offset in the byte view when we mark a field. Emit
byteSelected whenever we click the mouse.
Don't highlight anything when a tree item is deselected. Deselect a tree
item if we click on something that's not a byte in the byte view.
Change-Id: Ibf419ccb005d69f733b2fe12ce674e1fe504bb96
Reviewed-on: https://code.wireshark.org/review/25541
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d3e50fe buffer: add g_assert to all functions.
adds c84b0ae Qt: More byte view and proto tree fixes.
Summary of changes:
ui/qt/byte_view_tab.cpp | 46 ++++++++++++++++++++----------------
ui/qt/proto_tree.cpp | 50 ++++++++++++++++++++++++----------------
ui/qt/widgets/byte_view_text.cpp | 25 +++++++++++++++-----
3 files changed, 75 insertions(+), 46 deletions(-)