Wireshark-commits: [Wireshark-commits] master-2.4 44a295d: SIGCOMP: Disable UDVM dissection and dec

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Feb 2018 19:51:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44a295d16c0a951bb80919dff3cdfad88c142591
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

44a295d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    SIGCOMP: Disable UDVM dissection and decompression.
    
    This dissector has had multiple, severe issues over the years. Set the
    display.udvm.code and decomp.msg preferences to FALSE by default. Add
    warnings about re-enabling them.
    
    Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2
    Reviewed-on: https://code.wireshark.org/review/26002
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 2e139a15fab0206403e66abaf435456007cb5e1f)
    Reviewed-on: https://code.wireshark.org/review/26004
    

Actions performed:

    from  0315ee1   WCCP: Make sure our offset increases.
    adds  44a295d   SIGCOMP: Disable UDVM dissection and decompression.


Summary of changes:
 epan/dissectors/packet-sigcomp.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)