Wireshark-commits: [Wireshark-commits] master-2.4 511a8b0: DOCSIS: Remove concatenated PDU dissecti

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Feb 2018 06:20:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=511a8b0b546d25413e289dc5a7d3a455a33994c2
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

511a8b0 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    DOCSIS: Remove concatenated PDU dissection.
    
    The current concatenation PDU support has had serious, repeated problems
    over the years:
    
    fb1ef7b8da
    f6d48e45c8
    3e1828e351
    26a6881014
    625bab309d
    
    Remove it and add a comment recommending iteration.
    
    Bug: 14446
    Change-Id: I947ff8e40e18c4628c9df9233b72dd7776e8233d
    (cherry picked from commit 3b2fdfbc5818ad908d58eea03749a7083a15412a)
    Reviewed-on: https://code.wireshark.org/review/25906
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  72da9df   RELOAD: Fix a length check.
    adds  511a8b0   DOCSIS: Remove concatenated PDU dissection.


Summary of changes:
 plugins/docsis/packet-docsis.c | 81 ++++++++----------------------------------
 1 file changed, 15 insertions(+), 66 deletions(-)