Wireshark-commits: [Wireshark-commits] master-2.2 4f9199e: WCCP: Prevent very long loop in dissect_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Feb 2018 14:41:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f9199ea8cff56c6704e9828c3d80360b27c4565
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4f9199e by Michael Mann (mmann78@xxxxxxxxxxxx):

    WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_element
    
    Sanity check the total_length to make sure it doesn't go negative.
    
    Bug: 14412
    Change-Id: I87e38f6c792fa81184e4c412d6433fbbf2060f28
    Reviewed-on: https://code.wireshark.org/review/25744
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ba3cfb403a403647241062b933ff82808ac62a59)
    Reviewed-on: https://code.wireshark.org/review/25753
    

Actions performed:

    from  9e7695b   SCCP: Use int datatype for offset to prevent infinite loops
    adds  4f9199e   WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_element


Summary of changes:
 epan/dissectors/packet-wccp.c | 2 ++
 1 file changed, 2 insertions(+)