Wireshark-commits: [Wireshark-commits] master f53750a: pcapng_read_section_header_block() should ju

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 05 Feb 2018 03:13:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f53750ac930216b4fdbc3b16d6c8d0b340104c17
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f53750a by Guy Harris (guy@xxxxxxxxxxxx):

    pcapng_read_section_header_block() should just return a Boolean.
    
    It either returns "OK" or "fail", so we might as well make it a Boolean,
    just as is the case with read routines for other block types.
    
    Update some comments while we're at it.
    
    Change-Id: I40b378d4e3c3cfb96687298b22a6f8f9f78d9240
    Reviewed-on: https://code.wireshark.org/review/25607
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  dabb195   More AsciiDoc → Asciidoctor updates.
    adds  f53750a   pcapng_read_section_header_block() should just return a Boolean.


Summary of changes:
 wiretap/pcapng.c | 44 +++++++++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 19 deletions(-)