Wireshark-commits: [Wireshark-commits] master-2.4 7ca4559: Fix StringCchPrintf() calls.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Feb 2018 21:18:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ca4559b5f856ae464419f8fb4b335d5dc86c177
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

7ca4559 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix StringCchPrintf() calls.
    
    The calls were assuming that an LPARAM was 32 bits when that's not the
    case on 64-bit Windows - the underlying value is 32-bit, so we just cast
    to int.
    
    Change-Id: Ie2a38e27f2ea211628d2c751a7807bb9ed396c64
    Reviewed-on: https://code.wireshark.org/review/26190
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 16ac61e2a353fbf940cf8eeee9d5018ea2a12641)
    Reviewed-on: https://code.wireshark.org/review/26191
    

Actions performed:

    from  5f3608e   Redo the way we choose N/S/E/W.
    adds  7ca4559   Fix StringCchPrintf() calls.


Summary of changes:
 ui/win32/file_dlg_win32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)