Wireshark-commits: [Wireshark-commits] master-2.4 dae750d: DICOM: Prevent infinite loop (dissect_dc

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Feb 2018 22:48:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dae750dd50612b3efe29da497c2936b4478d7359
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

dae750d by Michael Mann (mmann78@xxxxxxxxxxxx):

    DICOM: Prevent infinite loop (dissect_dcm_tag)
    
    uint32 value could wrap around, resulting in infinite loop.
    
    Bug: 14411
    Change-Id: I26c73f74adc65c7a5acf22970a54c93a7f7a2344
    Reviewed-on: https://code.wireshark.org/review/25873
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit b6328eba6a3d33930489709ee1e47140dcc30dfb)
    Reviewed-on: https://code.wireshark.org/review/25876
    

Actions performed:

    from  f87bd6f   NBAP: check that DCH ID was initialized before using it
    adds  dae750d   DICOM: Prevent infinite loop (dissect_dcm_tag)


Summary of changes:
 epan/dissectors/packet-dcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)