Wireshark-commits: [Wireshark-commits] master 4a41714: Fix memleak in color_filters_read_globals()

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 01 Feb 2018 23:17:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a417149d42517037ee7a6c8aebc7b792f00260f
Submitter: Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a41714 by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    Fix memleak in color_filters_read_globals()
    
    Valgrind log:
    
    ==6102== Thread 1:
    ==6102== 32 bytes in 1 blocks are definitely lost in loss record 24,851 of 49,782
    ==6102==    at 0x4C29C4F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==6102==    by 0xB17B7F7: __vasprintf_chk (vasprintf_chk.c:80)
    ==6102==    by 0xA98C2AB: vasprintf (stdio2.h:210)
    ==6102==    by 0xA98C2AB: g_vasprintf (gprintf.c:316)
    ==6102==    by 0xA966DCC: g_strdup_vprintf (gstrfuncs.c:507)
    ==6102==    by 0xA966E88: g_strdup_printf (gstrfuncs.c:533)
    ==6102==    by 0x6A66B8C: color_filters_read_globals (color_filters.c:704)
    ==6102==    by 0x6A66FBE: color_filters_get (color_filters.c:317)
    ==6102==    by 0x402313: fuzz_init (fuzzshark.c:237)
    ==6102==    by 0x40252D: LLVMFuzzerInitialize (fuzzshark.c:322)
    ==6102==    by 0x401E33: main (StandaloneFuzzTargetMain.c:125)
    
    Change-Id: Ibc18edff6097eca736328810c903a151ddee22bc
    Reviewed-on: https://code.wireshark.org/review/25553
    Tested-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Petri-Dish: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    

Actions performed:

    from  5c511d2   RTP: ensure that bta2dp_info and btvdp_info are always initialized
    adds  4a41714   Fix memleak in color_filters_read_globals()


Summary of changes:
 epan/color_filters.c | 1 +
 1 file changed, 1 insertion(+)