Wireshark-commits: [Wireshark-commits] master 0347538: Don't start command-line taps until we've op

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Feb 2018 20:53:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0347538758f29b056c2e04959539bdc32f0291b6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0347538 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't start command-line taps until we've opened a file.
    
    We shouldn't do so until we have something on which to compute
    statistics and until we're in file scope, as the taps may use
    file-scoped memory, given that statistics pertain to a file.
    
    Change-Id: I08b6e5ed145d7a25056857cc570f383f5116d6ce
    Reviewed-on: https://code.wireshark.org/review/25889
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  da861e4   We don't do taps in rawshark, so there are no taps to start.
    adds  0347538   Don't start command-line taps until we've opened a file.


Summary of changes:
 tfshark.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)