Wireshark-commits, November 2014
- [Wireshark-commits] master 155fe6c: Set CXXFLAGS to include $VERSION_MIN_FLAGS.,
Wireshark code review
- [Wireshark-commits] master 1f0a68d: Missed cahnges from last commit: - Replace some deprecated APIs,
Wireshark code review
- [Wireshark-commits] master ea7c867: Bluetooth: Fix AVRCP UUID,
Wireshark code review
- [Wireshark-commits] master 6f3d91f: Qt: Fix build with Qt < 4.8,
Wireshark code review
- [Wireshark-commits] master 54ae596: Translations: Update Polish translation,
Wireshark code review
- [Wireshark-commits] master 6a37368: Validate no_of_bits in ws_sign_ext32 and ws_sign_ext64,
Wireshark code review
- [Wireshark-commits] master 74e8613: Don't check the checksum if we're encapsulated in an (ICMP) error packet.,
Wireshark code review
- [Wireshark-commits] master cfdd207: Qt: Limit the amount of Follow Stream text.,
Wireshark code review
- [Wireshark-commits] master 20bac9d: packet-mq: Use value_string_ext for big value string. more struct dissected,
Wireshark code review
- [Wireshark-commits] master a162f5b: DNS: fix display of A6 address suffix field,
Wireshark code review
- [Wireshark-commits] master-1.12 91d2b20: DNS: fix display of A6 address suffix field,
Wireshark code review
- [Wireshark-commits] master 070165c: Ethernet: fix a trivial typo,
Wireshark code review
- [Wireshark-commits] master 0af4395: Announce messages should only have a TLV if the message length is > 64.,
Wireshark code review
- [Wireshark-commits] master 5e40aa4: print: do not try to add an empty hex stream to PDML output for a text only hf,
Wireshark code review
- [Wireshark-commits] master-1.12 9a5aac5: print: do not try to add an empty hex stream to PDML output for a text only hf,
Wireshark code review
- [Wireshark-commits] master 2d8d217: DNS: fix dissection of ISDN RR Sub Address field,
Wireshark code review
- [Wireshark-commits] master-1.12 5b5024b: DNS: fix dissection of ISDN RR Sub Address field,
Wireshark code review
- [Wireshark-commits] master-1.10 89237e3: print: do not try to add an empty hex stream to PDML output for a text only hf,
Wireshark code review
- [Wireshark-commits] master-1.12 b04ca79: Announce messages should only have a TLV if the message length is > 64.,
Wireshark code review
- [Wireshark-commits] master-1.10 74eace1: Announce messages should only have a TLV if the message length is > 64.,
Wireshark code review
- [Wireshark-commits] master f8c3f15: WSUG: Convert ``Customizing'' to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master c49c775: Add identification of Windows (Server) 10,
Wireshark code review
- [Wireshark-commits] master f19c70c: DNS: fix Coverity CID 281285 and CID 1238867,
Wireshark code review
- [Wireshark-commits] master ba008bf: Eliminate proto_tree_add_text from several dissectors.,
Wireshark code review
- [Wireshark-commits] master 2899a6e: [Automatic manuf, services and enterprise-numbers update for 2014-11-02],
Wireshark code review
- [Wireshark-commits] master-1.12 353ec71: [Automatic manuf, services and enterprise-numbers update for 2014-11-02],
Wireshark code review
- [Wireshark-commits] master-1.10 182e0de: [Automatic manuf, services and enterprise-numbers update for 2014-11-02],
Wireshark code review
- [Wireshark-commits] master f1bdcd9: lzxpress: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 3f38631: fcels: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 232879a: gsm a dtap: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master f968017: RTPS: fix warning: no previous prototype for function ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 4f94c9e: Handle PackageMaker a bit better.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master 70cab47: Fix syntax, add a check for failure to find PackageMaker, make sure it's a file.,
Wireshark code review
- [Wireshark-commits] master 66e204f: Handle packagemaker being an ordinary command in /usr/bin.,
Wireshark code review
- [Wireshark-commits] master dab9c85: Fix syntax.,
Wireshark code review
- [Wireshark-commits] master 250c1ec: Fix typo: Intrustion -> Intrusion,
Wireshark code review
- [Wireshark-commits] master 179a9b5: new function proto_tree_get_parent_tree() it returns the parent tree of a given tree object,
Wireshark code review
- [Wireshark-commits] master bea8299: remove parent parameter from try_dissect_next_protocol(),
Wireshark code review
- [Wireshark-commits] master 7b4215d: [Radius] Update dictionaries from freeradius 3.0.4,
Wireshark code review
- [Wireshark-commits] master 1a2fcc5: Qt: fix a potential memory leak FollowStreamDialog::follow() found by Coverity (CID 1159304),
Wireshark code review
- [Wireshark-commits] master e4c257a: Qt: fix what seems to be a copy/paste error in MainWindow::loadWindowGeometry() (Coverity CID 1158563),
Wireshark code review
- [Wireshark-commits] master 9b37e1e: HPSW: fix neighbor MAC Address,
Wireshark code review
- [Wireshark-commits] master f3cc900: MIPv6: Mobility Header Link Layer Address is parsed incorrectly,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master 7613327: Comment out dictionary.rfc6929 dictionary.rfc6930 dictionary.rfc7155 dictionary.rfc7268 As they give errors in the test suit, something may have changed in the free rasdius syntax,,
Wireshark code review
- [Wireshark-commits] master bba77c3: tvb_length -> tvb_reported_length,
Wireshark code review
- [Wireshark-commits] master 7a78792: Don't use -msse4.2 with MSVC.,
Wireshark code review
- [Wireshark-commits] master f2269b4: Pass di to one more call to PIDL_dissect_uint8().,
Wireshark code review
- [Wireshark-commits] master-1.12 bc53f57: Pass di to one more call to PIDL_dissect_uint8().,
Wireshark code review
- [Wireshark-commits] master 0713d35: Make the compilation of PIDL produce the same results if the content hasn't changed,
Wireshark code review
- [Wireshark-commits] master 58a325e: Improve string delection in function ContainsString,
Wireshark code review
- [Wireshark-commits] master e0c7277: Handle the case when the DATA_TYPE is not a simple type,
Wireshark code review
- [Wireshark-commits] master 08a85b8: add a function to change the type of a hf_field,
Wireshark code review
- [Wireshark-commits] master 0139ac8: generate an error for the new Pipe type in typedef,
Wireshark code review
- [Wireshark-commits] master d993cdd: insure that we have an entire match for the variable name,
Wireshark code review
- [Wireshark-commits] master 26d4fb0: add definition for IPV4/IPV6 types,
Wireshark code review
- [Wireshark-commits] master 9299bf4: Remove casts, make some whitespace changes in generated code.,
Wireshark code review
- [Wireshark-commits] master 283b5cd: if the structure has the flag no_align then set also no_align in the dceprc_info structure,
Wireshark code review
- [Wireshark-commits] master 1119eb6: generate ALIGN_TO_x_BYTES instructions if the element has the align_x flag,
Wireshark code review
- [Wireshark-commits] master 6167673: Regenerate DCE RPC dissectors with the current pidl.,
Wireshark code review
- [Wireshark-commits] master 3b5cb2a: Update my e-mail address,
Wireshark code review
- [Wireshark-commits] master e2f2e18: Also ignore TAGS files in addition to the already ignored tags in .gitignore,
Wireshark code review
- [Wireshark-commits] master 15e78de: Lua: Register dissectors only once.,
Wireshark code review
- [Wireshark-commits] master 5025bc2: Qt: Dynamic languages,
Wireshark code review
- [Wireshark-commits] master e41f088: SWITCH_TYPE is not always defined, SwitchType() will try to find a fallback,
Wireshark code review
- [Wireshark-commits] master e38e828: Lua: Fix for register dissectors only once.,
Wireshark code review
- [Wireshark-commits] master c3c59dc: add the type dom_sid28 and call ad-hoc dissector,
Wireshark code review
- [Wireshark-commits] master 9ac261f: amqp: Fix a number of bugs in dissect_amqp_0_10_map().,
Wireshark code review
- [Wireshark-commits] master-1.12 924db97: amqp: Fix a number of bugs in dissect_amqp_0_10_map().,
Wireshark code review
- [Wireshark-commits] master-1.10 e369608: amqp: Fix a number of bugs in dissect_amqp_0_10_map().,
Wireshark code review
- [Wireshark-commits] master 6086885: Fix some compilation errors (size_t to guint/gint) and an unused parameter,
Wireshark code review
- [Wireshark-commits] master 8765fec: Ignore additional generated files:,
Wireshark code review
- [Wireshark-commits] master 89291ad: Follow a suggestion from libtoolize:,
Wireshark code review
- [Wireshark-commits] master 79e4da4: Fix compilation error on FreeBSD 10.0-RELEASE (with clang): change int8_t to gint.,
Wireshark code review
- [Wireshark-commits] master e65f581: Revert "Follow a suggestion from libtoolize:",
Wireshark code review
- [Wireshark-commits] master 196d7b4: Add the flag SVGs to the set of files we distribute.,
Wireshark code review
- [Wireshark-commits] master 78492d9: Cope with newer Xcode not having the 10.6 SDK.,
Wireshark code review
- [Wireshark-commits] master 6f3fc0e: Get rid of unused variable.,
Wireshark code review
- [Wireshark-commits] master cd93af0: Oops, we also need to worry about pcap_get_tstamp_precision().,
Wireshark code review
- [Wireshark-commits] master bfc5483: rpc: take a file-scope copy of some RPC procedures,
Wireshark code review
- [Wireshark-commits] master 2bd15c7: sigcomp-udvm: fix invalid access,
Wireshark code review
- [Wireshark-commits] master-1.12 254436c: sigcomp-udvm: fix invalid access,
Wireshark code review
- [Wireshark-commits] master aae48be: DNS: replace hash map by red-black tree to fix request/response tracking when transaction id is reused,
Wireshark code review
- [Wireshark-commits] master dfb5ddb: Show the bit-encoding into the (shared) 2-Byte value for fragment number and sequence number,
Wireshark code review
- [Wireshark-commits] master 6aee9b1: opensafety: Use 1<<10 (not 2^10) in a #define;,
Wireshark code review
- [Wireshark-commits] master e8d375c: mih: Fix some bugs; Add an XXX comment.,
Wireshark code review
- [Wireshark-commits] master-1.12 e6edcc0: mih: Fix some bugs; Add an XXX comment.,
Wireshark code review
- [Wireshark-commits] master-1.12 bad5f3f: mih: fix the previous patch (remove a left-over line),
Wireshark code review
- [Wireshark-commits] master-1.10 85018d7: mih: Fix some bugs; Add an XXX comment.,
Wireshark code review
- [Wireshark-commits] master 701f055: mih: tvb_length() --> tvb_reported_length(); Fix some boolean bitfield displays.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] master-1.12 4d27ddd: DNS: replace hash map by red-black tree to fix request/response tracking when transaction id is reused,
Wireshark code review
- [Wireshark-commits] master 85aa1bc: ws_mempbrk_sse42.c: remove inclusion of stdint.h as it's no more required after g79e4da4,
Wireshark code review
- [Wireshark-commits] master ce4be19: pim: BIDIR support (RFC 5015),
Wireshark code review
- [Wireshark-commits] master 1af7c2b: Qt: Simplify disabling entries in ContextMenu,
Wireshark code review
- [Wireshark-commits] master d2c0600: Make SSL certificates available to tshark as bytes via the dtls/ssl.handshake.certificate key.,
Wireshark code review
- [Wireshark-commits] master 547323b: Allow the environment variable RCC to set before running configure to allow for unusual paths for Qt's rcc program (FreeBSD ports puts it in /usr/local/lib/qt5/bin). This matches the existing functionality of the MOC and UIC variables/programs.,
Wireshark code review
- [Wireshark-commits] master 80b36cd: Fix plugin search path: It was relative instead of absolute, resulting in not found plugins (lib/wireshark/plugins/1.99.1).,
Wireshark code review
- [Wireshark-commits] master 55fb7ea: Enable some runtime sanity checks when using at least gcc 4.9,
Wireshark code review
- [Wireshark-commits] master ed7b9e6: nfs: fix open result_flags,
Wireshark code review
- [Wireshark-commits] master 5431032: nfs: label NFSv4 CREATE symlink arguments more helpfully,
Wireshark code review
- [Wireshark-commits] master 67c9ff0: nfs: interpret aclsupport attribute,
Wireshark code review
- [Wireshark-commits] master 060cc68: nfs: NFSv4.2 SEEK, ALLOCATE, DEALLOCATE support,
Wireshark code review
- [Wireshark-commits] master d0c031f: nfs: clean up fh_expire_type dissection,
Wireshark code review
- [Wireshark-commits] master c321dc3: rpc: fix regression in gbfc5483174d,
Wireshark code review
- [Wireshark-commits] master 3e34273: Lua: Fixed some memory leakages.,
Wireshark code review
- [Wireshark-commits] master bb05124: coap: fix a bug; do some cleanup.,
Wireshark code review
- [Wireshark-commits] master-1.12 6766ad6: coap: fix a bug;,
Wireshark code review
- [Wireshark-commits] master b479ab4: lbtrm: Use correct variable for outgoing_mc_address.,
Wireshark code review
- [Wireshark-commits] master-1.12 7063380: lbtrm: Use correct variable for outgoing_mc_address.,
Wireshark code review
- [Wireshark-commits] master-1.12 4575992: HPSW: fix neighbor MAC Address,
Wireshark code review
- [Wireshark-commits] master 883718c: Always process the expert info for the new open request message.,
Wireshark code review
- [Wireshark-commits] master 6e81b2d: BER: Fix offset and length of EOC in Sequence loop,
Wireshark code review
- [Wireshark-commits] master 0b9c5cd: Improve error message by including the (expected) class information,
Wireshark code review
- [Wireshark-commits] master 1c707b4: rtsp: Fixed a memory leakage.,
Wireshark code review
- [Wireshark-commits] master 255f1c0: mrcpv2: Fixed a memory leakage.,
Wireshark code review
- [Wireshark-commits] master 28e19b6: nfs: parse full setclientid CLID_INUSE reply,
Wireshark code review
- [Wireshark-commits] master 72c70b6: Call the default language preference setting "Use system setting".,
Wireshark code review
- [Wireshark-commits] master b5dead8: epl: Reassembly table fix,
Wireshark code review
- [Wireshark-commits] master 09cdfe8: Fix all remaining filter name errors found with checkfiltername.pl,
Wireshark code review
- [Wireshark-commits] master 43069c2: GTPv2: Update Indication with Octet 8 and 9 dissection.,
Wireshark code review
- [Wireshark-commits] master 14489d6: Fixed hf field blurb values after changes from change 5166,
Wireshark code review
- [Wireshark-commits] master de37217: DNS: fix name length and label count for a root server,
Wireshark code review
- [Wireshark-commits] master aec5ffb: DNS: WKS RR Protocol field is read as 4 bytes instead of 1,
Wireshark code review
- [Wireshark-commits] master-1.12 d0f0ebe: DNS: fix name length and label count for a root server,
Wireshark code review
- [Wireshark-commits] master 848e24e: dictionary: add missing TLV definition for WiMAX-Downlink-Granted-QoS,
Wireshark code review
- [Wireshark-commits] master 8f62bb7: amqp: handle potential overflows when dissecting amqp_0_10 PDUs;,
Wireshark code review
- [Wireshark-commits] master 3428e80: Don't forward-declare amqp_0_10_get_size_field(), as it no longer exists.,
Wireshark code review
- [Wireshark-commits] master-1.12 d12ab6a: tn5220: prevent another potential endless loop exit the loop if dissect_unknown_data() returns 0,
Wireshark code review
- [Wireshark-commits] master-1.10 7b6e578: tn5220: prevent another potential endless loop exit the loop if dissect_unknown_data() returns 0,
Wireshark code review
- [Wireshark-commits] master-1.10 034d98e: smb2: fully initialize dummy session,
Wireshark code review
- [Wireshark-commits] master-1.10 9a2e8ea: sigcomp-udvm: fix invalid access,
Wireshark code review
- [Wireshark-commits] master 48885cc: batadv: Add missing padding to batadv_unicast_4addr_v14,
Wireshark code review
- [Wireshark-commits] master-1.12 e4224aa: DNS: WKS RR Protocol field is read as 4 bytes instead of 1,
Wireshark code review
- [Wireshark-commits] master-1.12 69e9a65: [-1.12]amqp: handle potential overflows when dissecting amqp_0_10 PDUs,
Wireshark code review
- [Wireshark-commits] master 570df75: Add checkfiltername.pl to pre-commit script,
Wireshark code review
- [Wireshark-commits] master f82b2f2: remove parent parameter from dissect_usb_setup_request(),
Wireshark code review
- [Wireshark-commits] master 47909d3: remove parent parameter from dissect_usb_setup_response(),
Wireshark code review
- [Wireshark-commits] master 5844761: fix a crash in the endpoint dialogue,
Wireshark code review
- [Wireshark-commits] master bd5384c: fix a copy&paste mistake: type -> length,
Wireshark code review
- [Wireshark-commits] master 421913b: Create real subdissectors to the IGMP protocol.,
Wireshark code review
- [Wireshark-commits] master-1.10 c567c0e: amqp: Fix for crash reported in Bug 10582.,
Wireshark code review
- [Wireshark-commits] master ee1c74c: simple fix for bug 10676,
Wireshark code review
- [Wireshark-commits] master-1.10 b453723: simple fix for bug 10676,
Wireshark code review
- [Wireshark-commits] master-1.12 88f22d3: simple fix for bug 10676,
Wireshark code review
- [Wireshark-commits] master 79d3c33: simplify the while-loop in dissect_pmip6_opt_cr(),
Wireshark code review
- [Wireshark-commits] master ae61a41: BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Characterstring,
Wireshark code review
- [Wireshark-commits] master dea982b: PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master d094ca8: SNMP: Fix warning found by -Wunused-const-variable,
Wireshark code review
- [Wireshark-commits] master 5020856: Fix error: parameter 'XX' not found in the function declaration (-Wdocumentation),
Wireshark code review
- [Wireshark-commits] master 04aad36: Convert the Lua reference to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] master 8153cbc: Try to fix wsluarm dependency.,
Wireshark code review
- [Wireshark-commits] master f7ac077: Create a subdissector table for juniper payload protocols.,
Wireshark code review
- [Wireshark-commits] master 2dda088: [Automatic manuf, services and enterprise-numbers update for 2014-11-09],
Wireshark code review
- [Wireshark-commits] master-1.12 f2a6d7f: [Automatic manuf, services and enterprise-numbers update for 2014-11-09],
Wireshark code review
- [Wireshark-commits] master-1.10 7332098: [Automatic manuf, services and enterprise-numbers update for 2014-11-09],
Wireshark code review
- [Wireshark-commits] master d8a0757: WSUG: Convert ``Files'' to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] master f8f915c: WSUG: Convert ``Protocols'', ``Messages'', and ``How Wireshark Works'' to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] master b41f0c3: WSUG: Convert ``Troubleshooting'' to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] master c61df20: Restore a "ti" assignment that slightly altered dissection.,
Wireshark code review
- [Wireshark-commits] master 3924310: WSUG: Convert ``Command Line Tools'' to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] master 055e476: Add subdissector table for MPLS PW Associated Channel Type,
Wireshark code review
- [Wireshark-commits] master 6228930: Finish converting the User's Guide to AsciiDoc.,
Wireshark code review
- [Wireshark-commits] master cd5b402: Fix an include.,
Wireshark code review
- [Wireshark-commits] master 64b8759: Try to fix dist.,
Wireshark code review
- [Wireshark-commits] master d58567b: Fixed memory leakage in col_cleanup.,
Wireshark code review
- [Wireshark-commits] master ea16705: Improved deregistering fields.,
Wireshark code review
- [Wireshark-commits] master 0f758fa: WCCP: fix parsing of extended assignment data element,
Wireshark code review
- [Wireshark-commits] master-1.12 02640e6: WCCP: fix parsing of extended assignment data element,
Wireshark code review
- [Wireshark-commits] master 0f7aedc: Use correct offset and lenght for Choice EOC.,
Wireshark code review
- [Wireshark-commits] master bc990fc: USB: consider the device class when we try to select the next dissector,
Wireshark code review
- [Wireshark-commits] master c44ff77: amqp: Misc changes;,
Wireshark code review
- [Wireshark-commits] master afae2b6: Allow building under OSX Yosemite using cmake.,
Wireshark code review
- [Wireshark-commits] master b2c2deb: Fix a problem that causes build failures with CMake on Yosemite.,
Wireshark code review
- [Wireshark-commits] master-1.12 ca4adfc: Fix a problem that causes build failures with CMake on Yosemite.,
Wireshark code review
- [Wireshark-commits] master-1.10 323338e: Fix a problem that causes build failures with CMake on Yosemite.,
Wireshark code review
- [Wireshark-commits] master 7469fab: BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Status_Flags,
Wireshark code review
- [Wireshark-commits] master 8b5b0b3: Initial Harman HiQnet dissector,
Wireshark code review
- [Wireshark-commits] master 41cc80e: Hiqnet: fix typo lenght => length,
Wireshark code review
- [Wireshark-commits] master 0f4860b: Hiqnet: fix Mac OS X buildbot,
Wireshark code review
- [Wireshark-commits] master 7e2ede3: Hiqnet: fix warning found by fix-encoding-args tools,
Wireshark code review
- [Wireshark-commits] master bd9ff6b: Add tools for fix -Wdocumentation,
Wireshark code review
- [Wireshark-commits] master dfaaba8: hiqnet: Use correct filter names; Fix specification of hf_dhcp,
Wireshark code review
- [Wireshark-commits] master b1c91b0: Tools: Add fix_pragma_wdocumentation to UNKNOWN licence,
Wireshark code review
- [Wireshark-commits] master feedcb0: [Radius] Make dictionary.starent.vsa1 the default dictionary. at least with the trace in Bug 10688 that makes the most sense.,
Wireshark code review
- [Wireshark-commits] master 2f3e577: [GTP] Fix decoding of UMTS GTP QoS Profile i n Radius and Diameter messages. Fixes Bug 10688,
Wireshark code review
- [Wireshark-commits] master ea5b234: Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up with gcc 4.8.3.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test,
buildbot-no-reply
- [Wireshark-commits] master cfd71d7: Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up on the OSX 10.5 buildbot.,
Wireshark code review
- [Wireshark-commits] master 219cf30: Fix SMPP timestamp decoding when the current date/time's offset to UTC is different from the timestamp's offset to UTC.,
Wireshark code review
- [Wireshark-commits] master f2d94e1: PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 2043c9d: Updates in it translation.,
Wireshark code review
- [Wireshark-commits] master 63cf939: ADB: fix warning: no newline at end of file [-Wnewline-eof],
Wireshark code review
- [Wireshark-commits] master 54aea45: [Art-Net] - The heuristic chek was missing "e" out of "Art-Net\0" - tvb_length() - tvb_captured_length(),
Wireshark code review
- [Wireshark-commits] master-1.12 3150650: Fix SMPP timestamp decoding when the current date/time's offset to UTC is different from the timestamp's offset to UTC.,
Wireshark code review
- [Wireshark-commits] master-1.12 898fa22: Build 1.12.2.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.2 created (now 72e99a6),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.12.2 created (now f076c5b),
Wireshark code review
- [Wireshark-commits] master-1.10 1a5c8ab: Build 1.10.11.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.10.11 created (now 55ab4b2),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.10.11 created (now 61ffe4b),
Wireshark code review
- [Wireshark-commits] master-1.12 ae21ba2: 1.12.2 → 1.12.3.,
Wireshark code review
- [Wireshark-commits] master-1.10 f78220c: 1.10.11 → 1.10.12.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.10.12rc0 created (now 89b7156),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.12.3rc0 created (now cacd9d3),
Wireshark code review
- [Wireshark-commits] master ae1630d: Fix warning: no previous prototype for function ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 6df5252: Add Decode As functionality for MPLS PW Associated Channel Type.,
Wireshark code review
- [Wireshark-commits] master f7d91bd: Qt: Flatten group boxes.,
Wireshark code review
- [Wireshark-commits] master f598fa8: Squelch a compiler warning.,
Wireshark code review
- [Wireshark-commits] master 0515087: Handle new vendors and changes to vendors differently.,
Wireshark code review
- [Wireshark-commits] master f8e24c9: Eliminate proto_tree_add_text for some dissectors.,
Wireshark code review
- [Wireshark-commits] master 17798bc: Handle duplicate attribute and TLV entries specially.,
Wireshark code review
- [Wireshark-commits] master d1ccc33: Add dissector table for sFlow header dissection.,
Wireshark code review
- [Wireshark-commits] master 67f86dd: Get rid of spaces before tabs.,
Wireshark code review
- [Wireshark-commits] master ab7f35d: hf_cc_loss is supposed to be a floating-point value, divided by 65535.,
Wireshark code review
- [Wireshark-commits] master-1.12 7f4d5c1: [GTP] Fix decoding of UMTS GTP QoS Profile i n Radius and Diameter messages. Fixes Bug 10688,
Wireshark code review
- [Wireshark-commits] master-1.12 5ccd58a: [Art-Net] - The heuristic chek was missing "e" out of "Art-Net\0" - tvb_length() - tvb_captured_length(),
Wireshark code review
- [Wireshark-commits] master 9cc9028: epl: Duplicated Frames,
Wireshark code review
- [Wireshark-commits] master 4cc4315: batadv: Add dissector support for batadv v15,
Wireshark code review
- [Wireshark-commits] master c2e090f: Dissector for elasticsearch protocol,
Wireshark code review
- [Wireshark-commits] master 4a7dd62: Always create a subtree for Mobility options, even if it doesn't have a specific dissection function.,
Wireshark code review
- [Wireshark-commits] master-1.10 77f9f66: Always create a subtree for Mobility options, even if it doesn't have a specific dissection function.,
Wireshark code review
- [Wireshark-commits] master-1.12 95c6a0d: Always create a subtree for Mobility options, even if it doesn't have a specific dissection function.,
Wireshark code review
- [Wireshark-commits] master 6e535a8: Multipath TCP checksum requires M flag set as well as enough option length.,
Wireshark code review
- [Wireshark-commits] master-1.10 6a9d923: Multipath TCP checksum requires M flag set as well as enough option length.,
Wireshark code review
- [Wireshark-commits] master-1.12 2f7262a: Multipath TCP checksum requires M flag set as well as enough option length.,
Wireshark code review
- [Wireshark-commits] master 2788df9: Gtk Utils: fix unknown command tag name 'parm'; did you mean 'param'? (-Wdocumentation),
Wireshark code review
- [Wireshark-commits] master 2986388: dtd_preparse : fix indent (Use tabs),
Wireshark code review
- [Wireshark-commits] master 6e44997: Bluetooth: AVDTP: Add possibility to force decode as APT-X,
Wireshark code review
- [Wireshark-commits] master 5a46f26: Bluetooth: AVRCP: Fix swappend SongPosition and SongLength,
Wireshark code review
- [Wireshark-commits] master 38218df: Bluetooth: AVRCP: Improve command/response trancing,
Wireshark code review
- [Wireshark-commits] master 6d678ff: Qt: Fix typo,
Wireshark code review
- [Wireshark-commits] master ad1977b: Qt: Fix non-translate-able text,
Wireshark code review
- [Wireshark-commits] master f1dee59: Bluetooth: A2DP: Add AVRCP song position indicator,
Wireshark code review
- [Wireshark-commits] master f172791: Translations: Update Polish translation,
Wireshark code review
- [Wireshark-commits] master e83c7f0: NAS EPS: fix dissection of APN AMBR IE when first byte is set to 0xFE,
Wireshark code review
- [Wireshark-commits] master-1.12 f320526: NAS EPS: fix dissection of APN AMBR IE when first byte is set to 0xFE,
Wireshark code review
- [Wireshark-commits] master 9952e7c: [BSSMAP] Handle vendor specific encoding of "Layer 3 Message Contents".,
Wireshark code review
- [Wireshark-commits] master d7cc141: Bluetooth: Ubertooth: Update to the latest firmware,
Wireshark code review
- [Wireshark-commits] master-1.10 e7b38d7: NAS EPS: fix dissection of APN AMBR IE when first byte is set to 0xFE,
Wireshark code review
- [Wireshark-commits] master d6f2392: Fix declaration in btavrcp,
Wireshark code review
- [Wireshark-commits] master 56fa29e: [S1AP] Let the A21 dissector do further dissection of Cdma2000SectorID,
Wireshark code review
- [Wireshark-commits] master 9a1df71: [S1AP) Wrong tree used s1ap.cnf:547:14: error: variable 'subtree' set but not used,
Wireshark code review
- [Wireshark-commits] master a55d18e: hiqnet: Simplify code somewhat; Adjust the "names" and display of certain fields.,
Wireshark code review
- [Wireshark-commits] master 09f0d2c: hiqnet: Improve dissection for hiqnet over TCP or UDP,
Wireshark code review
- [Wireshark-commits] master 7390516: For tap UIs, register a list of parameters and some menu information.,
Wireshark code review
- [Wireshark-commits] master 0e64efc: Use G_GUINT64_FORMAT to format a guint64.,
Wireshark code review
- [Wireshark-commits] master a21436e: tap_ui -> stat_tap_ui.,
Wireshark code review
- [Wireshark-commits] master 0dae81b: Allow SCTP graphs to resize with the window they're in.,
Wireshark code review
- [Wireshark-commits] master 4d3c4c4: Rename stat_cmd_args.[ch] to stat_tap_ui.[ch].,
Wireshark code review
- [Wireshark-commits] master c3582a6: There's nothing GTK+ about TShark.,
Wireshark code review
- [Wireshark-commits] master 42c6e57: Update my e-mail address again.,
Wireshark code review
- [Wireshark-commits] master 4729e13: Add an optional flag and a type for UUID parameters for stat taps.,
Wireshark code review
- [Wireshark-commits] master 04ab731: The registered -z parameter string shouldn't end with a comma.,
Wireshark code review
- [Wireshark-commits] master 99b6afb: Add a name field to tap_param, for use in error messages.,
Wireshark code review
- [Wireshark-commits] master 1b4d51e: Update Debian symbol files.,
Wireshark code review
- [Wireshark-commits] master 3554580: It's not missing, it's passed on.,
Wireshark code review
- [Wireshark-commits] [wireshark] branch lts-1.12.1 created (now 01b65bf),
Wireshark code review
- [Wireshark-commits] master 225c86f: Do the "-z help" processing separately, and do it for Wireshark as well.,
Wireshark code review
- [Wireshark-commits] master ba3bc1e: VoIP calls tap ID cleanup.,
Wireshark code review
- [Wireshark-commits] master 62fd2ac: Eliminate proto_tree_add_text from some plugin dissector files.,
Wireshark code review
- [Wireshark-commits] master 1e2a3dc: VoIP calls: Clean up tap registration and removal.,
Wireshark code review
- [Wireshark-commits] master 3275ba2: LLDP: Dissector for Hytec specific extensions added,
Wireshark code review
- [Wireshark-commits] master 3428361: Fix a pointer type.,
Wireshark code review
- [Wireshark-commits] master 0be9e7d: 0.0 is a double, 0.0f is a float.,
Wireshark code review
- [Wireshark-commits] master d550b17: VoIP calls: Use our tap offsets.,
Wireshark code review
- [Wireshark-commits] master 7f3f4a5: paquet-mq: Eliminiate proto_tree_add_text,
Wireshark code review
- [Wireshark-commits] master 51c5b7a: VoIP calls: Start separating common and GTK+-dependent code.,
Wireshark code review
- [Wireshark-commits] master 4960171: VoIP calls: Fixup whitespace.,
Wireshark code review
- [Wireshark-commits] master 3b8ed36: DNS: NAPTR RR Replacement Length is incorrect,
Wireshark code review
- [Wireshark-commits] master-1.12 05cb044: DNS: NAPTR RR Replacement Length is incorrect,
Wireshark code review
- [Wireshark-commits] master f92ed4d: Remove ipproto member of packet_info.,
Wireshark code review
- [Wireshark-commits] master d1696a6: "Bubble up" the use of pinfo->circuit_id and pinfo->ctype to make it more obvious where in used in hopes that it can be eliminated through passing dissector data (or methods other than using packet_info),
Wireshark code review
- [Wireshark-commits] master b12be84: Remove file_type_subtype member from packet_info.,
Wireshark code review
- [Wireshark-commits] master 7f7d566: btavdtp: Add missing break;,
Wireshark code review
- [Wireshark-commits] master 0cc6a7e: [Automatic manuf, services and enterprise-numbers update for 2014-11-16],
Wireshark code review
- [Wireshark-commits] master-1.12 baa5876: [Automatic manuf, services and enterprise-numbers update for 2014-11-16],
Wireshark code review
- [Wireshark-commits] master-1.10 8061eaf: [Automatic manuf, services and enterprise-numbers update for 2014-11-16],
Wireshark code review
- [Wireshark-commits] lts-1.12.1 e0349a8: tn5250: fix an endless loop, exit when offset is not incremented,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 5451012: ncp2222: initialize buffer in build_expert_data,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 6b8c5db: ncp2222: don't overflow buffer constructing string,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 9f8367d: sigcomp-udvm: fix invalid access,
Wireshark code review
- [Wireshark-commits] master 9f0fb57: RADIUS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master b867baf: BATMAN: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 7213ad5: rtp_stream: fix indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master 05acb67: mcast_stream: fix indent (use 4 spaces),
Wireshark code review
- [Wireshark-commits] master 7b558dd: Add unused-const-variable (enable by default on new clang release),
Wireshark code review
- [Wireshark-commits] lts-1.2.11 c15f686: Add some additional checks in SnifferDecompress().,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 170b563: tn5250: fix an endless loop, exit when offset is not incremented,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 4028d5b: ncp2222: initialize buffer in build_expert_data,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 b75179a: ncp2222: don't overflow buffer constructing string,
Wireshark code review
- [Wireshark-commits] master 08a9478: Fix a comment to reflect reality.,
Wireshark code review
- [Wireshark-commits] master 9d0085f: Make sure the NLPID appears in the protocol tree.,
Wireshark code review
- [Wireshark-commits] master e26e1dc: BATMAN: fix indent and encoding args,
Wireshark code review
- [Wireshark-commits] master cacbffe: PortableApps: ensure that the personal folder is set to the App directory,
Wireshark code review
- [Wireshark-commits] master 14bc6d8: Remove some ununused/unmatched <resources/> tags.,
Wireshark code review
- [Wireshark-commits] master 57b7227: Eliminate proto_tree_add_text by formatting field hf_opcua_ByteString in a few places.,
Wireshark code review
- [Wireshark-commits] master 25f950e: Add tshark -G dissector-tables to dump a list of dissector tables.,
Wireshark code review
- [Wireshark-commits] master f3f833c: display filter: the body of a range should only be a string, a field name or another range - not an unparsed element,
Wireshark code review
- [Wireshark-commits] master bea106c: Eliminate proto_tree_add_text,
Wireshark code review
- [Wireshark-commits] master 3815b14: E212: fix bytes highlighting when dissecting the high nibble variant,
Wireshark code review
- [Wireshark-commits] master 3ce0167: [BSSMAP] de_mid() used with wrong length.,
Wireshark code review
- [Wireshark-commits] master 82bb363: LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 4a86d62: Use ntoh24 instead of less readable and less correct code. Remove redundant / wrong comments. Add two small (helpful) comments :-),
Wireshark code review
- [Wireshark-commits] master 7a7a763: cmake: Avoide rebuilding the guides each and every time. Don't print the single file guides to stdout.,
Wireshark code review
- [Wireshark-commits] master da69b51: DECT: ensure that bfield_data buffer is always fully initiated,
Wireshark code review
- [Wireshark-commits] master-1.10 5deaeed: DECT: ensure that bfield_data buffer is always fully initiated,
Wireshark code review
- [Wireshark-commits] master-1.12 faecb94: DECT: ensure that bfield_data buffer is always fully initiated,
Wireshark code review
- [Wireshark-commits] master f4ad915: H248: Fix Dereference of null pointer found by Clang analyzer,
Wireshark code review
- [Wireshark-commits] master 4b63d9f: 802.11: Enhance Extenede Channel Switch Announcement,
Wireshark code review
- [Wireshark-commits] master 5c7c701: 802.11: Enhance Supported Operating Classes,
Wireshark code review
- [Wireshark-commits] master-1.12 ae51d10: voip_calls: Fix MTP3 & SUA taps.,
Wireshark code review
- [Wireshark-commits] master-1.10 4ca697c: voip_calls: Fix MTP3 & SUA taps.,
Wireshark code review
- [Wireshark-commits] master a07f081: voip_calls: Get rid of global variables.,
Wireshark code review
- [Wireshark-commits] master 1dec509: voip_calls: Move to ui.,
Wireshark code review
- [Wireshark-commits] master 36837a2: MIPv6: display Experimental Mobility Message Data as such,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 63b971c: sigcomp-udvm: fix invalid access,
Wireshark code review
- [Wireshark-commits] master c2f971d: Fix indentation.,
Wireshark code review
- [Wireshark-commits] master-1.12 0f5c6d4: MIPv6: display Experimental Mobility Message Data as such,
Wireshark code review
- [Wireshark-commits] master-1.10 462e7e2: MIPv6: display Experimental Mobility Message Data as such,
Wireshark code review
- [Wireshark-commits] master 4b96030: 802.11: Remove proto_tree_add_text,
Wireshark code review
- [Wireshark-commits] master e97d235: SPDY: do not try to access an uninitialized tvb,
Wireshark code review
- [Wireshark-commits] master-1.12 011219c: SPDY: do not try to access an uninitialized tvb,
Wireshark code review
- [Wireshark-commits] master 7cdfe52: Update Couchbase dissector:,
Wireshark code review
- [Wireshark-commits] lts-1.12.1 69875bf: packet-amqp.c: Temporary/preliminary fix for Bug #10582 (crash),
Wireshark code review
- [Wireshark-commits] master dc5b8f1: dissect TA(1),
Wireshark code review
- [Wireshark-commits] master cfa0e5f: voip_calls: Regression fixes.,
Wireshark code review
- [Wireshark-commits] master 39b0c2d: Wiretap: Added file_seek SEEK_END support.,
Wireshark code review
- [Wireshark-commits] master 61b0638: Remove Windows linker flags from the CMake link flags test as the test doesn't actually pass the flags to the VS linker.,
Wireshark code review
- [Wireshark-commits] master c62dac1: Eliminate proto_tree_add_text from packet-mate.c,
Wireshark code review
- [Wireshark-commits] master d7179ac: Fix the length reported as value length.,
Wireshark code review
- [Wireshark-commits] master 67ab27a: Add support for PAD chunks.,
Wireshark code review
- [Wireshark-commits] master cb090e8: [pedantic] Replace usage of 'long' and 'long long',
Wireshark code review
- [Wireshark-commits] master 06dc2a7: voip_calls: Fix tap callbacks.,
Wireshark code review
- [Wireshark-commits] master 4fdabdc: SBC: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master d23247e: White space tweaking to match what's in Samba git.,
Wireshark code review
- [Wireshark-commits] master 087518b: MIP6: Access network identifier option is not full decoded,
Wireshark code review
- [Wireshark-commits] master 6fbcc18: Fix text logcat for changes in android L,
Wireshark code review
- [Wireshark-commits] master bcc4c7f: Fix global plugin folder when it is set as an absolute path,
Wireshark code review
- [Wireshark-commits] master f7f19f0: IrDA: always initialize buffer before accessing it,
Wireshark code review
- [Wireshark-commits] master ead585f: Give better hints as to where the "expert info" fields go.,
Wireshark code review
- [Wireshark-commits] master-1.12 ae68a3b: IrDA: always initialize buffer before accessing it,
Wireshark code review
- [Wireshark-commits] master-1.10 dea2fd7: IrDA: always initialize buffer before accessing it,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master 9145acb: uat: tighten up dec/hex uat field validity checking,
Wireshark code review
- [Wireshark-commits] master 9611e75: Replace tvb_length...() calls.,
Wireshark code review
- [Wireshark-commits] master e77261f: Eliminate proto_tree_add_text from some dissectors.,
Wireshark code review
- [Wireshark-commits] master 5e932ad: EPL: fix warning: no previous prototype for function ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 9732398: A21: fix warning: no previous prototype for function ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master 1df0d9c: Include "ws_symbol_export.h" to make sure WS_DLL_PUBLIC is defined.,
Wireshark code review
- [Wireshark-commits] master 1b9dd75: Fix the build: dissect_a21_ie_common() can't be static any more.,
Wireshark code review
- [Wireshark-commits] master 1d8673c: Move text logcat regex strings to shared header,
Wireshark code review
- [Wireshark-commits] master 1cde318: Fix for very big pid and tid numbers in logcat_text,
Wireshark code review
- [Wireshark-commits] master 96fb347: Remove some leftover debug printfs.,
Wireshark code review
- [Wireshark-commits] master f2fc562: Replace tvb_length(),
Wireshark code review
- [Wireshark-commits] master-1.12 350d011: elmi: Fix bug in message type coding,
Wireshark code review
- [Wireshark-commits] master-1.12 3e05ed9: CFM: display MEP ID in decimal in OAM Y.1731 Synthetic Loss Message and Reply PDU,
Wireshark code review
- [Wireshark-commits] master d7e277a: CANopen bugfixes,
Wireshark code review
- [Wireshark-commits] master c07e9fe: Add minimize and maximize buttons to the SCTP analysis windows.,
Wireshark code review
- [Wireshark-commits] master-1.12 fb308c7: display filter: the body of a range should only be a string, a field name or another range - not an unparsed element,
Wireshark code review
- [Wireshark-commits] master fecea97: VoIP Call (GTK): Fix Dereference of null pointer found by Clang analyzer,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 f18ced8: packet-amqp.c: Temporary/preliminary fix for Bug #10582 (crash),
Wireshark code review
- [Wireshark-commits] master 08475ff: README.heuristic: rework example code.,
Wireshark code review
- [Wireshark-commits] master 7d7fc47: Split the low-level print stream code into a separate file.,
Wireshark code review
- [Wireshark-commits] master 6e1214c: Fix comments.,
Wireshark code review
- [Wireshark-commits] master b19b12a: Get rid of write_headers global variable.,
Wireshark code review
- [Wireshark-commits] master c68e77b: Pass a capture_file * to write_psml_preamble() in tfshark as well.,
Wireshark code review
- [Wireshark-commits] master 741db4c: Get rid of another global in the print code.,
Wireshark code review
- [Wireshark-commits] master 01f9706: Add the required c flags for some test executables,
Wireshark code review
- [Wireshark-commits] master c61a037: Add version check in Geneve dissector.,
Wireshark code review
- [Wireshark-commits] master e2b597a: Fix problem where the profile bar moves further left every time Wireshark is run.,
Wireshark code review
- [Wireshark-commits] master 534b596: Cleanup packet-sccp.c in preparation of trying to remove sccp_info member of packet_info.,
Wireshark code review
- [Wireshark-commits] master-1.12 905e77a: Fix problem where the profile bar moves further left every time Wireshark is run.,
Wireshark code review
- [Wireshark-commits] master 08cf40e: Use dissector data to "return" XML data to XMPP dissector.,
Wireshark code review
- [Wireshark-commits] master e908804: Update symbol list.,
Wireshark code review
- [Wireshark-commits] master e50095c: Remove use of pinfo->private_data (which doesn't appear to be used anyway) and pass it as dissector data.,
Wireshark code review
- [Wireshark-commits] master-1.12 b6af7c7: Newlines at the ends of lines, please.,
Wireshark code review
- [Wireshark-commits] master b2030ca: [Automatic manuf, services and enterprise-numbers update for 2014-11-23],
Wireshark code review
- [Wireshark-commits] master-1.12 c3b16bf: [Automatic manuf, services and enterprise-numbers update for 2014-11-23],
Wireshark code review
- [Wireshark-commits] master-1.10 a1244a6: [Automatic manuf, services and enterprise-numbers update for 2014-11-23],
Wireshark code review
- [Wireshark-commits] master-1.12 0187a2c: Presumably the intent is to dump *non*-dummy entries.,
Wireshark code review
- [Wireshark-commits] master da5487f: Newlines at the ends of lines, please.,
Wireshark code review
- [Wireshark-commits] master 4d55e1f: Presumably the intent is to dump *non*-dummy entries.,
Wireshark code review
- [Wireshark-commits] master ec650d4: elf: separate ett for program and sections entries,
Wireshark code review
- [Wireshark-commits] master eb93f3b: Don't do unsafe pointer casting,
Wireshark code review
- [Wireshark-commits] master 6dbb97d: SSL: Implement Extended Master Secret,
Wireshark code review
- [Wireshark-commits] master daed807: Pass FrameID as data to the heuristic table, rather than use pinfo->private_data.,
Wireshark code review
- [Wireshark-commits] master 78849d0: SMTP: escape ASCII strings printed to COL_INFO,
Wireshark code review
- [Wireshark-commits] master 7309664: [SIP/DIAMETER] Reinstate the lost dfilter_store_sip_from_addr() and use it for 3GPP AVP 601 Public-Identity.,
Wireshark code review
- [Wireshark-commits] master 0c716f7: openflow; Fix a (no-effect) typo in openflow_version_values[],
Wireshark code review
- [Wireshark-commits] master-1.12 802e300: SMTP: escape ASCII strings printed to COL_INFO,
Wireshark code review
- [Wireshark-commits] master 953e6b1: Pass data to JSON through dissector data, not pinfo->private_data.,
Wireshark code review
- [Wireshark-commits] master-1.10 4fc25f5: SMTP: escape ASCII strings printed to COL_INFO,
Wireshark code review
- [Wireshark-commits] master 10803f2: Second attempt at putting a description in the preferences page,
Wireshark code review
- [Wireshark-commits] master 1f5dbb0: CPHA: Update versions lists,
Wireshark code review
- [Wireshark-commits] master 2baac34: CPHA : tvb_length -> tvb_reported_length,
Wireshark code review
- [Wireshark-commits] master 6b8fe87: Allow "(g)make tags" to work again,
Wireshark code review
- [Wireshark-commits] master 15f6f56: Revert "Allow "(g)make tags" to work again",
Wireshark code review
- [Wireshark-commits] master 4b57edb: MIPv6: Enhance ANI dissection,
Wireshark code review
- [Wireshark-commits] master e02c03b: Change capitalization of "DNS UDP [p]orts" to match "DNS TCP ports" in prefs,
Wireshark code review
- [Wireshark-commits] master 605a6ae: Mate: Fix indent (use tabs),
Wireshark code review
- [Wireshark-commits] master 1cdf644: A21: fix warning: no previous prototype for function ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 059c257: Allow html version of man pages to be found when running from build directory (they're in doc/ of the build directory).,
Wireshark code review
- [Wireshark-commits] master 159626c: Update debian symbols,
Wireshark code review
- [Wireshark-commits] master d5713e2: hostlist_table (GTK): Fix Dereference of null pointer found by Clang analyzer,
Wireshark code review
- [Wireshark-commits] master 4f8a6ec: TCP: fix wrongly set base_seq when ISN is 0 and tcp_relative_seq is enabled,
Wireshark code review
- [Wireshark-commits] master e899c3e: Eliminate proto_tree_add_text from some dissectors.,
Wireshark code review
- [Wireshark-commits] master 363b87a: Qt: support the -Y option to set an initial display filter,
Wireshark code review
- [Wireshark-commits] master 392dae5: Add new dissector for Shared Memory Communications over RDMA protocol (SMC-R),
Wireshark code review
- [Wireshark-commits] master 518bb10: Remove use of pinfo->private_data since it's not used anywhere.,
Wireshark code review
- [Wireshark-commits] master a600ef6: Have media dissector take its "media type parameter" from dissector data parameter instead of pinfo->private_data.,
Wireshark code review
- [Wireshark-commits] master c39776c: Remove unused ui_simple_dialog.h from qt Makefile.common,
Wireshark code review
- [Wireshark-commits] master b01ff09: canopen: Fixed tree expansion,
Wireshark code review
- [Wireshark-commits] master 7f22ce7: pre-commit tools: Add arg option to specify the commit id to be checked,
Wireshark code review
- [Wireshark-commits] master e3a04bb: Ensure dissector data parameter is used instead of pinfo->private_data when passing data between dissectors using the "media_type" subdissector.,
Wireshark code review
- [Wireshark-commits] master 152b0c9: Remove support for pinfo->private_data in "data-text-lines", "data-l1-events" and "urlencoded-form" dissectors. Data must be passed from parent through dissectors data parameter.,
Wireshark code review
- [Wireshark-commits] master 2015398: proto.c: proto_registrar_dump_values(): don't skip "same name" fields.,
Wireshark code review
- [Wireshark-commits] master e2132f9: openflow: Minor changes,
Wireshark code review
- [Wireshark-commits] master e2ef6c4: Add on to the dummy.cpp hack that forces wireshark to be linked with a c++ compiler to automatically create a dummy.cpp file and remove it when make clean is issued. This allows make tags to work again since the file isn't missing.,
Wireshark code review
- [Wireshark-commits] master 5b360a9: SCSI: type and scope fields are ignored in some SCSI persistent reserve service actions,
Wireshark code review
- [Wireshark-commits] master 2ebaa59: Consolidate sequence analysis code.,
Wireshark code review
- [Wireshark-commits] master f449be8: conversation_table: fix warning when generate documentation (doxygen),
Wireshark code review
- [Wireshark-commits] master 85ca1cf: conversation_table: fix indent (use 4spaces) and add modelines info,
Wireshark code review
- [Wireshark-commits] master e843c67: wccp: use pinfo-scope memory for addresses,
Wireshark code review
- [Wireshark-commits] master a559f2a: dec-dnart: use pinfo-scoped memory for addresses,
Wireshark code review
- [Wireshark-commits] master 5464bc6: canopen: Improve NMT error control and SYNC message dissection,
Wireshark code review
- [Wireshark-commits] master 7c47503: openflow: Use (what appear to be the) correct filter names for a few fields.,
Wireshark code review
- [Wireshark-commits] master ab8cad28: Remove sccp_info member from packet_info structure.,
Wireshark code review
- [Wireshark-commits] master 691f647: [MGCP] When changing tvb_length(tvb) -> tvb_reported_length(tvb) it turns out that tvb_new_subset(tvb, tvb_sectionbegin, sectionlen, -1) causes a problem as reported_length is set to -1, set it to sectionlen.,
Wireshark code review
- [Wireshark-commits] master 449bc19: Qt: support the -R option to set a read filter on the command line,
Wireshark code review
- [Wireshark-commits] master a2c2f87: Remove the use of pinfo->private_data from dissectors that just save it to restore it.,
Wireshark code review
- [Wireshark-commits] master a159ced: WCCP: Remove uneeded check (pinfo & info_tree),
Wireshark code review
- [Wireshark-commits] master d77c5a5: Update the URL for the CPUID instruction documentation.,
Wireshark code review
- [Wireshark-commits] master c2913d2: canopen: Enhanced SDO decoding,
Wireshark code review
- [Wireshark-commits] master cc893ab: XML: pass XML structure to caller through p_(add|get)_proto_data functions,
Wireshark code review
- [Wireshark-commits] master c28f280: Fix a number of dup hf[] filter-names probably resulting from cut/paste errs.,
Wireshark code review
- [Wireshark-commits] master 4469346: Fix a number of dup hf[] filter-names probably mostly resulting from cut/paste errs,
Wireshark code review
- [Wireshark-commits] master 121d9ae: Note that this document is a bit old.,
Wireshark code review
- [Wireshark-commits] master 608d83c: LEX and YACC are required,
Wireshark code review
- [Wireshark-commits] master b4b6a5d: canopen: LSS dissection,
Wireshark code review
- [Wireshark-commits] master a30f3d5: Qt: Add long option for -R (--read-filter) and -Y (--display-filter),
Wireshark code review
- [Wireshark-commits] master 8839d7b: Make the ENTTEC dissector reject packets that don't look like ENTTEC packets.,
Wireshark code review
- [Wireshark-commits] master 3f85761: RADIUS: Sync with FreeRADIUS Master,
Wireshark code review
- [Wireshark-commits] master a67d0d2: Eliminate proto_tree_add_text from packet-sna.c.,
Wireshark code review
- [Wireshark-commits] master afcdff0: Endpoint dialog (Qt): Add missing text to translate,
Wireshark code review
- [Wireshark-commits] master e8cda3b: TCP: move Windows Scaling and SCPS checks after options decoding,
Wireshark code review
- [Wireshark-commits] master-1.12 52b0ebc: TCP: move Windows Scaling and SCPS checks after options decoding,
Wireshark code review
- [Wireshark-commits] master 3355ed6: elf: fix FDE Count formatting,
Wireshark code review
- [Wireshark-commits] master-1.12 8ae9b53: dec-dnart: use pinfo-scoped memory for addresses,
Wireshark code review
- [Wireshark-commits] master-1.10 336ccc1: dec-dnart: use pinfo-scoped memory for addresses,
Wireshark code review
- [Wireshark-commits] master f1b37bc: Endpoint: wrong filter when select a UDP endpoint (INVALID == a.x.y.z ...),
Wireshark code review
- [Wireshark-commits] master ca95800: Endpoint: wrong filter when select a TCP endpoint (INVALID == a.x.y.z ...),
Wireshark code review
- [Wireshark-commits] master 8e17fd6: Add optional user Fast SER preference for SEL Fast Message Protocol,
Wireshark code review
- [Wireshark-commits] master 72b91a5: Add QNX' QNET protocol,
Wireshark code review
- [Wireshark-commits] master 1429986: Sadly, index() was the name of a routine in V7, so....,
Wireshark code review
- [Wireshark-commits] master 785ef83: Revert "Add QNX' QNET protocol",
Wireshark code review
- [Wireshark-commits] master 1aeab74: ieee80211; Rename some hf[] display filter names to fix dups and for clarity.,
Wireshark code review
- [Wireshark-commits] master e399382: Rename some hf[] display filter names to fix dups.,
Wireshark code review
- [Wireshark-commits] master 05516b0: Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.,
Wireshark code review
- [Wireshark-commits] master 81ab601: Clean up routine names, don't pass capture_file into libwireshark.,
Wireshark code review
- [Wireshark-commits] master e28a847: Fix tfshark.c to match changes to epan/print.[ch].,
Wireshark code review
- [Wireshark-commits] master 090a046: Update to reflect current reality.,
Wireshark code review
- [Wireshark-commits] master 10046cc: [Automatic manuf, services and enterprise-numbers update for 2014-11-30],
Wireshark code review
- [Wireshark-commits] master-1.12 b9cdc5d: [Automatic manuf, services and enterprise-numbers update for 2014-11-30],
Wireshark code review
- [Wireshark-commits] master-1.10 9cee3d9: [Automatic manuf, services and enterprise-numbers update for 2014-11-30],
Wireshark code review
- [Wireshark-commits] master 6c7af1d: Change some names to make them the same in multiple lists.,
Wireshark code review
- [Wireshark-commits] master 35b1bc5: win32: use target file format when checking if it supports comments,
Wireshark code review
- [Wireshark-commits] master-1.12 7ec1d33: win32: use target file format when checking if it supports comments,
Wireshark code review
- [Wireshark-commits] master-1.10 72bd999: win32: use target file format when checking if it supports comments,
Wireshark code review
Mail converted by MHonArc