Wireshark-commits: [Wireshark-commits] master 5464bc6: canopen: Improve NMT error control and SYNC

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2014 05:18:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5464bc69ae714168e8db55a01618822eb3a90cb8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5464bc6 by Enrico Jorns (ejo@xxxxxxxxxxxxxx):

    canopen: Improve NMT error control and SYNC message dissection
    
    1.  Also show Reserved/Toggle bit of NMT error control
    
      In case of the node guarding protocol this bit is used as a toggle bit.
      In case of the hearbeat protocol this bit is reserved.
    
      Reference: CiA 301 (rev 4.2.0), Chap. 7.2.8.3.2
    
    2. Show optional 'counter' parameter of SYNC messages if available
    
      Reference: CiA 301 (rev 4.2.0), Chap. 7.2.5.3.1
    
    Change-Id: I5dc0ab65e95fec4846a9c8bd8972ef2eba664ee2
    Reviewed-on: https://code.wireshark.org/review/5484
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a559f2a   dec-dnart: use pinfo-scoped memory for addresses
    adds  5464bc6   canopen: Improve NMT error control and SYNC message dissection


Summary of changes:
 epan/dissectors/packet-canopen.c |   22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)