Wireshark-commits: [Wireshark-commits] master-1.12 924db97: amqp: Fix a number of bugs in dissect_a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 4 Nov 2014 16:23:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=924db978814c60adc4e5e21a60f9692b1b43366c
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

924db97 by Bill Meier (wmeier@xxxxxxxxxxx):

    amqp: Fix a number of bugs in dissect_amqp_0_10_map().
    
     (Among other things: "2 ^ xxx" is *not* 2 to the xxx'th power).
    
    Change-Id: I893b72e853ecbb5d7e6259e950fb347e89eed6c2
    Reviewed-on: https://code.wireshark.org/review/5109
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit 9ac261f205b7b6cba646368433eac550c7a6acd7)
    Reviewed-on: https://code.wireshark.org/review/5110
    

Actions performed:

    from  bc53f57   Pass di to one more call to PIDL_dissect_uint8().
    adds  924db97   amqp: Fix a number of bugs in dissect_amqp_0_10_map().


Summary of changes:
 epan/dissectors/packet-amqp.c |   60 ++++++++++++++++++++++++-----------------
 1 file changed, 35 insertions(+), 25 deletions(-)