Wireshark-commits: [Wireshark-commits] master-1.12 b04ca79: Announce messages should only have a TL

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Nov 2014 23:03:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b04ca79036ee20f3f120318f3361dd7c7d9cc7c6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b04ca79 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Announce messages should only have a TLV if the message length is > 64.
    
    Also, cleaned up a unnecessary global variable.
    
    Bug: 10611
    
    Reviewed-on: https://code.wireshark.org/review/5029
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    
    Conflicts:
    	epan/dissectors/packet-ptp.c
    
    Change-Id: I42d849994af64cada09e9004afd41b4d0cb2887e
    Reviewed-on: https://code.wireshark.org/review/5061
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5b5024b   DNS: fix dissection of ISDN RR Sub Address field
    adds  b04ca79   Announce messages should only have a TLV if the message length is > 64.


Summary of changes:
 epan/dissectors/packet-ptp.c |  352 ++++++++++++++++++++++--------------------
 1 file changed, 183 insertions(+), 169 deletions(-)