Wireshark-commits: [Wireshark-commits] master 3b8ed36: DNS: NAPTR RR Replacement Length is incorrec

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Nov 2014 11:04:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b8ed366ddd149f2cc1428a713235c18afc192e7
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b8ed36 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DNS: NAPTR RR Replacement Length is incorrect
    
    It seems the Replacement Length field calculated by Wireshark (which Wireshark calls "rReplacement Length"), is the length of the first label of the DNS name in the Replacement, instead of the entire DNS name length.
    
    Issue found by Boaz
    
    Bug:10700
    Change-Id: I8b726f3a3bf316d688a40c3ade100d255ca3be42
    Reviewed-on: https://code.wireshark.org/review/5300
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  4960171   VoIP calls: Fixup whitespace.
    adds  3b8ed36   DNS: NAPTR RR Replacement Length is incorrect


Summary of changes:
 epan/dissectors/packet-dns.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)