Wireshark-commits: [Wireshark-commits] master 1af7c2b: Qt: Simplify disabling entries in ContextMen

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 5 Nov 2014 12:58:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1af7c2b8389e5c6544366bc60b50b2104ff294c0
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1af7c2b by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Qt: Simplify disabling entries in ContextMenu
    
    We have direct access to every entry (action) in ContextMenu.
    Use it instead of storing "actions" and checking its name.
    
    Change-Id: I97a1723898409faf13280c5655b7738661ab594b
    Reviewed-on: https://code.wireshark.org/review/5135
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  ce4be19   pim: BIDIR support (RFC 5015)
    adds  1af7c2b   Qt: Simplify disabling entries in ContextMenu


Summary of changes:
 ui/qt/packet_list.cpp |   68 +++++++++++++------------------------------------
 ui/qt/packet_list.h   |    2 --
 2 files changed, 18 insertions(+), 52 deletions(-)