Wireshark-commits: [Wireshark-commits] master 78849d0: SMTP: escape ASCII strings printed to COL_IN

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Nov 2014 16:11:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78849d0e6b0dde760c8bea40ce99e7a05711f3bf
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

78849d0 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SMTP: escape ASCII strings printed to COL_INFO
    
    This is already done automatically for the hf entries thanks to hfinfo_format_text() function
    
    Bug: 10536
    Change-Id: I9ee56b795234a94f0e59c82a96e3e6cedf71c4e6
    Reviewed-on: https://code.wireshark.org/review/5459
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  daed807   Pass FrameID as data to the heuristic table, rather than use pinfo->private_data.
    adds  78849d0   SMTP: escape ASCII strings printed to COL_INFO


Summary of changes:
 epan/dissectors/packet-smtp.c |   52 ++++++++++++++++++++++++-----------------
 1 file changed, 31 insertions(+), 21 deletions(-)