Wireshark-commits: [Wireshark-commits] master 4a86d62: Use ntoh24 instead of less readable and less

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 17 Nov 2014 20:07:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a86d622b1d7c66f30e3ccaedebcc0b9a93c96c5
Submitter: Jörg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a86d62 by Joerg Mayer (jmayer@xxxxxxxxx):

    Use ntoh24 instead of less readable and less correct code.
    Remove redundant / wrong comments.
    Add two small (helpful) comments :-)
    
    Change-Id: I9c5451587d744a8418e6a90139b771a055e93387
    Reviewed-on: https://code.wireshark.org/review/5366
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  82bb363   LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  4a86d62   Use ntoh24 instead of less readable and less correct code. Remove redundant / wrong comments. Add two small (helpful) comments :-)


Summary of changes:
 epan/dissectors/packet-wsmp.c |   20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)