Wireshark-commits: [Wireshark-commits] master 691f647: [MGCP] When changing tvb_length(tvb) -> tvb_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2014 12:48:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=691f647acdfee71ef37453f146674999a2b43b6c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

691f647 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    [MGCP] When changing tvb_length(tvb) -> tvb_reported_length(tvb) it turns
    out that tvb_new_subset(tvb, tvb_sectionbegin, sectionlen, -1) causes a
    problem as reported_length is set to -1, set it to sectionlen.
    
    Change-Id: I650d3fa1390be5add66ed44d0f70929b9eb0aad6
    Reviewed-on: https://code.wireshark.org/review/5505
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ab8cad28  Remove sccp_info member from packet_info structure.
    adds  691f647   [MGCP] When changing tvb_length(tvb) -> tvb_reported_length(tvb) it turns out that tvb_new_subset(tvb, tvb_sectionbegin, sectionlen, -1) causes a problem as reported_length is set to -1, set it to sectionlen.


Summary of changes:
 epan/dissectors/packet-mgcp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)